You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "dlg99 (via GitHub)" <gi...@apache.org> on 2024/09/16 19:22:14 UTC
[PR] [improve] Upgrade opensearch sink to client 2.16 and tests to use server 2.16.0 [pulsar]
dlg99 opened a new pull request, #23312:
URL: https://github.com/apache/pulsar/pull/23312
### Motivation
Support OpenSearch 2.16.0
### Modifications
Upgraded opensearch sink to client 2.16 and updated tests to use server 2.16.0
### Verifying this change
This change is already covered by existing tests, such as Pilsar-IO integration tests.
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*OpenSearch client is upgraded to v.2.16.0, this only affects OpenSearch sink*
- [x] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [x] Anything that affects deployment
### Documentation
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
Already documented
### Matching PR in forked repository
PR in forked repository: https://github.com/dlg99/pulsar/pull/20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve] Upgrade opensearch sink to client 2.16 and tests to use server 2.16.0 [pulsar]
Posted by "dao-jun (via GitHub)" <gi...@apache.org>.
dao-jun merged PR #23312:
URL: https://github.com/apache/pulsar/pull/23312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve] Upgrade opensearch sink to client 2.16 and tests to use server 2.16.0 [pulsar]
Posted by "jcmfernandes (via GitHub)" <gi...@apache.org>.
jcmfernandes commented on PR #23312:
URL: https://github.com/apache/pulsar/pull/23312#issuecomment-2449575461
This means that we can update https://pulsar.apache.org/docs/next/io-elasticsearch-sink/ as Pulsar can now use ES 8 and OS 2, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve] Upgrade opensearch sink to client 2.16 and tests to use server 2.16.0 [pulsar]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #23312:
URL: https://github.com/apache/pulsar/pull/23312#issuecomment-2354027148
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/23312?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 74.54%. Comparing base [(`bbc6224`)](https://app.codecov.io/gh/apache/pulsar/commit/bbc62245c5ddba1de4b1e7cee4ab49334bc36277?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`fb3397c`)](https://app.codecov.io/gh/apache/pulsar/commit/fb3397c70e0a8de6675e942e88203965a8dc15d3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 580 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/pulsar/pull/23312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #23312 +/- ##
============================================
+ Coverage 73.57% 74.54% +0.97%
- Complexity 32624 34294 +1670
============================================
Files 1877 1927 +50
Lines 139502 145043 +5541
Branches 15299 15863 +564
============================================
+ Hits 102638 108129 +5491
+ Misses 28908 28635 -273
- Partials 7956 8279 +323
```
| [Flag](https://app.codecov.io/gh/apache/pulsar/pull/23312/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [inttests](https://app.codecov.io/gh/apache/pulsar/pull/23312/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `27.89% <ø> (+3.30%)` | :arrow_up: |
| [systests](https://app.codecov.io/gh/apache/pulsar/pull/23312/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.72% <0.00%> (+0.39%)` | :arrow_up: |
| [unittests](https://app.codecov.io/gh/apache/pulsar/pull/23312/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.89% <100.00%> (+1.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/pulsar/pull/23312?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/pulsar/io/elasticsearch/ElasticSearchConfig.java](https://app.codecov.io/gh/apache/pulsar/pull/23312?src=pr&el=tree&filepath=pulsar-io%2Felastic-search%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fio%2Felasticsearch%2FElasticSearchConfig.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWlvL2VsYXN0aWMtc2VhcmNoL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9wdWxzYXIvaW8vZWxhc3RpY3NlYXJjaC9FbGFzdGljU2VhcmNoQ29uZmlnLmphdmE=) | `89.83% <100.00%> (-0.85%)` | :arrow_down: |
| [...ient/opensearch/OpenSearchHighLevelRestClient.java](https://app.codecov.io/gh/apache/pulsar/pull/23312?src=pr&el=tree&filepath=pulsar-io%2Felastic-search%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fio%2Felasticsearch%2Fclient%2Fopensearch%2FOpenSearchHighLevelRestClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWlvL2VsYXN0aWMtc2VhcmNoL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9wdWxzYXIvaW8vZWxhc3RpY3NlYXJjaC9jbGllbnQvb3BlbnNlYXJjaC9PcGVuU2VhcmNoSGlnaExldmVsUmVzdENsaWVudC5qYXZh) | `88.02% <ø> (-0.25%)` | :arrow_down: |
... and [567 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/23312/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org