You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/05/11 10:41:54 UTC
[GitHub] [rocketmq] areyouok opened a new pull request #1983: fix Broker2Client logs
areyouok opened a new pull request #1983:
URL: https://github.com/apache/rocketmq/pull/1983
## What is the purpose of the change
There are several problems in Broker2Client which cause field miss in logs.
## Brief changelog
Fix logs.
## Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin merged pull request #1983: [ISSUE #1992] fix Broker2Client logs
Posted by GitBox <gi...@apache.org>.
RongtongJin merged pull request #1983:
URL: https://github.com/apache/rocketmq/pull/1983
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #1983: fix Broker2Client logs
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #1983:
URL: https://github.com/apache/rocketmq/pull/1983#issuecomment-626654792
[](https://coveralls.io/builds/30696990)
Coverage increased (+0.06%) to 50.894% when pulling **16b38ba9b2fd0d7a0f0da4da05db013d1da86b8e on areyouok:fix_Broker2Client_log** into **af0770522dd6daea904b9c766046b175b88a5819 on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] areyouok commented on a change in pull request #1983: fix Broker2Client logs
Posted by GitBox <gi...@apache.org>.
areyouok commented on a change in pull request #1983:
URL: https://github.com/apache/rocketmq/pull/1983#discussion_r425093561
##########
File path: broker/src/main/java/org/apache/rocketmq/broker/client/net/Broker2Client.java
##########
@@ -96,7 +97,7 @@ public void notifyConsumerIdsChanged(
try {
this.brokerController.getRemotingServer().invokeOneway(channel, request, 10);
} catch (Exception e) {
- log.error("notifyConsumerIdsChanged exception, " + consumerGroup, e.getMessage());
+ log.error("notifyConsumerIdsChanged exception. group={}, error={}", consumerGroup, e.toString());
Review comment:
Because it may cause too many stacktraces. These error occurs when client is not online.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-io commented on pull request #1983: fix Broker2Client logs
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1983:
URL: https://github.com/apache/rocketmq/pull/1983#issuecomment-626654852
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/1983?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`develop@3d13dae`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/rocketmq/pull/1983?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #1983 +/- ##
==========================================
Coverage ? 45.09%
Complexity ? 4194
==========================================
Files ? 545
Lines ? 35732
Branches ? 4744
==========================================
Hits ? 16113
Misses ? 17573
Partials ? 2046
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/1983?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/1983?src=pr&el=footer). Last update [3d13dae...16b38ba](https://codecov.io/gh/apache/rocketmq/pull/1983?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org