You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jetspeed-dev@portals.apache.org by "Vitaly Baranovsky (JIRA)" <je...@portals.apache.org> on 2007/08/02 14:21:53 UTC
[jira] Created: (JS2-764) There are much DOCTYPE directives in
every result page of portal
There are much DOCTYPE directives in every result page of portal
-----------------------------------------------------------------
Key: JS2-764
URL: https://issues.apache.org/jira/browse/JS2-764
Project: Jetspeed 2
Issue Type: Bug
Affects Versions: 2.1.2
Reporter: Vitaly Baranovsky
Priority: Minor
In result code of every portal pages there are much strings:
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
This is because layout.vm contains this word at the start of file. So, I think, this string has to be clear out from layout.vm to another place, to achieve only one DOCTYPE string per portal page
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
[jira] Commented: (JS2-764) There are much DOCTYPE directives in
every result page of portal
Posted by "Thorsten Berger (JIRA)" <je...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/JS2-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12531475 ]
Thorsten Berger commented on JS2-764:
-------------------------------------
Thanks for the quick response, Woonsan. I'm fully d'accord with your explanation.
Regards, Thorsten
> There are much DOCTYPE directives in every result page of portal
> -----------------------------------------------------------------
>
> Key: JS2-764
> URL: https://issues.apache.org/jira/browse/JS2-764
> Project: Jetspeed 2
> Issue Type: Bug
> Affects Versions: 2.1.2
> Reporter: Vitaly Baranovsky
> Assignee: Woonsan Ko
> Priority: Minor
> Fix For: 2.1.3, 2.2
>
>
> In result code of every portal pages there are much strings:
> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
> This is because layout.vm contains this word at the start of file. So, I think, this string has to be clear out from layout.vm to another place, to achieve only one DOCTYPE string per portal page
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
[jira] Resolved: (JS2-764) There are much DOCTYPE directives in
every result page of portal
Posted by "Woonsan Ko (JIRA)" <je...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/JS2-764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Woonsan Ko resolved JS2-764.
----------------------------
Resolution: Fixed
Fixed. Thank you very much, Thorsten. :)
> There are much DOCTYPE directives in every result page of portal
> -----------------------------------------------------------------
>
> Key: JS2-764
> URL: https://issues.apache.org/jira/browse/JS2-764
> Project: Jetspeed 2
> Issue Type: Bug
> Affects Versions: 2.1.2
> Reporter: Vitaly Baranovsky
> Assignee: Woonsan Ko
> Priority: Minor
> Fix For: 2.1.3, 2.2
>
>
> In result code of every portal pages there are much strings:
> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
> This is because layout.vm contains this word at the start of file. So, I think, this string has to be clear out from layout.vm to another place, to achieve only one DOCTYPE string per portal page
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
[jira] Assigned: (JS2-764) There are much DOCTYPE directives in
every result page of portal
Posted by "Woonsan Ko (JIRA)" <je...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/JS2-764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Woonsan Ko reassigned JS2-764:
------------------------------
Assignee: Woonsan Ko
> There are much DOCTYPE directives in every result page of portal
> -----------------------------------------------------------------
>
> Key: JS2-764
> URL: https://issues.apache.org/jira/browse/JS2-764
> Project: Jetspeed 2
> Issue Type: Bug
> Affects Versions: 2.1.2
> Reporter: Vitaly Baranovsky
> Assignee: Woonsan Ko
> Priority: Minor
>
> In result code of every portal pages there are much strings:
> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
> This is because layout.vm contains this word at the start of file. So, I think, this string has to be clear out from layout.vm to another place, to achieve only one DOCTYPE string per portal page
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
[jira] Commented: (JS2-764) There are much DOCTYPE directives in
every result page of portal
Posted by "Thorsten Berger (JIRA)" <je...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/JS2-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12531324 ]
Thorsten Berger commented on JS2-764:
-------------------------------------
Unfortunately the DOCTYPE in the decorator's header.vm is not recognized by Internet Explorer, as it's not the first content in the html page: There's one comment (originating from the layout.vm) in front: <!-- Decorator tigris ${decoTop} - ${decoBottom}-->
No problem with Firefox, the DOCTYPE is recognized there, despite the comment.
There has been an issue (JS2-483) dealing with css problems by missing DOCTYPEs.
So I'd like to propose putting back the DOCTYPE into layout.vm, but now checking for being the root fragment, e.g.:
#if($myFragment == $myPage.getRootFragment())
## set the DOCTYPE and assure it's only inserted once
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
#set($isRoot=true)
#end
Another solution would be to remove the mentioned comment. What do you think?
Regards, Thorsten
> There are much DOCTYPE directives in every result page of portal
> -----------------------------------------------------------------
>
> Key: JS2-764
> URL: https://issues.apache.org/jira/browse/JS2-764
> Project: Jetspeed 2
> Issue Type: Bug
> Affects Versions: 2.1.2
> Reporter: Vitaly Baranovsky
> Assignee: Woonsan Ko
> Priority: Minor
> Fix For: 2.1.3, 2.2
>
>
> In result code of every portal pages there are much strings:
> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
> This is because layout.vm contains this word at the start of file. So, I think, this string has to be clear out from layout.vm to another place, to achieve only one DOCTYPE string per portal page
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
[jira] Commented: (JS2-764) There are much DOCTYPE directives in
every result page of portal
Posted by "Woonsan Ko (JIRA)" <je...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/JS2-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524033 ]
Woonsan Ko commented on JS2-764:
--------------------------------
The problem can be found when a page contains multiple layouts. (That is, when there are inline layout fragments.)
I agree with Vitaly that the string should be cleared out from layout.vm.
I think that header.vm and desktop.vm should have this line at the top.
I'm going to finish this kind of clearing work in a couple of days.
> There are much DOCTYPE directives in every result page of portal
> -----------------------------------------------------------------
>
> Key: JS2-764
> URL: https://issues.apache.org/jira/browse/JS2-764
> Project: Jetspeed 2
> Issue Type: Bug
> Affects Versions: 2.1.2
> Reporter: Vitaly Baranovsky
> Priority: Minor
>
> In result code of every portal pages there are much strings:
> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
> This is because layout.vm contains this word at the start of file. So, I think, this string has to be clear out from layout.vm to another place, to achieve only one DOCTYPE string per portal page
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
[jira] Reopened: (JS2-764) There are much DOCTYPE directives in
every result page of portal
Posted by "Woonsan Ko (JIRA)" <je...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/JS2-764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Woonsan Ko reopened JS2-764:
----------------------------
> There are much DOCTYPE directives in every result page of portal
> -----------------------------------------------------------------
>
> Key: JS2-764
> URL: https://issues.apache.org/jira/browse/JS2-764
> Project: Jetspeed 2
> Issue Type: Bug
> Affects Versions: 2.1.2
> Reporter: Vitaly Baranovsky
> Assignee: Woonsan Ko
> Priority: Minor
> Fix For: 2.1.3, 2.2
>
>
> In result code of every portal pages there are much strings:
> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
> This is because layout.vm contains this word at the start of file. So, I think, this string has to be clear out from layout.vm to another place, to achieve only one DOCTYPE string per portal page
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
[jira] Commented: (JS2-764) There are much DOCTYPE directives in
every result page of portal
Posted by "Woonsan Ko (JIRA)" <je...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/JS2-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12531404 ]
Woonsan Ko commented on JS2-764:
--------------------------------
Thanks for your pointing out the mistake, Thorsten.
I'd like to reopen this issue and fix by your second solution, removing the comment.
IMO, header templates are more responsible for all header things including doctype, while layout templates are responsible mainly for laying out fragments.
So, I assist your second solution, and I'll fix this problem until this Friday if there's no objection.
> There are much DOCTYPE directives in every result page of portal
> -----------------------------------------------------------------
>
> Key: JS2-764
> URL: https://issues.apache.org/jira/browse/JS2-764
> Project: Jetspeed 2
> Issue Type: Bug
> Affects Versions: 2.1.2
> Reporter: Vitaly Baranovsky
> Assignee: Woonsan Ko
> Priority: Minor
> Fix For: 2.1.3, 2.2
>
>
> In result code of every portal pages there are much strings:
> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
> This is because layout.vm contains this word at the start of file. So, I think, this string has to be clear out from layout.vm to another place, to achieve only one DOCTYPE string per portal page
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
[jira] Resolved: (JS2-764) There are much DOCTYPE directives in
every result page of portal
Posted by "Woonsan Ko (JIRA)" <je...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/JS2-764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Woonsan Ko resolved JS2-764.
----------------------------
Resolution: Fixed
Fix Version/s: 2.2
2.1.3
Fixed.
The problem can be found when a page contains multiple layouts. (That is, when there are inner
layout fragments.)
Only theme header templates such as header.vm may have DocType declaration, and DocType
declaration should be removed in the layout templates.
Removed the declarations from the layout templates and added to theme header templates.
> There are much DOCTYPE directives in every result page of portal
> -----------------------------------------------------------------
>
> Key: JS2-764
> URL: https://issues.apache.org/jira/browse/JS2-764
> Project: Jetspeed 2
> Issue Type: Bug
> Affects Versions: 2.1.2
> Reporter: Vitaly Baranovsky
> Assignee: Woonsan Ko
> Priority: Minor
> Fix For: 2.1.3, 2.2
>
>
> In result code of every portal pages there are much strings:
> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
> This is because layout.vm contains this word at the start of file. So, I think, this string has to be clear out from layout.vm to another place, to achieve only one DOCTYPE string per portal page
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org