You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Daniel Dai (JIRA)" <ji...@apache.org> on 2010/11/12 01:40:13 UTC
[jira] Created: (PIG-1719) New logical plan: FieldSchema generation
for BinCond is wrong
New logical plan: FieldSchema generation for BinCond is wrong
-------------------------------------------------------------
Key: PIG-1719
URL: https://issues.apache.org/jira/browse/PIG-1719
Project: Pig
Issue Type: Bug
Components: impl
Affects Versions: 0.8.0
Reporter: Daniel Dai
Assignee: Daniel Dai
Fix For: 0.8.0
New logical plan generate incomplete schema for BinCond, if the expression for BinCond is of complex type. Eg,
{code}
a = load '1.txt' as (a0, a1:int);
b = group a by a0;
c = foreach b generate FLATTEN((IsEmpty(a)?{(65535)}:sequence.FIRST(a.a1)));
{code}
The right schema for c is (int), however, in current code, we get null schema. This is because BinCond should get the schema {(int)}, but we get empty bag {}.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1719) New logical plan: FieldSchema generation
for BinCond is wrong
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1719:
----------------------------
Attachment: (was: PIG-1719-1.patch)
> New logical plan: FieldSchema generation for BinCond is wrong
> -------------------------------------------------------------
>
> Key: PIG-1719
> URL: https://issues.apache.org/jira/browse/PIG-1719
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.8.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.8.0
>
> Attachments: PIG-1719-0.patch, PIG-1719-1.patch
>
>
> New logical plan generate incomplete schema for BinCond, if the expression for BinCond is of complex type. Eg,
> {code}
> a = load '1.txt' as (a0, a1:int);
> b = group a by a0;
> c = foreach b generate FLATTEN((IsEmpty(a)?{(65535)}:sequence.FIRST(a.a1)));
> {code}
> The right schema for c is (int), however, in current code, we get null schema. This is because BinCond should get the schema {(int)}, but we get empty bag {}.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1719) New logical plan: FieldSchema generation
for BinCond is wrong
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1719:
----------------------------
Attachment: PIG-1719-0.patch
PIG-1719-0.patch demonstrate the idea to fix it. It is not a full patch yet.
> New logical plan: FieldSchema generation for BinCond is wrong
> -------------------------------------------------------------
>
> Key: PIG-1719
> URL: https://issues.apache.org/jira/browse/PIG-1719
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.8.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.8.0
>
> Attachments: PIG-1719-0.patch
>
>
> New logical plan generate incomplete schema for BinCond, if the expression for BinCond is of complex type. Eg,
> {code}
> a = load '1.txt' as (a0, a1:int);
> b = group a by a0;
> c = foreach b generate FLATTEN((IsEmpty(a)?{(65535)}:sequence.FIRST(a.a1)));
> {code}
> The right schema for c is (int), however, in current code, we get null schema. This is because BinCond should get the schema {(int)}, but we get empty bag {}.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (PIG-1719) New logical plan: FieldSchema
generation for BinCond is wrong
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai resolved PIG-1719.
-----------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
test-patch result:
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
All tests pass.
Patch committed to both trunk and 0.8 branch.
> New logical plan: FieldSchema generation for BinCond is wrong
> -------------------------------------------------------------
>
> Key: PIG-1719
> URL: https://issues.apache.org/jira/browse/PIG-1719
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.8.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.8.0
>
> Attachments: PIG-1719-0.patch, PIG-1719-1.patch
>
>
> New logical plan generate incomplete schema for BinCond, if the expression for BinCond is of complex type. Eg,
> {code}
> a = load '1.txt' as (a0, a1:int);
> b = group a by a0;
> c = foreach b generate FLATTEN((IsEmpty(a)?{(65535)}:sequence.FIRST(a.a1)));
> {code}
> The right schema for c is (int), however, in current code, we get null schema. This is because BinCond should get the schema {(int)}, but we get empty bag {}.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1719) New logical plan: FieldSchema generation
for BinCond is wrong
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1719:
----------------------------
Attachment: PIG-1719-1.patch
> New logical plan: FieldSchema generation for BinCond is wrong
> -------------------------------------------------------------
>
> Key: PIG-1719
> URL: https://issues.apache.org/jira/browse/PIG-1719
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.8.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.8.0
>
> Attachments: PIG-1719-0.patch, PIG-1719-1.patch
>
>
> New logical plan generate incomplete schema for BinCond, if the expression for BinCond is of complex type. Eg,
> {code}
> a = load '1.txt' as (a0, a1:int);
> b = group a by a0;
> c = foreach b generate FLATTEN((IsEmpty(a)?{(65535)}:sequence.FIRST(a.a1)));
> {code}
> The right schema for c is (int), however, in current code, we get null schema. This is because BinCond should get the schema {(int)}, but we get empty bag {}.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1719) New logical plan: FieldSchema generation
for BinCond is wrong
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1719:
----------------------------
Attachment: PIG-1719-1.patch
> New logical plan: FieldSchema generation for BinCond is wrong
> -------------------------------------------------------------
>
> Key: PIG-1719
> URL: https://issues.apache.org/jira/browse/PIG-1719
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.8.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.8.0
>
> Attachments: PIG-1719-0.patch, PIG-1719-1.patch
>
>
> New logical plan generate incomplete schema for BinCond, if the expression for BinCond is of complex type. Eg,
> {code}
> a = load '1.txt' as (a0, a1:int);
> b = group a by a0;
> c = foreach b generate FLATTEN((IsEmpty(a)?{(65535)}:sequence.FIRST(a.a1)));
> {code}
> The right schema for c is (int), however, in current code, we get null schema. This is because BinCond should get the schema {(int)}, but we get empty bag {}.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1719) New logical plan: FieldSchema
generation for BinCond is wrong
Posted by "Richard Ding (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933533#action_12933533 ]
Richard Ding commented on PIG-1719:
-----------------------------------
+1.
> New logical plan: FieldSchema generation for BinCond is wrong
> -------------------------------------------------------------
>
> Key: PIG-1719
> URL: https://issues.apache.org/jira/browse/PIG-1719
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.8.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.8.0
>
> Attachments: PIG-1719-0.patch, PIG-1719-1.patch
>
>
> New logical plan generate incomplete schema for BinCond, if the expression for BinCond is of complex type. Eg,
> {code}
> a = load '1.txt' as (a0, a1:int);
> b = group a by a0;
> c = foreach b generate FLATTEN((IsEmpty(a)?{(65535)}:sequence.FIRST(a.a1)));
> {code}
> The right schema for c is (int), however, in current code, we get null schema. This is because BinCond should get the schema {(int)}, but we get empty bag {}.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.