You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Cristian Kalkhoff (Created) (JIRA)" <ji...@apache.org> on 2012/02/02 09:05:53 UTC
[jira] [Created] (WICKET-4381) Component.renderHead(...) doesn't
check if sub classes called super
Component.renderHead(...) doesn't check if sub classes called super
-------------------------------------------------------------------
Key: WICKET-4381
URL: https://issues.apache.org/jira/browse/WICKET-4381
Project: Wicket
Issue Type: Improvement
Components: wicket
Reporter: Cristian Kalkhoff
When I override onBeforeRender and forget about calling super.onBeforeRender, an exception is thrown. I would like to have this very same behaviour in other methods, especially in Component.renderHead(...);
While I can do it myself in my base page, I guess it would be a nice api extension.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4381) Component.renderHead(...) doesn't
check if sub classes called super
Posted by "Christian Kalkhoff (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198601#comment-13198601 ]
Christian Kalkhoff commented on WICKET-4381:
--------------------------------------------
Good point. So in my case it would be better to provide the check myself in the base class. BTW. Great work! :)
> Component.renderHead(...) doesn't check if sub classes called super
> -------------------------------------------------------------------
>
> Key: WICKET-4381
> URL: https://issues.apache.org/jira/browse/WICKET-4381
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Reporter: Christian Kalkhoff
>
> When I override onBeforeRender and forget about calling super.onBeforeRender, an exception is thrown. I would like to have this very same behaviour in other methods, especially in Component.renderHead(...);
> While I can do it myself in my base page, I guess it would be a nice api extension.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4381) Component.renderHead(...) doesn't
check if sub classes called super
Posted by "Martin Grigorov (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-4381.
-------------------------------------
Resolution: Won't Fix
> Component.renderHead(...) doesn't check if sub classes called super
> -------------------------------------------------------------------
>
> Key: WICKET-4381
> URL: https://issues.apache.org/jira/browse/WICKET-4381
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Reporter: Christian Kalkhoff
>
> When I override onBeforeRender and forget about calling super.onBeforeRender, an exception is thrown. I would like to have this very same behaviour in other methods, especially in Component.renderHead(...);
> While I can do it myself in my base page, I guess it would be a nice api extension.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4381) Component.renderHead(...) doesn't
check if sub classes called super
Posted by "Martin Grigorov (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198598#comment-13198598 ]
Martin Grigorov commented on WICKET-4381:
-----------------------------------------
What if a sub-component want to override its parent's contribution completely ?
E.g. a third party component delivers some predefined .css which I don't like (e.g. some colors don't match my app style). By not calling super.renderHead() I can do provide my version of the required .css. With the exception I'll have to deliver both .css resources which is not a good option.
> Component.renderHead(...) doesn't check if sub classes called super
> -------------------------------------------------------------------
>
> Key: WICKET-4381
> URL: https://issues.apache.org/jira/browse/WICKET-4381
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Reporter: Christian Kalkhoff
>
> When I override onBeforeRender and forget about calling super.onBeforeRender, an exception is thrown. I would like to have this very same behaviour in other methods, especially in Component.renderHead(...);
> While I can do it myself in my base page, I guess it would be a nice api extension.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira