You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/22 05:55:16 UTC
[GitHub] [spark] MaxGekk opened a new pull request #27977:
[SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the
rebase flag out of function bodies
MaxGekk opened a new pull request #27977: [SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27977
### What changes were proposed in this pull request?
1. The tests added by #27953 are moved from `AvroLogicalTypeSuite` to `AvroSuite`.
2. Checking of the `rebaseDateTime` flag is moved out from functions bodies.
This is a backport of https://github.com/apache/spark/pull/27964
### Why are the changes needed?
1. The tests are moved because they are not directly related to logical types.
2. Checking the flag out of functions bodies should improve performance.
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
By running Avro tests via the command `build/sbt avro/test`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27977:
[SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the
rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27977: [SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27977#issuecomment-602153064
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27977:
[SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the
rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27977: [SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27977#issuecomment-602153064
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan removed a comment on issue #27977:
[SPARK-31183][SQL][FOLLOWUP][3.0] Move rebase tests to `AvroSuite` and
check the rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
cloud-fan removed a comment on issue #27977: [SPARK-31183][SQL][FOLLOWUP][3.0] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27977#issuecomment-602393675
thanks, merging to 3.0!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27977:
[SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the
rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27977: [SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27977#issuecomment-602153066
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24865/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27977:
[SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the
rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27977: [SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27977#issuecomment-602155101
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120151/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27977:
[SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the
rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27977: [SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27977#issuecomment-602152833
**[Test build #120151 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120151/testReport)** for PR 27977 at commit [`eba6648`](https://github.com/apache/spark/commit/eba66481cb92ffd77213efc9d798e59488aeb654).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27977:
[SPARK-31183][SQL][FOLLOWUP][3.0] Move rebase tests to `AvroSuite` and
check the rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27977: [SPARK-31183][SQL][FOLLOWUP][3.0] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27977#issuecomment-602380901
Thank you, @MaxGekk and @HyukjinKwon !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27977:
[SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the
rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27977: [SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27977#issuecomment-602155101
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120151/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27977:
[SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the
rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27977: [SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27977#issuecomment-602154929
**[Test build #120151 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120151/testReport)** for PR 27977 at commit [`eba6648`](https://github.com/apache/spark/commit/eba66481cb92ffd77213efc9d798e59488aeb654).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27977:
[SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the
rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27977: [SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27977#issuecomment-602152833
**[Test build #120151 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120151/testReport)** for PR 27977 at commit [`eba6648`](https://github.com/apache/spark/commit/eba66481cb92ffd77213efc9d798e59488aeb654).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27977:
[SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the
rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27977: [SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27977#issuecomment-602155098
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #27977:
[SPARK-31183][SQL][FOLLOWUP][3.0] Move rebase tests to `AvroSuite` and
check the rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #27977: [SPARK-31183][SQL][FOLLOWUP][3.0] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27977
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27977:
[SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the
rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27977: [SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27977#issuecomment-602153066
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24865/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27977:
[SPARK-31183][SQL][FOLLOWUP][3.0] Move rebase tests to `AvroSuite` and
check the rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27977: [SPARK-31183][SQL][FOLLOWUP][3.0] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27977#issuecomment-602374308
Merged to branch-3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27977:
[SPARK-31183][SQL][FOLLOWUP][3.0] Move rebase tests to `AvroSuite` and
check the rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27977: [SPARK-31183][SQL][FOLLOWUP][3.0] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27977#issuecomment-602393675
thanks, merging to 3.0!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27977:
[SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the
rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27977: [SPARK-31183][SQL][FOLLOWUP] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27977#issuecomment-602155098
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27977:
[SPARK-31183][SQL][FOLLOWUP][3.0] Move rebase tests to `AvroSuite` and
check the rebase flag out of function bodies
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27977: [SPARK-31183][SQL][FOLLOWUP][3.0] Move rebase tests to `AvroSuite` and check the rebase flag out of function bodies
URL: https://github.com/apache/spark/pull/27977#issuecomment-602393765
thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org