You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2016/01/07 00:41:02 UTC

Re: Review Request 41817: Changed slave isolator interface, updated mesos isolator, isolator tests and mock isolator.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41817/
-----------------------------------------------------------

(Updated Jan. 6, 2016, 3:41 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-4240
    https://issues.apache.org/jira/browse/MESOS-4240


Repository: mesos


Description
-------

Changed slave isolator interface, updated mesos isolator, isolator tests and mock isolator.


Diffs (updated)
-----

  include/mesos/slave/isolator.hpp 95a2933988ea7c9b9404df5e12031f134712b2b5 
  src/slave/containerizer/mesos/isolator.hpp 937f253656d36ed10b47ceeb0b6101f212e65586 
  src/slave/containerizer/mesos/isolator.cpp 493b5dd26cf0e8f986381a502cfa6d1dde6573d4 
  src/tests/containerizer/isolator.hpp e4101b188560bd857ea104f61f52f27c880e7731 
  src/tests/containerizer/isolator_tests.cpp 91178b69ccbf5b6cbf64421e5602e6d554fc34ca 
  src/tests/containerizer/mesos_containerizer_tests.cpp 95b493c6f479eef52ee0c9a44ac40254ed76ebae 

Diff: https://reviews.apache.org/r/41817/diff/


Testing
-------

make check (ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song


Re: Review Request 41817: Changed slave isolator interface, updated mesos isolator, isolator tests and mock isolator.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41817/#review113370
-----------------------------------------------------------

Ship it!


Ship It!

- Jie Yu


On Jan. 6, 2016, 11:41 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41817/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2016, 11:41 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4240
>     https://issues.apache.org/jira/browse/MESOS-4240
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changed slave isolator interface, updated mesos isolator, isolator tests and mock isolator.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/isolator.hpp 95a2933988ea7c9b9404df5e12031f134712b2b5 
>   src/slave/containerizer/mesos/isolator.hpp 937f253656d36ed10b47ceeb0b6101f212e65586 
>   src/slave/containerizer/mesos/isolator.cpp 493b5dd26cf0e8f986381a502cfa6d1dde6573d4 
>   src/tests/containerizer/isolator.hpp e4101b188560bd857ea104f61f52f27c880e7731 
>   src/tests/containerizer/isolator_tests.cpp 91178b69ccbf5b6cbf64421e5602e6d554fc34ca 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 95b493c6f479eef52ee0c9a44ac40254ed76ebae 
> 
> Diff: https://reviews.apache.org/r/41817/diff/
> 
> 
> Testing
> -------
> 
> make check (ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Re: Review Request 41817: Changed slave isolator interface and updated correspondings.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41817/
-----------------------------------------------------------

(Updated Jan. 8, 2016, 10:18 a.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Changes
-------

Shorten commit message.


Summary (updated)
-----------------

Changed slave isolator interface and updated correspondings.


Bugs: MESOS-4240
    https://issues.apache.org/jira/browse/MESOS-4240


Repository: mesos


Description (updated)
-------

Changed slave isolator interface and updated correspondings.


Diffs (updated)
-----

  include/mesos/slave/isolator.hpp 95a2933988ea7c9b9404df5e12031f134712b2b5 
  src/slave/containerizer/mesos/isolator.hpp 937f253656d36ed10b47ceeb0b6101f212e65586 
  src/slave/containerizer/mesos/isolator.cpp 493b5dd26cf0e8f986381a502cfa6d1dde6573d4 
  src/tests/containerizer/isolator.hpp e4101b188560bd857ea104f61f52f27c880e7731 
  src/tests/containerizer/isolator_tests.cpp 91178b69ccbf5b6cbf64421e5602e6d554fc34ca 
  src/tests/containerizer/mesos_containerizer_tests.cpp 95b493c6f479eef52ee0c9a44ac40254ed76ebae 

Diff: https://reviews.apache.org/r/41817/diff/


Testing
-------

make check (ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song