[Impala-CR](cdh5-2.2.0_5.4.x) IMPALA-2264: fix edge cases for decimal/integer cast

["Anuj Phadke (Code Review)" <ge...@cloudera.org>]

Hello Internal Jenkins, Tim Armstrong,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/2344

to review the following change.

Change subject: IMPALA-2264: fix edge cases for decimal/integer cast
......................................................................

IMPALA-2264: fix edge cases for decimal/integer cast

Previously a bug allowed decimals to be cast to slightly smaller integer
types, e.g. DECIMAL(3,0) with range [-999,999] could be cast to TINYINT
with range [-128,127]. Decimals aside from this edge case (e.g.
DECIMAL(2,0) and DECIMAL(4,0)) were handled correctly. This patch fixes
the edge case and adds tests.

Change-Id: I830e895e8aeb0b75de636a3b8c23ed3092f7136b
Reviewed-on: http://gerrit.cloudera.org:8080/709
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Internal Jenkins
(cherry picked from commit 2e86e678ec4590765d1306fee776d7c2cfddcbdd)
---
M fe/src/main/java/com/cloudera/impala/catalog/ScalarType.java
M fe/src/test/java/com/cloudera/impala/analysis/AnalyzeExprsTest.java
M fe/src/test/java/com/cloudera/impala/analysis/TypesUtilTest.java
3 files changed, 71 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/44/2344/1
-- 
To view, visit http://gerrit.cloudera.org:8080/2344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I830e895e8aeb0b75de636a3b8c23ed3092f7136b
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.2.0_5.4.x
Gerrit-Owner: Anuj Phadke <ap...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>