You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by Sijie Guo <gu...@gmail.com> on 2012/06/18 08:09:15 UTC
Re: Review Request: BOOKKEEPER-203: improve ledger manager interface to
remove zookeeper dependency on metadata operations.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4603/
-----------------------------------------------------------
(Updated June 18, 2012, 6:09 a.m.)
Review request for bookkeeper.
Changes
-------
update new patch addressing Ivan's comments.
1) rebased to latest trunk
2) remove unused MetaStoreException and setClass in ReflectionUtils
3) improve LedgerManagerFactory#newLedgerManagerFactory for backward compatibility.
4) add uninitialize in LedgerManagerFactory to release resources used by ledger manager factory.
Description
-------
we need to improve ledger manager interface to remove zookeeper dependency on metadata operations, so it is easy for us to implement a MetaStore based ledger manager.
This addresses bug BOOKKEEPER-203.
https://issues.apache.org/jira/browse/BOOKKEEPER-203
Diffs (updated)
-----
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java eae08a3
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java 139e1c3
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java 3c4f339
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheImpl.java c0b8121
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BKException.java 484a055
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java fd879ed
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java 8423de9
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerCreateOp.java 8c5bce3
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerDeleteOp.java 5b10a5b
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java fd4ff03
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java c699eae
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerOpenOp.java 101ebf3
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java 2b5b21a
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java ce53461
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ActiveLedgerManager.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManager.java 1300974
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManagerFactory.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManager.java b573181
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManagerFactory.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerLayout.java cab02fe
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManager.java 7d9eb96
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManagerFactory.java 491a3e4
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ZkVersion.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/ReflectionUtils.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/versioning/Version.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/versioning/Versioned.java PRE-CREATION
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/LedgerCacheTest.java 3720bb8
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieRecoveryTest.java 8bd3f6b
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestFencing.java 1c109a2
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/GcLedgersTest.java 12c1b5a
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalAsyncLedgerOpsTest.java 24b3c12
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalBookieFailureTest.java 70a4ea9
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalBookieReadWriteTest.java 7d97fd4
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalBookieRecoveryTest.java d99156e
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalLedgerDeleteTest.java dbcd65a
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerLayoutTest.java 4784854
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerManagerTestCase.java b8a541b
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/TestLedgerManager.java e07c756
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/TestZkVersion.java PRE-CREATION
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/AsyncLedgerOpsTest.java d7f153a
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java a81067d
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieFailureTest.java e647d68
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieReadWriteTest.java 384cc3b
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/LedgerDeleteTest.java 2d3593e
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/MultiLedgerManagerBaseTestCase.java PRE-CREATION
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/MultiLedgerManagerTestCase.java PRE-CREATION
Diff: https://reviews.apache.org/r/4603/diff/
Testing
-------
Thanks,
Sijie Guo
Re: Review Request: BOOKKEEPER-203: improve ledger manager interface to
remove zookeeper dependency on metadata operations.
Posted by Sijie Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4603/
-----------------------------------------------------------
(Updated June 18, 2012, 3:52 p.m.)
Review request for bookkeeper.
Changes
-------
rebase the patch to latest trunk
Description
-------
we need to improve ledger manager interface to remove zookeeper dependency on metadata operations, so it is easy for us to implement a MetaStore based ledger manager.
This addresses bug BOOKKEEPER-203.
https://issues.apache.org/jira/browse/BOOKKEEPER-203
Diffs (updated)
-----
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java eae08a3
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java f8fab4e
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java 7cb2479
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheImpl.java c0b8121
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BKException.java 484a055
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java fd879ed
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java 8423de9
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerCreateOp.java 8c5bce3
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerDeleteOp.java 5b10a5b
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java fd4ff03
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java c699eae
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerOpenOp.java 101ebf3
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java e59d379
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java ce53461
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ActiveLedgerManager.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManager.java 1300974
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManagerFactory.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManager.java b573181
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManagerFactory.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerLayout.java cab02fe
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManager.java 7d9eb96
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManagerFactory.java 491a3e4
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ZkVersion.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/ReflectionUtils.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/versioning/Version.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/versioning/Versioned.java PRE-CREATION
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/LedgerCacheTest.java 3720bb8
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieRecoveryTest.java 8bd3f6b
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestFencing.java 1c109a2
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/GcLedgersTest.java 12c1b5a
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalAsyncLedgerOpsTest.java 24b3c12
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalBookieFailureTest.java 70a4ea9
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalBookieReadWriteTest.java 7d97fd4
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalBookieRecoveryTest.java d99156e
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalLedgerDeleteTest.java dbcd65a
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerLayoutTest.java 4784854
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerManagerTestCase.java b8a541b
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/TestLedgerManager.java e07c756
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/TestZkVersion.java PRE-CREATION
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/AsyncLedgerOpsTest.java d7f153a
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java a81067d
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieFailureTest.java e647d68
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieReadWriteTest.java 384cc3b
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/LedgerDeleteTest.java 2d3593e
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/MultiLedgerManagerMultiDigestTestCase.java PRE-CREATION
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/MultiLedgerManagerTestCase.java PRE-CREATION
Diff: https://reviews.apache.org/r/4603/diff/
Testing
-------
Thanks,
Sijie Guo
Re: Review Request: BOOKKEEPER-203: improve ledger manager interface to
remove zookeeper dependency on metadata operations.
Posted by Sijie Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4603/
-----------------------------------------------------------
(Updated June 18, 2012, 1:36 p.m.)
Review request for bookkeeper.
Changes
-------
attach a new patch renaming MultiLedgerManagerBaseTestCase to MultiLedgerManagerMultiDigestTestCase
Description
-------
we need to improve ledger manager interface to remove zookeeper dependency on metadata operations, so it is easy for us to implement a MetaStore based ledger manager.
This addresses bug BOOKKEEPER-203.
https://issues.apache.org/jira/browse/BOOKKEEPER-203
Diffs (updated)
-----
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java eae08a3
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java 139e1c3
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java 3c4f339
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheImpl.java c0b8121
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BKException.java 484a055
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java fd879ed
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java 8423de9
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerCreateOp.java 8c5bce3
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerDeleteOp.java 5b10a5b
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java fd4ff03
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java c699eae
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerOpenOp.java 101ebf3
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java 2b5b21a
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java ce53461
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ActiveLedgerManager.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManager.java 1300974
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManagerFactory.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManager.java b573181
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManagerFactory.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerLayout.java cab02fe
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManager.java 7d9eb96
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManagerFactory.java 491a3e4
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ZkVersion.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/ReflectionUtils.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/versioning/Version.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/versioning/Versioned.java PRE-CREATION
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/LedgerCacheTest.java 3720bb8
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieRecoveryTest.java 8bd3f6b
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestFencing.java 1c109a2
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/GcLedgersTest.java 12c1b5a
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalAsyncLedgerOpsTest.java 24b3c12
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalBookieFailureTest.java 70a4ea9
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalBookieReadWriteTest.java 7d97fd4
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalBookieRecoveryTest.java d99156e
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalLedgerDeleteTest.java dbcd65a
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerLayoutTest.java 4784854
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerManagerTestCase.java b8a541b
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/TestLedgerManager.java e07c756
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/TestZkVersion.java PRE-CREATION
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/AsyncLedgerOpsTest.java d7f153a
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java a81067d
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieFailureTest.java e647d68
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieReadWriteTest.java 384cc3b
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/LedgerDeleteTest.java 2d3593e
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/MultiLedgerManagerMultiDigestTestCase.java PRE-CREATION
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/MultiLedgerManagerTestCase.java PRE-CREATION
Diff: https://reviews.apache.org/r/4603/diff/
Testing
-------
Thanks,
Sijie Guo