You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "bneradt (via GitHub)" <gi...@apache.org> on 2026/01/20 22:38:37 UTC
[PR] Count proxy.process.http.incoming_requests at transaction start [trafficserver]
bneradt opened a new pull request, #12823:
URL: https://github.com/apache/trafficserver/pull/12823
The proxy.process.http.incoming_requests metric was only incremented in HttpTransact::HandleRequest(), which is called late in the request processing pipeline. Requests that received error or redirect responses before reaching HandleRequest were never counted, causing significant underreporting during high-error-rate scenarios.
This fix moves the increment to HttpSM::attach_client_session(), which is called at the start of every transaction. This ensures all requests are counted, including those that fail header parsing, receive remap redirects, or hit early error conditions. This aligns with the documented behavior that incoming_requests should include errors and redirects (see doc/appendices/command-line/traffic_top.en.rst):
"Total number of client requests serviced by Traffic Server. This
includes both successful content-bearing responses as well as
errors, redirects, and not-modified IMS responses."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Count proxy.process.http.incoming_requests at transaction start [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt merged PR #12823:
URL: https://github.com/apache/trafficserver/pull/12823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Count proxy.process.http.incoming_requests at transaction start [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #12823:
URL: https://github.com/apache/trafficserver/pull/12823#issuecomment-3787335662
> The new location looks better, but I'm wondering if this is the earliest possible point to increment the metric. I think H2 requests that have decoding errors (e.g. unrecognized pseudo headers, compression errors, etc) are still not counted.
You're right that H2 HPACK decode errors occur before new_transaction() and won't be counted. This fix addresses HTTP-level early failures (remap redirects, header parse errors, early error responses) which was the primary concern — these are now counted correctly.
H2/H3 frame-level decode failures are a different category. Counting those would require incrementing in the frame processing code before decode, which is more involved.
I suggest doing this simple move change which relatively easily makes the current counting more accurate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Count proxy.process.http.incoming_requests at transaction start [trafficserver]
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on PR #12823:
URL: https://github.com/apache/trafficserver/pull/12823#issuecomment-3775431713
The new location looks better, but I'm wondering if this is the earliest possible point to increment the metric. I think H2 requests that have decoding errors (e.g. unrecognized pseudo headers, compression errors, etc) are still not counted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org