You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/05 13:30:00 UTC

[GitHub] [kafka] rajinisivaram commented on pull request #10267: KAFKA-12427: Don't update connection idle time for muted connections

rajinisivaram commented on pull request #10267:
URL: https://github.com/apache/kafka/pull/10267#issuecomment-791420001


   @splett2 Thanks for the PR. I think it would be better to store channels in `keysWithBufferedReads` only when the channel is not explicitly muted since we care about this state only when we are ready to read from the channel. So we could check if channel is explicitly muted when adding to `keysWithBufferedReads` and add the key to `keysWithBufferedReads` when unmuting. This would avoid processing the channel unnecessarily.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org