You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@twill.apache.org by ch...@apache.org on 2015/09/23 09:52:20 UTC

[3/5] incubator-twill git commit: WIP2

WIP2

Project: http://git-wip-us.apache.org/repos/asf/incubator-twill/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-twill/commit/d9d71228
Tree: http://git-wip-us.apache.org/repos/asf/incubator-twill/tree/d9d71228
Diff: http://git-wip-us.apache.org/repos/asf/incubator-twill/diff/d9d71228

Branch: refs/heads/feature/TWILL-153
Commit: d9d712287c004f0e61f80cec9c1dd1203af34534
Parents: efc1bee
Author: Terence Yim <ch...@apache.org>
Authored: Tue Sep 22 22:37:05 2015 -0700
Committer: Terence Yim <ch...@apache.org>
Committed: Tue Sep 22 22:37:05 2015 -0700

----------------------------------------------------------------------
 .../internal/zookeeper/RewatchOnExpireWatcher.java      | 12 ++++++------
 twill-zookeeper/src/test/resources/logback-test.xml     |  2 +-
 2 files changed, 7 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-twill/blob/d9d71228/twill-zookeeper/src/main/java/org/apache/twill/internal/zookeeper/RewatchOnExpireWatcher.java
----------------------------------------------------------------------
diff --git a/twill-zookeeper/src/main/java/org/apache/twill/internal/zookeeper/RewatchOnExpireWatcher.java b/twill-zookeeper/src/main/java/org/apache/twill/internal/zookeeper/RewatchOnExpireWatcher.java
index 712a2f6..c24954b 100644
--- a/twill-zookeeper/src/main/java/org/apache/twill/internal/zookeeper/RewatchOnExpireWatcher.java
+++ b/twill-zookeeper/src/main/java/org/apache/twill/internal/zookeeper/RewatchOnExpireWatcher.java
@@ -78,7 +78,7 @@ final class RewatchOnExpireWatcher implements Watcher {
     if (event.getState() != Event.KeeperState.Expired) {
       return;
     }
-    LOG.debug("ZK session expired: {} {}", client.getConnectString(), event);
+    LOG.info("ZK session expired: {} {}", client.getConnectString(), event);
 
     switch (actionType) {
       case EXISTS:
@@ -97,7 +97,7 @@ final class RewatchOnExpireWatcher implements Watcher {
     Futures.addCallback(client.exists(path, this), new FutureCallback<Stat>() {
       @Override
       public void onSuccess(Stat stat) {
-        LOG.debug("Rewatch on exists succeeded: {}", path);
+        LOG.info("Rewatch on exists succeeded: {}", path);
         // Since we know all callbacks and watcher are triggered from single event thread, there is no race condition.
         Object oldResult = lastResult.getReference();
         lastResult.compareAndSet(oldResult, null, true, false);
@@ -105,15 +105,15 @@ final class RewatchOnExpireWatcher implements Watcher {
         if (stat != oldResult && (stat == null || !stat.equals(oldResult))) {
           if (stat == null) {
             // previous stat is not null, means node deleted
-            LOG.debug("Node deleted before rewatch on exists {}", path);
+            LOG.info("Node deleted before rewatch on exists {}", path);
             process(new WatchedEvent(Event.EventType.NodeDeleted, Event.KeeperState.SyncConnected, path));
           } else if (oldResult == null) {
             // previous stat is null, means node created
-            LOG.debug("Node created before rewatch on exists {}", path);
+            LOG.info("Node created before rewatch on exists {}", path);
             process(new WatchedEvent(Event.EventType.NodeCreated, Event.KeeperState.SyncConnected, path));
           } else {
             // Otherwise, something changed on the node
-            LOG.debug("Node event before rewatch on exists {}", path);
+            LOG.info("Node event before rewatch on exists {}", path);
             process(new WatchedEvent(Event.EventType.NodeDataChanged, Event.KeeperState.SyncConnected, path));
           }
         }
@@ -121,7 +121,7 @@ final class RewatchOnExpireWatcher implements Watcher {
 
       @Override
       public void onFailure(Throwable t) {
-        LOG.debug("Rewatch on exists failed");
+        LOG.info("Rewatch on exists failed");
         if (RetryUtils.canRetry(t)) {
           exists();
         } else {

http://git-wip-us.apache.org/repos/asf/incubator-twill/blob/d9d71228/twill-zookeeper/src/test/resources/logback-test.xml
----------------------------------------------------------------------
diff --git a/twill-zookeeper/src/test/resources/logback-test.xml b/twill-zookeeper/src/test/resources/logback-test.xml
index 227abce..90350cb 100644
--- a/twill-zookeeper/src/test/resources/logback-test.xml
+++ b/twill-zookeeper/src/test/resources/logback-test.xml
@@ -27,7 +27,7 @@ limitations under the License.
     <logger name="org.apache.hadoop" level="WARN" />
     <logger name="org.apache.zookeeper" level="WARN" />
 
-    <root level="DEBUG">
+    <root level="INFO">
         <appender-ref ref="STDOUT"/>
     </root>
 </configuration>