[GitHub] [superset] eschutho commented on a change in pull request #19482: feat: add success toast to alerts and reports

[GitBox <gi...@apache.org>]

eschutho commented on a change in pull request #19482:
URL: https://github.com/apache/superset/pull/19482#discussion_r840831605



##########
File path: superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx
##########
@@ -555,6 +557,9 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
             return;
           }
 
+          if (data.type === 'Alert') addSuccessToast(t('Alert updated'));
+          else addSuccessToast('Report updated');

Review comment:
       you may want to translate this one, too. 
   Also, I think you can simplify this by using the data.type in the toast... something like: 
   ```
   addSuccessToast(t(`${data.type} updated`));
   ```
   Assuming that the data.type for reports is "Report"?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org