You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Mengwei Ding <me...@gmail.com> on 2013/07/03 15:19:07 UTC

Review Request 12248: SQOOP-994 Sqoop2: upgrade: add calling validation to the upgrade method.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12248/
-----------------------------------------------------------

Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.


Bugs: SQOOP-994
    https://issues.apache.org/jira/browse/SQOOP-994


Repository: sqoop-sqoop2


Description
-------

commit 5772ec00d04595174ad2018dbb3f6af74fd82cba
Author: Mengwei Ding <me...@cloudera.com>
Date:   Tue Jul 2 18:48:29 2013 -0700

    SQOOP-994 Sqoop2: upgrade: add calling validation to the upgrade method.

:100644 100644 46cb7e6... 0bedcbb... M	core/src/main/java/org/apache/sqoop/repository/Repository.java
:100644 100644 c616889... 3f3a9e6... M	core/src/main/java/org/apache/sqoop/repository/RepositoryError.java


Diffs
-----

  core/src/main/java/org/apache/sqoop/repository/Repository.java 46cb7e6 
  core/src/main/java/org/apache/sqoop/repository/RepositoryError.java c616889 

Diff: https://reviews.apache.org/r/12248/diff/


Testing
-------

This implementation is just from my preliminary idea about this jira. I didn't do any test, cause there is a separate jira aiming to do the test for the whole metadata upgrading. And I will do the test in that jira.


Thanks,

Mengwei Ding


Re: Review Request 12248: SQOOP-994 Sqoop2: upgrade: add calling validation to the upgrade method.

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12248/#review22744
-----------------------------------------------------------

Ship it!


Ship It!

- Jarek Cecho


On July 3, 2013, 1:19 p.m., Mengwei Ding wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12248/
> -----------------------------------------------------------
> 
> (Updated July 3, 2013, 1:19 p.m.)
> 
> 
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
> 
> 
> Bugs: SQOOP-994
>     https://issues.apache.org/jira/browse/SQOOP-994
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> commit 5772ec00d04595174ad2018dbb3f6af74fd82cba
> Author: Mengwei Ding <me...@cloudera.com>
> Date:   Tue Jul 2 18:48:29 2013 -0700
> 
>     SQOOP-994 Sqoop2: upgrade: add calling validation to the upgrade method.
> 
> :100644 100644 46cb7e6... 0bedcbb... M	core/src/main/java/org/apache/sqoop/repository/Repository.java
> :100644 100644 c616889... 3f3a9e6... M	core/src/main/java/org/apache/sqoop/repository/RepositoryError.java
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 46cb7e6 
>   core/src/main/java/org/apache/sqoop/repository/RepositoryError.java c616889 
> 
> Diff: https://reviews.apache.org/r/12248/diff/
> 
> 
> Testing
> -------
> 
> This implementation is just from my preliminary idea about this jira. I didn't do any test, cause there is a separate jira aiming to do the test for the whole metadata upgrading. And I will do the test in that jira.
> 
> 
> Thanks,
> 
> Mengwei Ding
> 
>