[jira] [Commented] (BEAM-11024) Visit composite transform nodes in Pipeline._check_replacement()

["Beam JIRA Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-11024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17227518#comment-17227518 ] 

Beam JIRA Bot commented on BEAM-11024:
--------------------------------------

This issue is assigned but has not received an update in 30 days so it has been labeled "stale-assigned". If you are still working on the issue, please give an update and remove the label. If you are no longer working on the issue, please unassign so someone else may work on it. In 7 days the issue will be automatically unassigned.

> Visit composite transform nodes in Pipeline._check_replacement()
> ----------------------------------------------------------------
>
>                 Key: BEAM-11024
>                 URL: https://issues.apache.org/jira/browse/BEAM-11024
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>            Reporter: Yifan Mai
>            Assignee: Yifan Mai
>            Priority: P2
>              Labels: stale-assigned
>
> Pipeline.replace_all() calls _replace(), which replaces transform nodes using a PipelineVisitor, and then _check_replacement(), which validates that there are no replaceable transform nodes using a PipelineVisitor i.e. it checks that PTransformOverride.matches() does not return True on any nodes.
> Currently, _replace() visits [both composite and leaf transform nodes|https://github.com/apache/beam/blob/b7ae7bb1dc28a7c8f26e9f48682e781a74e2d3c4/sdks/python/apache_beam/pipeline.py#L376-L382] whereas _check_replacement() visits [only leaf transform nodes|https://github.com/apache/beam/blob/b7ae7bb1dc28a7c8f26e9f48682e781a74e2d3c4/sdks/python/apache_beam/pipeline.py#L463-L468]. _check_replacement() should visit composite transform nodes as well for symmetry.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)