[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #3352: ARTEMIS-2990 - alway be getBiased and only publish complete records a…

[GitBox <gi...@apache.org>]

michaelandrepearce commented on a change in pull request #3352:
URL: https://github.com/apache/activemq-artemis/pull/3352#discussion_r527749708



##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/AddressImpl.java
##########
@@ -84,6 +84,7 @@ public void addLinkedAddress(final Address address) {
       if (linkedAddresses == null) {
          linkedAddresses = PlatformDependent.hasUnsafe() ? new NonBlockingHashSet<>() : new ConcurrentHashSet<>();
       }
+      assert !linkedAddresses.contains(address);

Review comment:
       Previously if it called twice it wont error but simply proceed. Is this really a good idea, risk breaking or erroring




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org