You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by GitBox <gi...@apache.org> on 2021/06/07 19:40:07 UTC

[GitHub] [directory-server] TimoScheuer opened a new pull request #50: bugfix: KerberosTime throws ParseException if times with fractions ar…

TimoScheuer opened a new pull request #50:
URL: https://github.com/apache/directory-server/pull/50


   …e found in directory
   
   The class "org.apache.directory.shared.kerberos.KerberosTime" states that the time used never uses fractions. The implementation follows this assumption but the assumption is not right. Kerberos uses generalized time (RFC 4517) which can use fractions.
   
   The consequence of the wrong assumption is that a ParseException is thrown if I use for example the Kerberos implementation kerby to generate principals which can have fractions.
   
   In my changes I used the generalized time implementation that is already available in the LDAP client implementation: "org.apache.directory.api.util.GeneralizedTime". I tried to change as few as possible. Therefore I dropped the fractions in internal handling as the old class did but I made it possible that the class now is able to parse Kerberos time that has been written by other tools which can use fractions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org


[GitHub] [directory-server] coheigea closed pull request #50: bugfix: KerberosTime throws ParseException if times with fractions ar…

Posted by GitBox <gi...@apache.org>.
coheigea closed pull request #50:
URL: https://github.com/apache/directory-server/pull/50


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org


[GitHub] [directory-server] coheigea commented on pull request #50: bugfix: KerberosTime throws ParseException if times with fractions ar…

Posted by GitBox <gi...@apache.org>.
coheigea commented on pull request #50:
URL: https://github.com/apache/directory-server/pull/50#issuecomment-968781206


   Fix merged by @elecharny 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org