You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by "jdaugherty (via GitHub)" <gi...@apache.org> on 2026/04/07 20:09:31 UTC
[PR] Do not fail mergeTestReports for partial previous test task runs [grails-core]
jdaugherty opened a new pull request, #15563:
URL: https://github.com/apache/grails-core/pull/15563
If a user:
1. runs integrationTest - and it's terminated (OOM, etc) before finish
2. then runs smokeTest
The mergeTestReports will fail b/c it's partially run, an error like this will show:
Caused by: java.lang.IllegalStateException: Test outputs data file '$PROJECT_DIR/build/test-results/gebTest/binary/output.bin' exists but the index file '$PROJECT_DIR/build/test-results/gebTest/binary/output.bin.idx' does not
at org.gradle.api.internal.tasks.testing.junit.result.TestOutputStore$Reader.<init>(TestOutputStore.java:231)
at org.gradle.api.internal.tasks.testing.junit.result.TestOutputStore.reader(TestOutputStore.java:391)
at org.gradle.api.internal.tasks.testing.junit.result.TestOutputStoreBackedResultsProvider.<init>(TestOutputStoreBackedResultsProvider.java:28)
at org.gradle.api.internal.tasks.testing.junit.result.BinaryResultBackedTestResultsProvider.<init>(BinaryResultBackedTestResultsProvider.java:27)
at org.gradle.util.internal.CollectionUtils.collect(CollectionUtils.java:192)
at org.gradle.api.internal.tasks.testing.LegacyTestReportGenerator.lambda$createAggregateProvider$1(LegacyTestReportGenerator.java:54)
at org.gradle.api.internal.tasks.testing.LegacyTestReportGenerator.hasResults(LegacyTestReportGenerator.java:71)
at org.gradle.api.tasks.testing.TestReport.generateReport(TestReport.java:186)
... 125 more
This is because the index file isn't generated until after the task finishes. This PR simply removes these invalid states so the test report task doesn't fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Do not fail mergeTestReports for partial previous test task runs [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on code in PR #15563:
URL: https://github.com/apache/grails-core/pull/15563#discussion_r3052423260
##########
grails-test-examples/test-phases/grails-app/controllers/testphases/UrlMappings.groovy:
##########
@@ -25,10 +25,6 @@ class UrlMappings {
constraints {
}
}
-
Review Comment:
FYI: This may be a regression with 7.1. There was a swallowed exception because these views didn't exist in this project. It may be related to Scott's wildcard mapping change. Although, I think it doesn't have a real impact so it's probably ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Do not fail mergeTestReports for partial previous test task runs [grails-core]
Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #15563:
URL: https://github.com/apache/grails-core/pull/15563#issuecomment-4207300505
## ✅ All tests passed ✅
🏷️ Commit: 46e57a1ac60cfbadd376f1065ce8400e92d3b03c
▶️ Tests: 19681 executed
⚪️ Checks: 35/35 completed
---
_Learn more about TestLens at [testlens.app](https://testlens.app)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Do not fail mergeTestReports for partial previous test task runs [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty merged PR #15563:
URL: https://github.com/apache/grails-core/pull/15563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Do not fail mergeTestReports for partial previous test task runs [grails-core]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #15563:
URL: https://github.com/apache/grails-core/pull/15563#issuecomment-4207440684
<!-- Bito Reply -->
The change removes URL mappings to views ('/index', '/error', '/notFound') that don't exist in the project, which were causing swallowed exceptions in Grails 7.1, likely due to wildcard mapping updates. Removing them prevents errors without impact, as these are default fallbacks. This appears to be a valid fix for the regression.
**grails-test-examples/test-phases/grails-app/controllers/testphases/UrlMappings.groovy**
```
'/'(view: '/index')
'500'(view: '/error')
'404'(view: '/notFound')
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Do not fail mergeTestReports for partial previous test task runs [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on code in PR #15563:
URL: https://github.com/apache/grails-core/pull/15563#discussion_r3052423260
##########
grails-test-examples/test-phases/grails-app/controllers/testphases/UrlMappings.groovy:
##########
@@ -25,10 +25,6 @@ class UrlMappings {
constraints {
}
}
-
Review Comment:
FYI: This may be a regression with 7.1. There was a swallowed exception I noticed while working on this change because these views didn't exist in this project. It may be related to Scott's wildcard mapping change. Although, I think it doesn't have a real impact so it's probably ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org