[GitHub] [druid] zhenxiao commented on a change in pull request #9302: Not use for CoordinatorRuleManager.rules

[GitBox <gi...@apache.org>]

zhenxiao commented on a change in pull request #9302: Not use for CoordinatorRuleManager.rules
URL: https://github.com/apache/druid/pull/9302#discussion_r375527247
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/server/router/CoordinatorRuleManager.java
 ##########
 @@ -58,7 +57,7 @@
   private final ObjectMapper jsonMapper;
   private final Supplier<TieredBrokerConfig> config;
 
-  private final AtomicReference<ConcurrentHashMap<String, List<Rule>>> rules;
+  private final AtomicReference<Map<String, List<Rule>>> rules;
 
 Review comment:
   thanks for your comments @suneet-s @jihoonson 
   updated to unmodifiableMap
   I will file an issue to add tests after this PR is merged

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org