You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4net-dev@logging.apache.org by "Imrich Olha (JIRA)" <ji...@apache.org> on 2006/05/15 18:57:07 UTC

[jira] Created: (LOG4NET-77) A small imrovement of log4net.Layout.Pattern - added 'Option' propery support

A small imrovement of log4net.Layout.Pattern  - added 'Option' propery support
------------------------------------------------------------------------------

         Key: LOG4NET-77
         URL: http://issues.apache.org/jira/browse/LOG4NET-77
     Project: Log4net
        Type: Improvement

  Components: Other  
    Versions: 1.2.10    
    Reporter: Imrich Olha
    Priority: Minor


A small imrovement of log4net.Layout.Pattern  - added 'Option' propery support
Example of usage:
    <appender name="ConsoleAppender" type="log4net.Appender.ConsoleAppender" >
      <layout type="log4net.Layout.PatternLayout">
        <conversionPattern value="%exception{TargetSite} - %exception{Message}%newline" />
      </layout>
    </appender>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (LOG4NET-77) A small improvement of log4net.Layout.Pattern.ExceptionPatternConverter - added 'Option' propery support

Posted by "Ron Grabowski (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/LOG4NET-77?page=all ]

Ron Grabowski updated LOG4NET-77:
---------------------------------

    Attachment: ExceptionPatternConverter-WithOptionSupport.cs.patch

I think its ok to just support just the 5 public properties on the Exception object.

> A small improvement of log4net.Layout.Pattern.ExceptionPatternConverter  - added 'Option' propery support
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: LOG4NET-77
>                 URL: http://issues.apache.org/jira/browse/LOG4NET-77
>             Project: Log4net
>          Issue Type: Improvement
>    Affects Versions: 1.2.10
>            Reporter: Imrich Olha
>         Assigned To: Ron Grabowski
>            Priority: Minor
>         Attachments: ExceptionPatternConverter-WithOptionSupport.cs.patch, ExceptionPatternConverter.cs
>
>
> A small improvement of log4net.Layout.Pattern.ExceptionPatternConverter  - added 'Option' propery support
> Example of usage:
>     <appender name="ConsoleAppender" type="log4net.Appender.ConsoleAppender" >
>       <layout type="log4net.Layout.PatternLayout">
>         <conversionPattern value="%exception{TargetSite} - %exception{Message}%newline" />
>       </layout>
>     </appender>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (LOG4NET-77) A small improvement of log4net.Layout.Pattern.ExceptionPatternConverter - added 'Option' propery support

Posted by "Ron Grabowski (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/LOG4NET-77?page=all ]

Ron Grabowski resolved LOG4NET-77.
----------------------------------

    Resolution: Fixed

Fixed in 426832. 

> A small improvement of log4net.Layout.Pattern.ExceptionPatternConverter  - added 'Option' propery support
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: LOG4NET-77
>                 URL: http://issues.apache.org/jira/browse/LOG4NET-77
>             Project: Log4net
>          Issue Type: Improvement
>    Affects Versions: 1.2.10
>            Reporter: Imrich Olha
>         Assigned To: Ron Grabowski
>            Priority: Minor
>         Attachments: ExceptionPatternConverter-WithOptionSupport.cs.patch, ExceptionPatternConverter.cs
>
>
> A small improvement of log4net.Layout.Pattern.ExceptionPatternConverter  - added 'Option' propery support
> Example of usage:
>     <appender name="ConsoleAppender" type="log4net.Appender.ConsoleAppender" >
>       <layout type="log4net.Layout.PatternLayout">
>         <conversionPattern value="%exception{TargetSite} - %exception{Message}%newline" />
>       </layout>
>     </appender>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (LOG4NET-77) A small improvement of log4net.Layout.Pattern.ExceptionPatternConverter - added 'Option' propery support

Posted by "Nicko Cadell (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/LOG4NET-77?page=comments#action_12424305 ] 
            
Nicko Cadell commented on LOG4NET-77:
-------------------------------------

For consistency i would go for SystemInfo.NullText

> A small improvement of log4net.Layout.Pattern.ExceptionPatternConverter  - added 'Option' propery support
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: LOG4NET-77
>                 URL: http://issues.apache.org/jira/browse/LOG4NET-77
>             Project: Log4net
>          Issue Type: Improvement
>    Affects Versions: 1.2.10
>            Reporter: Imrich Olha
>         Assigned To: Ron Grabowski
>            Priority: Minor
>         Attachments: ExceptionPatternConverter-WithOptionSupport.cs.patch, ExceptionPatternConverter.cs
>
>
> A small improvement of log4net.Layout.Pattern.ExceptionPatternConverter  - added 'Option' propery support
> Example of usage:
>     <appender name="ConsoleAppender" type="log4net.Appender.ConsoleAppender" >
>       <layout type="log4net.Layout.PatternLayout">
>         <conversionPattern value="%exception{TargetSite} - %exception{Message}%newline" />
>       </layout>
>     </appender>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (LOG4NET-77) A small imrovement of log4net.Layout.Pattern - added 'Option' propery support

Posted by "Imrich Olha (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/LOG4NET-77?page=all ]

Imrich Olha updated LOG4NET-77:
-------------------------------

    Attachment: ExceptionPatternConverter.cs

> A small imrovement of log4net.Layout.Pattern  - added 'Option' propery support
> ------------------------------------------------------------------------------
>
>          Key: LOG4NET-77
>          URL: http://issues.apache.org/jira/browse/LOG4NET-77
>      Project: Log4net
>         Type: Improvement

>   Components: Other
>     Versions: 1.2.10
>     Reporter: Imrich Olha
>     Priority: Minor
>  Attachments: ExceptionPatternConverter.cs
>
> A small imrovement of log4net.Layout.Pattern  - added 'Option' propery support
> Example of usage:
>     <appender name="ConsoleAppender" type="log4net.Appender.ConsoleAppender" >
>       <layout type="log4net.Layout.PatternLayout">
>         <conversionPattern value="%exception{TargetSite} - %exception{Message}%newline" />
>       </layout>
>     </appender>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (LOG4NET-77) A small improvement of log4net.Layout.Pattern.ExceptionPatternConverter - added 'Option' propery support

Posted by "Ron Grabowski (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/LOG4NET-77?page=all ]

Ron Grabowski reassigned LOG4NET-77:
------------------------------------

    Assign To: Ron Grabowski

> A small improvement of log4net.Layout.Pattern.ExceptionPatternConverter  - added 'Option' propery support
> ---------------------------------------------------------------------------------------------------------
>
>          Key: LOG4NET-77
>          URL: http://issues.apache.org/jira/browse/LOG4NET-77
>      Project: Log4net
>         Type: Improvement

>     Versions: 1.2.10
>     Reporter: Imrich Olha
>     Assignee: Ron Grabowski
>     Priority: Minor
>  Attachments: ExceptionPatternConverter.cs
>
> A small improvement of log4net.Layout.Pattern.ExceptionPatternConverter  - added 'Option' propery support
> Example of usage:
>     <appender name="ConsoleAppender" type="log4net.Appender.ConsoleAppender" >
>       <layout type="log4net.Layout.PatternLayout">
>         <conversionPattern value="%exception{TargetSite} - %exception{Message}%newline" />
>       </layout>
>     </appender>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (LOG4NET-77) A small improvement of log4net.Layout.Pattern.ExceptionPatternConverter - added 'Option' propery support

Posted by "Ron Grabowski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LOG4NET-77?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ron Grabowski updated LOG4NET-77:
---------------------------------

    Fix Version/s: 1.2.11

> A small improvement of log4net.Layout.Pattern.ExceptionPatternConverter  - added 'Option' propery support
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: LOG4NET-77
>                 URL: https://issues.apache.org/jira/browse/LOG4NET-77
>             Project: Log4net
>          Issue Type: Improvement
>    Affects Versions: 1.2.10
>            Reporter: Imrich Olha
>            Assignee: Ron Grabowski
>            Priority: Minor
>             Fix For: 1.2.11
>
>         Attachments: ExceptionPatternConverter-WithOptionSupport.cs.patch, ExceptionPatternConverter.cs
>
>
> A small improvement of log4net.Layout.Pattern.ExceptionPatternConverter  - added 'Option' propery support
> Example of usage:
>     <appender name="ConsoleAppender" type="log4net.Appender.ConsoleAppender" >
>       <layout type="log4net.Layout.PatternLayout">
>         <conversionPattern value="%exception{TargetSite} - %exception{Message}%newline" />
>       </layout>
>     </appender>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (LOG4NET-77) A small improvement of log4net.Layout.Pattern.ExceptionPatternConverter - added 'Option' propery support

Posted by "Imrich Olha (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/LOG4NET-77?page=all ]

Imrich Olha updated LOG4NET-77:
-------------------------------

      Component:     (was: Other)
        Summary: A small improvement of log4net.Layout.Pattern.ExceptionPatternConverter  - added 'Option' propery support  (was: A small imrovement of log4net.Layout.Pattern  - added 'Option' propery support)
    Description: 
A small improvement of log4net.Layout.Pattern.ExceptionPatternConverter  - added 'Option' propery support
Example of usage:
    <appender name="ConsoleAppender" type="log4net.Appender.ConsoleAppender" >
      <layout type="log4net.Layout.PatternLayout">
        <conversionPattern value="%exception{TargetSite} - %exception{Message}%newline" />
      </layout>
    </appender>


  was:
A small imrovement of log4net.Layout.Pattern  - added 'Option' propery support
Example of usage:
    <appender name="ConsoleAppender" type="log4net.Appender.ConsoleAppender" >
      <layout type="log4net.Layout.PatternLayout">
        <conversionPattern value="%exception{TargetSite} - %exception{Message}%newline" />
      </layout>
    </appender>



> A small improvement of log4net.Layout.Pattern.ExceptionPatternConverter  - added 'Option' propery support
> ---------------------------------------------------------------------------------------------------------
>
>          Key: LOG4NET-77
>          URL: http://issues.apache.org/jira/browse/LOG4NET-77
>      Project: Log4net
>         Type: Improvement

>     Versions: 1.2.10
>     Reporter: Imrich Olha
>     Priority: Minor
>  Attachments: ExceptionPatternConverter.cs
>
> A small improvement of log4net.Layout.Pattern.ExceptionPatternConverter  - added 'Option' propery support
> Example of usage:
>     <appender name="ConsoleAppender" type="log4net.Appender.ConsoleAppender" >
>       <layout type="log4net.Layout.PatternLayout">
>         <conversionPattern value="%exception{TargetSite} - %exception{Message}%newline" />
>       </layout>
>     </appender>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (LOG4NET-77) A small improvement of log4net.Layout.Pattern.ExceptionPatternConverter - added 'Option' propery support

Posted by "Ron Grabowski (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/LOG4NET-77?page=comments#action_12424298 ] 
            
Ron Grabowski commented on LOG4NET-77:
--------------------------------------

Which one of the two Assert statements are correct? StackTrace is null.

[Test]
public void TestExceptionPattern()
{
	StringAppender stringAppender = new StringAppender();
	PatternLayout layout = new PatternLayout("%exception{stacktrace}");
	stringAppender.Layout = layout;

	ILoggerRepository rep = LogManager.CreateRepository(Guid.NewGuid().ToString());
	BasicConfigurator.Configure(rep, stringAppender);

	ILog log1 = LogManager.GetLogger(rep.Name, "TestExceptionPattern");

	Exception exception = new Exception("Oh no!");
	log1.Info("TestMessage", exception);

	/* From ExceptionPatternConverter.cs:
		If there is no exception then nothing will be output
		and no trailing newline will be appended.
		It is typical to put a newline before the exception
		and to have the exception as the last data in the pattern.
	*/

	// ???
	Assert.AreEqual(string.Empty, stringAppender.GetString());

	// ???
	Assert.AreEqual(SystemInfo.NullText, stringAppender.GetString());

	stringAppender.Reset();	
}

> A small improvement of log4net.Layout.Pattern.ExceptionPatternConverter  - added 'Option' propery support
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: LOG4NET-77
>                 URL: http://issues.apache.org/jira/browse/LOG4NET-77
>             Project: Log4net
>          Issue Type: Improvement
>    Affects Versions: 1.2.10
>            Reporter: Imrich Olha
>         Assigned To: Ron Grabowski
>            Priority: Minor
>         Attachments: ExceptionPatternConverter-WithOptionSupport.cs.patch, ExceptionPatternConverter.cs
>
>
> A small improvement of log4net.Layout.Pattern.ExceptionPatternConverter  - added 'Option' propery support
> Example of usage:
>     <appender name="ConsoleAppender" type="log4net.Appender.ConsoleAppender" >
>       <layout type="log4net.Layout.PatternLayout">
>         <conversionPattern value="%exception{TargetSite} - %exception{Message}%newline" />
>       </layout>
>     </appender>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira