You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Takanobu Asanuma (JIRA)" <ji...@apache.org> on 2015/03/02 01:30:05 UTC
[jira] [Commented] (HDFS-7439) Add BlockOpResponseProto's message
to DFSClient's exception message
[ https://issues.apache.org/jira/browse/HDFS-7439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342563#comment-14342563 ]
Takanobu Asanuma commented on HDFS-7439:
----------------------------------------
Thank you very much for the review. I corrected the patch and resubmitted.
> Add BlockOpResponseProto's message to DFSClient's exception message
> -------------------------------------------------------------------
>
> Key: HDFS-7439
> URL: https://issues.apache.org/jira/browse/HDFS-7439
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Ming Ma
> Assignee: Takanobu Asanuma
> Priority: Minor
> Attachments: HDFS-7439.1.patch, HDFS-7439.2.patch, HDFS-7439.3.patch
>
>
> When (BlockOpResponseProto#getStatus() != SUCCESS), it helps with debugging if DFSClient can add BlockOpResponseProto's message to the exception message applications will get. For example, instead of
> {noformat}
> throw new IOException("Got error for OP_READ_BLOCK, self="
> + peer.getLocalAddressString() + ", remote="
> + peer.getRemoteAddressString() + ", for file " + file
> + ", for pool " + block.getBlockPoolId() + " block "
> + block.getBlockId() + "_" + block.getGenerationStamp());
> {noformat}
> It could be,
> {noformat}
> throw new IOException("Got error for OP_READ_BLOCK, self="
> + peer.getLocalAddressString() + ", remote="
> + peer.getRemoteAddressString() + ", for file " + file
> + ", for pool " + block.getBlockPoolId() + " block "
> + block.getBlockId() + "_" + block.getGenerationStamp()
> + ", status message " + status.getMessage());
> {noformat}
> We might want to check out all the references to BlockOpResponseProto in DFSClient.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)