You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2018/05/04 06:55:34 UTC

[GitHub] candyleer opened a new pull request #1164: Fix Average Time zero and ClassCast Exception

candyleer opened a new pull request #1164: Fix Average Time zero and ClassCast Exception
URL: https://github.com/apache/incubator-skywalking/pull/1164
 
 
   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [x] Bug fix
   - [ ] New feature provided
   - [ ] Improve performance
   
   - Related issues
   
   ___
   ### Bug fix
   - Bug description.
   Fix `Slow Service` maybe zero ms.
   ![image](https://user-images.githubusercontent.com/11530760/39581737-d628cdd6-4f1e-11e8-8a10-60a6f39a2bc2.png)
   - How to fix?
   the cause is that we should invoke `calculateFormula()` method when first put `mergeDataCache `,because some attribute is calculated by other attribute which located in the `mergeDataCache `,such as `org.apache.skywalking.apm.collector.storage.table.service.ServiceReferenceMetric#getTransactionAverageDuration` ,so we should call this method.
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services