You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by be...@apache.org on 2021/07/19 18:48:19 UTC

[superset] branch master updated: feat: add show columns to Reports model (#15712)

This is an automated email from the ASF dual-hosted git repository.

beto pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 3a249a0  feat: add show columns to Reports model (#15712)
3a249a0 is described below

commit 3a249a00908e605cd3133af6fc7eafefb7fe093d
Author: AAfghahi <48...@users.noreply.github.com>
AuthorDate: Mon Jul 19 14:47:33 2021 -0400

    feat: add show columns to Reports model (#15712)
    
    * added logic for creation_method
    
    * revisions
    
    * added index
    
    * Update superset/migrations/versions/3317e9248280_add_creation_method_to_reports_model.py
    
    * filters
    
    * search columns updated
---
 superset/reports/api.py                      | 3 +++
 tests/integration_tests/reports/api_tests.py | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/superset/reports/api.py b/superset/reports/api.py
index ccbda74..03d72bc 100644
--- a/superset/reports/api.py
+++ b/superset/reports/api.py
@@ -182,6 +182,9 @@ class ReportScheduleRestApi(BaseSupersetModelRestApi):
         "created_by",
         "type",
         "last_state",
+        "creation_method",
+        "dashboard_id",
+        "chart_id",
     ]
     search_filters = {"name": [ReportScheduleAllTextFilter]}
     allowed_rel_fields = {"owners", "chart", "dashboard", "database", "created_by"}
diff --git a/tests/integration_tests/reports/api_tests.py b/tests/integration_tests/reports/api_tests.py
index 1fe7106..06888e9 100644
--- a/tests/integration_tests/reports/api_tests.py
+++ b/tests/integration_tests/reports/api_tests.py
@@ -773,7 +773,7 @@ class TestReportSchedulesApi(SupersetTestCase):
         data = json.loads(rv.data.decode("utf-8"))
         assert data == {"message": {"dashboard": "Dashboard does not exist"}}
 
-    @pytest.mark.usefixtures("load_birth_names_dashboard_with_slices")
+    # @pytest.mark.usefixtures("load_birth_names_dashboard_with_slices")
     # TODO (AAfghahi): I am going to enable this when the report schedule feature is fully finished
     # def test_create_report_schedule_no_creation_method(self):
     #     """