You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by da...@apache.org on 2024/09/05 16:29:33 UTC

(beam) 01/01: Undo part of artifact action upgrade to fix workflow

This is an automated email from the ASF dual-hosted git repository.

damccorm pushed a commit to branch users/damccorm/wheels_fix
in repository https://gitbox.apache.org/repos/asf/beam.git

commit f52a535ef334397aa1061fa6b30d1381272971d1
Author: Danny McCormick <da...@google.com>
AuthorDate: Thu Sep 5 09:29:12 2024 -0700

    Undo part of artifact action upgrade to fix workflow
---
 .github/workflows/build_wheels.yml | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/build_wheels.yml b/.github/workflows/build_wheels.yml
index 22223b718b0..f97f4de50ae 100644
--- a/.github/workflows/build_wheels.yml
+++ b/.github/workflows/build_wheels.yml
@@ -127,13 +127,11 @@ jobs:
         # https://github.com/pypa/setuptools/issues/4300 changed naming. Match both old and new names.
         run: mv $(ls | grep "apache-beam-\|apache_beam-") apache-beam-source
       - name: Upload source as artifact
-        # Pinned to v3 because of https://github.com/actions/download-artifact/issues/249
         uses: actions/upload-artifact@v4
         with:
           name: source
           path: sdks/python/apache-beam-source
       - name: Upload compressed sources as artifacts
-        # Pinned to v3 because of https://github.com/actions/download-artifact/issues/249
         uses: actions/upload-artifact@v4
         with:
           name: source_zip
@@ -172,14 +170,12 @@ jobs:
         run: mv $(ls | grep "apache-beam-\|apache_beam-") apache-beam-source-rc
       - name: Upload RC source as artifact
         if: steps.is_rc.outputs.is_rc == 1
-        # Pinned to v3 because of https://github.com/actions/download-artifact/issues/249
         uses: actions/upload-artifact@v4
         with:
           name: source_rc${{ steps.get_rc_version.outputs.RC_NUM }}
           path: sdks/python/apache-beam-source-rc
       - name: Upload compressed RC sources as artifacts
         if: steps.is_rc.outputs.is_rc == 1
-        # Pinned to v3 because of https://github.com/actions/download-artifact/issues/249
         uses: actions/upload-artifact@v4
         with:
           name: source_zip_rc${{ steps.get_rc_version.outputs.RC_NUM }}
@@ -283,8 +279,8 @@ jobs:
       shell: bash
     - name: Upload wheels as artifacts
       if: ${{ contains(matrix.os_python.python, matrix.py_version) }}
-      # Pinned to v3 because of https://github.com/actions/download-artifact/issues/249
-      uses: actions/upload-artifact@v4
+      # Pinned to v3 because of https://github.com/actions/upload-artifact?tab=readme-ov-file#breaking-changes
+      uses: actions/upload-artifact@v3
       with:
         name: wheelhouse-${{ matrix.os_python.os }}${{ (matrix.os_python.arch == 'aarch64' && '-aarch64') || '' }}
         path: apache-beam-source/wheelhouse/
@@ -333,8 +329,8 @@ jobs:
             arch: aarch64
     steps:
     - name: Download wheels from artifacts
-      # Pinned to v3 because of https://github.com/actions/download-artifact/issues/249
-      uses: actions/download-artifact@v4.1.8
+      # Pinned to v3 because of https://github.com/actions/upload-artifact?tab=readme-ov-file#breaking-changes
+      uses: actions/download-artifact@v3
       with:
         name: wheelhouse-${{ matrix.os }}${{ (matrix.arch == 'aarch64' && '-aarch64') || '' }}
         path: wheelhouse/