You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "dino2895 (via GitHub)" <gi...@apache.org> on 2026/08/01 05:01:12 UTC
[PR] KAFKA-20872: Integrate api-checker checks into CI [kafka]
dino2895 opened a new pull request, #23012:
URL: https://github.com/apache/kafka/pull/23012
## Summary
The `api-checker` module is a composite-included Gradle build, so its
independent tests and verification tasks are not executed by Kafka's
existing root `test` task.
This change:
- adds a dedicated `api-checker` CI job;
- runs the `core`, `gradle-plugins`, and `maven-plugin` `check` tasks;
- tests the module on Java 17 and Java 25;
- archives its test and verification reports;
- makes `CI checks completed` depend on the new job.
The dedicated job does not participate in Kafka's normal/new/flaky test
catalog because the included build does not use that test-selection
infrastructure.
JIRA: https://issues.apache.org/jira/browse/KAFKA-20872
## Testing
The following checks passed locally on both Java 17 and Java 25:
```bash
./gradlew --no-build-cache --rerun-tasks --continue --no-scan \
:api-checker:core:check \
:api-checker:gradle-plugins:check \
:api-checker:maven-plugin:check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20872: Integrate api-checker checks into CI [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #23012:
URL: https://github.com/apache/kafka/pull/23012#discussion_r3952955210
##########
.github/workflows/build.yml:
##########
@@ -176,6 +176,46 @@ jobs:
- name: Verify license file
run: python committer-tools/verify_license.py --skip-build
+ api-checker:
+ needs: [configure, validate]
+ if: ${{ ! needs.configure.outputs.is-draft }}
+ runs-on: ubuntu-latest
+ timeout-minutes: 30
+ name: API Checker Java 25
+
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v5
+ with:
+ persist-credentials: false
+ ref: ${{ needs.configure.outputs.sha }}
+
+ - name: Setup Gradle
+ uses: ./.github/actions/setup-gradle
+ with:
+ java-version: 25
+ gradle-cache-read-only: ${{ !inputs.is-trunk }}
+ gradle-cache-write-only: ${{ inputs.is-trunk }}
+ develocity-access-key: ${{ secrets.DEVELOCITY_ACCESS_KEY }}
+
+ - name: Run API checker checks
+ run: |
+ ./gradlew --no-build-cache --continue --no-scan \
Review Comment:
I don't get the point of --no-build-cache and --no-scan. Why do you use them while still passing the related keys?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20872: Integrate api-checker checks into CI [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23012:
URL: https://github.com/apache/kafka/pull/23012#issuecomment-5229595952
A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the `triage` label
should be removed to prevent this automation from happening again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20872: Integrate api-checker checks into CI [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #23012:
URL: https://github.com/apache/kafka/pull/23012#discussion_r3908007521
##########
.github/workflows/build.yml:
##########
@@ -176,6 +176,50 @@ jobs:
- name: Verify license file
run: python committer-tools/verify_license.py --skip-build
+ api-checker:
+ needs: [configure, validate]
+ if: ${{ ! needs.configure.outputs.is-draft }}
+ runs-on: ubuntu-latest
+ timeout-minutes: 30
+ strategy:
+ fail-fast: false
+ matrix:
+ java: [25, 17]
Review Comment:
Testing both JDKs seems wasteful for this plugin, since I think the difference between them is slight.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20872: Integrate api-checker checks into CI [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #23012:
URL: https://github.com/apache/kafka/pull/23012#issuecomment-5576336095
> tests the module on Java 17 and Java 25;
this statement is obsolete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org