[jira] [Comment Edited] (GUACAMOLE-139) guacd cannot transfer pictures as JPEG

["Frode Langelo (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GUACAMOLE-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15745483#comment-15745483 ] 

Frode Langelo edited comment on GUACAMOLE-139 at 12/13/16 3:57 PM:
-------------------------------------------------------------------

In the function __guac_common_surface_should_use_webp(), the first return is:
{code}
    /* Do not use WebP if not supported */
    if (!guac_client_supports_webp(surface->client))
        return 0;
{code}
This happens when WebP is not supported by the browser, and the return in __guac_common_surface_should_use_jpeg() should determine JPEG can be used:
{code}
    return framerate >= GUAC_COMMON_SURFACE_JPEG_FRAMERATE
        && rect_size > GUAC_SURFACE_JPEG_MIN_BITMAP_SIZE
        && __guac_common_surface_png_optimality(surface, rect) < 0;
{code}


was (Author: frode):
In the function __guac_common_surface_should_use_webp(), the first return is:
{code}
    /* Do not use WebP if not supported */
    if (!guac_client_supports_webp(surface->client))
        return 0;
{code}
This happens when WebP is not supported by the browser, and the second return should determine JPEG can be used:
{code}
    return framerate >= GUAC_COMMON_SURFACE_JPEG_FRAMERATE
        && rect_size > GUAC_SURFACE_JPEG_MIN_BITMAP_SIZE
        && __guac_common_surface_png_optimality(surface, rect) < 0;
{code}

> guacd cannot transfer pictures as JPEG
> --------------------------------------
>
>                 Key: GUACAMOLE-139
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-139
>             Project: Guacamole
>          Issue Type: Bug
>          Components: guacamole-server
>    Affects Versions: 0.9.9
>         Environment: Ubuntu 16.04 LTS
>            Reporter: wangxh
>
> When guacd judge which is better choice(jpeg webp png), JPEG will nerver available. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)