You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@roller.apache.org by "Glen Mazza (JIRA)" <ji...@apache.org> on 2012/07/14 06:40:36 UTC
[jira] [Created] (ROL-1947) Provide a blog entry-level description
field that can go into HTML header field
Glen Mazza created ROL-1947:
-------------------------------
Summary: Provide a blog entry-level description field that can go into HTML header field
Key: ROL-1947
URL: https://issues.apache.org/jira/browse/ROL-1947
Project: Roller
Issue Type: Improvement
Reporter: Glen Mazza
Assignee: Roller Unassigned
Hi, as discussed here:
http://mail-archives.apache.org/mod_mbox/roller-user/201207.mbox/%3C4FF1A023.5020504%40talend.com%3E
Provide an ability to store a description field for each blog entry, that the user may wish to employ (via template modifications) to place within the HTML header, like so:
<meta name="Description" content="$model.weblogEntry.description"/>
This information is utilized by search engines to varying degrees when they wish to describe the contents of the blog article on the search results page, and is functionality already available in Google Blogger.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ROL-1947) Provide a blog entry-level
description field that can go into HTML header field
Posted by "Glen Mazza (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ROL-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502890#comment-13502890 ]
Glen Mazza commented on ROL-1947:
---------------------------------
What do you mean by "vm"?
> Provide a blog entry-level description field that can go into HTML header field
> -------------------------------------------------------------------------------
>
> Key: ROL-1947
> URL: https://issues.apache.org/jira/browse/ROL-1947
> Project: Roller
> Issue Type: Improvement
> Reporter: Glen Mazza
> Assignee: Roller Unassigned
> Attachments: BloggerCurrent.png, ROL1947.patch, RollerProposed.png
>
>
> Hi, as discussed here:
> http://mail-archives.apache.org/mod_mbox/roller-user/201207.mbox/%3C4FF1A023.5020504%40talend.com%3E
> Provide an ability to store a description field for each blog entry, that the user may wish to employ (via template modifications) to place within the HTML header, like so:
> <meta name="Description" content="$model.weblogEntry.description"/>
> This information is utilized by search engines to varying degrees when they wish to describe the contents of the blog article on the search results page, and is functionality already available in Google Blogger.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ROL-1947) Provide a blog entry-level
description field that can go into HTML header field
Posted by "Harsh Gupta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ROL-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499628#comment-13499628 ]
Harsh Gupta commented on ROL-1947:
----------------------------------
WeblogEntryWrapper does not contains following method
public String getSearchDescription() {
return HTMLSanitizer.conditionallySanitize(this.pojo.getSearchDescription());
}
Without this method $model.weblogEntry.searchDescription will not work in vm
> Provide a blog entry-level description field that can go into HTML header field
> -------------------------------------------------------------------------------
>
> Key: ROL-1947
> URL: https://issues.apache.org/jira/browse/ROL-1947
> Project: Roller
> Issue Type: Improvement
> Reporter: Glen Mazza
> Assignee: Roller Unassigned
> Attachments: BloggerCurrent.png, ROL1947.patch, RollerProposed.png
>
>
> Hi, as discussed here:
> http://mail-archives.apache.org/mod_mbox/roller-user/201207.mbox/%3C4FF1A023.5020504%40talend.com%3E
> Provide an ability to store a description field for each blog entry, that the user may wish to employ (via template modifications) to place within the HTML header, like so:
> <meta name="Description" content="$model.weblogEntry.description"/>
> This information is utilized by search engines to varying degrees when they wish to describe the contents of the blog article on the search results page, and is functionality already available in Google Blogger.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (ROL-1947) Provide a blog entry-level description
field that can go into HTML header field
Posted by "Glen Mazza (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ROL-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Glen Mazza reopened ROL-1947:
-----------------------------
Level of effort: trivial
Sorry, just one minor thing left, the Template Guide needs updating to mention this new field. I can't easily supply a patch as it's in ODT format, but noted the section and suggested text in my October 14th comment:
"...Template Guide will also need an update with the WeblogEntry table (Section 6.10) having another row added to describe the new searchDescription field, something like:
$entry.searchDescription / String / Descriptive text that can be added to the weblog entry's HTML header for search engine optimization (SEO).
> Provide a blog entry-level description field that can go into HTML header field
> -------------------------------------------------------------------------------
>
> Key: ROL-1947
> URL: https://issues.apache.org/jira/browse/ROL-1947
> Project: Roller
> Issue Type: Improvement
> Reporter: Glen Mazza
> Assignee: Dave Johnson
> Attachments: BloggerCurrent.png, ROL1947.patch, RollerProposed.png
>
>
> Hi, as discussed here:
> http://mail-archives.apache.org/mod_mbox/roller-user/201207.mbox/%3C4FF1A023.5020504%40talend.com%3E
> Provide an ability to store a description field for each blog entry, that the user may wish to employ (via template modifications) to place within the HTML header, like so:
> <meta name="Description" content="$model.weblogEntry.description"/>
> This information is utilized by search engines to varying degrees when they wish to describe the contents of the blog article on the search results page, and is functionality already available in Google Blogger.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ROL-1947) Provide a blog entry-level description
field that can go into HTML header field
Posted by "Glen Mazza (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ROL-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Glen Mazza updated ROL-1947:
----------------------------
Attachment: ROL1947.patch
RollerProposed.png
BloggerCurrent.png
> Provide a blog entry-level description field that can go into HTML header field
> -------------------------------------------------------------------------------
>
> Key: ROL-1947
> URL: https://issues.apache.org/jira/browse/ROL-1947
> Project: Roller
> Issue Type: Improvement
> Reporter: Glen Mazza
> Assignee: Roller Unassigned
> Attachments: BloggerCurrent.png, ROL1947.patch, RollerProposed.png
>
>
> Hi, as discussed here:
> http://mail-archives.apache.org/mod_mbox/roller-user/201207.mbox/%3C4FF1A023.5020504%40talend.com%3E
> Provide an ability to store a description field for each blog entry, that the user may wish to employ (via template modifications) to place within the HTML header, like so:
> <meta name="Description" content="$model.weblogEntry.description"/>
> This information is utilized by search engines to varying degrees when they wish to describe the contents of the blog article on the search results page, and is functionality already available in Google Blogger.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ROL-1947) Provide a blog entry-level
description field that can go into HTML header field
Posted by "Dave Johnson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ROL-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503525#comment-13503525 ]
Dave Johnson commented on ROL-1947:
-----------------------------------
Harsh: I just added the missing accessor. Thanks for the comment.
http://svn.apache.org/viewvc/roller/trunk/weblogger-business/src/main/java/org/apache/roller/weblogger/pojos/wrapper/WeblogEntryWrapper.java?view=diff&r1=1413373&r2=1413374&pathrev=1413374
> Provide a blog entry-level description field that can go into HTML header field
> -------------------------------------------------------------------------------
>
> Key: ROL-1947
> URL: https://issues.apache.org/jira/browse/ROL-1947
> Project: Roller
> Issue Type: Improvement
> Reporter: Glen Mazza
> Assignee: Roller Unassigned
> Attachments: BloggerCurrent.png, ROL1947.patch, RollerProposed.png
>
>
> Hi, as discussed here:
> http://mail-archives.apache.org/mod_mbox/roller-user/201207.mbox/%3C4FF1A023.5020504%40talend.com%3E
> Provide an ability to store a description field for each blog entry, that the user may wish to employ (via template modifications) to place within the HTML header, like so:
> <meta name="Description" content="$model.weblogEntry.description"/>
> This information is utilized by search engines to varying degrees when they wish to describe the contents of the blog article on the search results page, and is functionality already available in Google Blogger.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ROL-1947) Provide a blog entry-level
description field that can go into HTML header field
Posted by "Glen Mazza (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ROL-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475851#comment-13475851 ]
Glen Mazza commented on ROL-1947:
---------------------------------
Hi, the attached patch provides a "Search Description" field for each blog entry (max length 255 chars), providing the same functionality offered by Google's Blogger (see attached PNGs for Blogger and what it would look like in Roller) and removing a potential show-stopper for those considering use of Apache Roller. By default, values placed here will not go into the blog entry header unless the template is modified, but this provides the advanced user the ability to do so if he or she wishes.
For users wanting this field to be placed in their header, the necessary template modification would be just the single line below:
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<title>$model.weblogEntry.title : $model.weblog.name</title>
--> <meta name="Description" content="$model.weblogEntry.searchDescription"> <--
#showAutodiscoveryLinks($model.weblog)
<link rel="stylesheet" type="text/css" media="all" href="$model.weblog.stylesheet">
</head>
All Roller tests still pass with this patch. Note i18n might be an issue, as I've added the text for this field only to the standard resources property file, not to the various other UI languages supported by Roller (I believe they default to English if a foreign equivalent is not provided.) Due to the database change this patch includes it can probably be added only to the future Apache Roller 5.1.
If this patch is applied the Template Guide will also need an update with the WeblogEntry table (Section 6.10) having another row added to describe the new searchDescription field, something like:
$entry.searchDescription / String / Descriptive text that can be added to the weblog entry's HTML header for search engine optimization (SEO).
> Provide a blog entry-level description field that can go into HTML header field
> -------------------------------------------------------------------------------
>
> Key: ROL-1947
> URL: https://issues.apache.org/jira/browse/ROL-1947
> Project: Roller
> Issue Type: Improvement
> Reporter: Glen Mazza
> Assignee: Roller Unassigned
>
> Hi, as discussed here:
> http://mail-archives.apache.org/mod_mbox/roller-user/201207.mbox/%3C4FF1A023.5020504%40talend.com%3E
> Provide an ability to store a description field for each blog entry, that the user may wish to employ (via template modifications) to place within the HTML header, like so:
> <meta name="Description" content="$model.weblogEntry.description"/>
> This information is utilized by search engines to varying degrees when they wish to describe the contents of the blog article on the search results page, and is functionality already available in Google Blogger.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ROL-1947) Provide a blog entry-level
description field that can go into HTML header field
Posted by "Dave Johnson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ROL-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480732#comment-13480732 ]
Dave Johnson commented on ROL-1947:
-----------------------------------
Patch looks pretty good and I'll commit once I've done som testing.
> Provide a blog entry-level description field that can go into HTML header field
> -------------------------------------------------------------------------------
>
> Key: ROL-1947
> URL: https://issues.apache.org/jira/browse/ROL-1947
> Project: Roller
> Issue Type: Improvement
> Reporter: Glen Mazza
> Assignee: Roller Unassigned
> Attachments: BloggerCurrent.png, ROL1947.patch, RollerProposed.png
>
>
> Hi, as discussed here:
> http://mail-archives.apache.org/mod_mbox/roller-user/201207.mbox/%3C4FF1A023.5020504%40talend.com%3E
> Provide an ability to store a description field for each blog entry, that the user may wish to employ (via template modifications) to place within the HTML header, like so:
> <meta name="Description" content="$model.weblogEntry.description"/>
> This information is utilized by search engines to varying degrees when they wish to describe the contents of the blog article on the search results page, and is functionality already available in Google Blogger.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (ROL-1947) Provide a blog entry-level description
field that can go into HTML header field
Posted by "Dave Johnson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ROL-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Johnson resolved ROL-1947.
-------------------------------
Resolution: Fixed
Assignee: Dave Johnson (was: Roller Unassigned)
Please re-open if there is additional work to do.
> Provide a blog entry-level description field that can go into HTML header field
> -------------------------------------------------------------------------------
>
> Key: ROL-1947
> URL: https://issues.apache.org/jira/browse/ROL-1947
> Project: Roller
> Issue Type: Improvement
> Reporter: Glen Mazza
> Assignee: Dave Johnson
> Attachments: BloggerCurrent.png, ROL1947.patch, RollerProposed.png
>
>
> Hi, as discussed here:
> http://mail-archives.apache.org/mod_mbox/roller-user/201207.mbox/%3C4FF1A023.5020504%40talend.com%3E
> Provide an ability to store a description field for each blog entry, that the user may wish to employ (via template modifications) to place within the HTML header, like so:
> <meta name="Description" content="$model.weblogEntry.description"/>
> This information is utilized by search engines to varying degrees when they wish to describe the contents of the blog article on the search results page, and is functionality already available in Google Blogger.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ROL-1947) Provide a blog entry-level
description field that can go into HTML header field
Posted by "Glen Mazza (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ROL-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502999#comment-13502999 ]
Glen Mazza commented on ROL-1947:
---------------------------------
You don't assign JIRAs to anyone (unless you are the person's boss). You can supply a patch or wait for a volunteer to fix it.
> Provide a blog entry-level description field that can go into HTML header field
> -------------------------------------------------------------------------------
>
> Key: ROL-1947
> URL: https://issues.apache.org/jira/browse/ROL-1947
> Project: Roller
> Issue Type: Improvement
> Reporter: Glen Mazza
> Assignee: Roller Unassigned
> Attachments: BloggerCurrent.png, ROL1947.patch, RollerProposed.png
>
>
> Hi, as discussed here:
> http://mail-archives.apache.org/mod_mbox/roller-user/201207.mbox/%3C4FF1A023.5020504%40talend.com%3E
> Provide an ability to store a description field for each blog entry, that the user may wish to employ (via template modifications) to place within the HTML header, like so:
> <meta name="Description" content="$model.weblogEntry.description"/>
> This information is utilized by search engines to varying degrees when they wish to describe the contents of the blog article on the search results page, and is functionality already available in Google Blogger.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ROL-1947) Provide a blog entry-level
description field that can go into HTML header field
Posted by "Harsh Gupta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ROL-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502994#comment-13502994 ]
Harsh Gupta commented on ROL-1947:
----------------------------------
vm means velocity file. This code in velocity file $model.weblogEntry.searchDescription can't work unless the getSearchDescription() method exists in wrapper class. Dave forgot to check-in this code.
Also no body has take any action on https://issues.apache.org/jira/browse/ROL-1949 . How do i assign it to somebody?
> Provide a blog entry-level description field that can go into HTML header field
> -------------------------------------------------------------------------------
>
> Key: ROL-1947
> URL: https://issues.apache.org/jira/browse/ROL-1947
> Project: Roller
> Issue Type: Improvement
> Reporter: Glen Mazza
> Assignee: Roller Unassigned
> Attachments: BloggerCurrent.png, ROL1947.patch, RollerProposed.png
>
>
> Hi, as discussed here:
> http://mail-archives.apache.org/mod_mbox/roller-user/201207.mbox/%3C4FF1A023.5020504%40talend.com%3E
> Provide an ability to store a description field for each blog entry, that the user may wish to employ (via template modifications) to place within the HTML header, like so:
> <meta name="Description" content="$model.weblogEntry.description"/>
> This information is utilized by search engines to varying degrees when they wish to describe the contents of the blog article on the search results page, and is functionality already available in Google Blogger.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira