You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Virag Kothari <vi...@yahoo-inc.com> on 2013/09/08 09:47:29 UTC
Review Request 14026: OOZIE-1462: Compress lob columns before storing in
database
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14026/
-----------------------------------------------------------
Review request for oozie.
Summary (updated)
-----------------
OOZIE-1462: Compress lob columns before storing in database
Bugs: OOZIE-1462
https://issues.apache.org/jira/browse/OOZIE-1462
Repository: oozie
Description (updated)
-------
https://issues.apache.org/jira/browse/OOZIE-1462
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/BinaryBlob.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1520843
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1520843
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1520843
trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1520843
trunk/core/src/main/java/org/apache/oozie/StringBlob.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1520843
trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1520843
trunk/core/src/main/java/org/apache/oozie/compression/CodecFactory.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/compression/CompressionCodec.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/compression/GzipCompressionCodec.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BinaryBlobValueHandler.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java 1520843
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobInfoGetJPAExecutor.java 1520843
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java 1520843
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetNeedStartJPAExecutor.java 1520843
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetPausedJPAExecutor.java 1520843
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetRunningOrPendingJPAExecutor.java 1520843
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetUnpausedJPAExecutor.java 1520843
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForCheckJPAExecutor.java 1520843
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForExternalIdJPAExecutor.java 1520843
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForInfoJPAExecutor.java 1520843
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForInputCheckJPAExecutor.java 1520843
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForStartJPAExecutor.java 1520843
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForTimeoutJPAExecutor.java 1520843
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetJPAExecutor.java 1520843
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 1520843
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsGetForRecoveryJPAExecutor.java 1520843
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionForNominalTimeJPAExecutor.java 1520843
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsForDatesJPAExecutor.java 1520843
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsNotCompletedJPAExecutor.java 1520843
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 1520843
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1520843
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetPausedJPAExecutor.java 1520843
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetPendingJPAExecutor.java 1520843
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetUnpausedJPAExecutor.java 1520843
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsToBeMaterializedJPAExecutor.java 1520843
trunk/core/src/main/java/org/apache/oozie/executor/jpa/StringBlobValueHandler.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionGetJPAExecutor.java 1520843
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1520843
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionSubsetGetJPAExecutor.java 1520843
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionsGetForJobJPAExecutor.java 1520843
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionsRunningGetJPAExecutor.java 1520843
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetActionsJPAExecutor.java 1520843
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java 1520843
trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1520843
trunk/core/src/main/java/org/apache/oozie/store/CoordinatorStore.java 1520843
trunk/core/src/main/java/org/apache/oozie/store/WorkflowStore.java 1520843
trunk/core/src/main/resources/oozie-default.xml 1520843
trunk/core/src/test/java/org/apache/oozie/compression/TestCodecFactory.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 1520843
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobQueryExecutor.java 1520843
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1520843
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobQueryExecutor.java 1520843
Diff: https://reviews.apache.org/r/14026/diff/
Testing
-------
Thanks,
Virag Kothari
Re: Review Request 14026: OOZIE-1462: Compress lob columns before storing in
database
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14026/#review25981
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/BinaryBlob.java
<https://reviews.apache.org/r/14026/#comment50728>
if (codec == null) {
bytes = rawBlob
}
else {
bytes = codec.decompressToBytes(dais);
}
trunk/core/src/main/java/org/apache/oozie/BinaryBlob.java
<https://reviews.apache.org/r/14026/#comment50710>
This can be removed and moved to codec == null clause. comment above.
trunk/core/src/main/java/org/apache/oozie/BinaryBlob.java
<https://reviews.apache.org/r/14026/#comment50711>
Can reuse rawBlob. Don't have to declare uncompressed
trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java
<https://reviews.apache.org/r/14026/#comment50713>
Can be in a single line.
return jobXml == null ? null : jobXml.getString();
All other getters too.
trunk/core/src/main/java/org/apache/oozie/StringBlob.java
<https://reviews.apache.org/r/14026/#comment50729>
if (codec == null) {
// new String
}
else {
string = codec.decompressToString(dais);
}
trunk/core/src/main/java/org/apache/oozie/StringBlob.java
<https://reviews.apache.org/r/14026/#comment50716>
This can be moved into codec == null clause.
trunk/core/src/main/java/org/apache/oozie/StringBlob.java
<https://reviews.apache.org/r/14026/#comment50717>
Can reuse rawBlob. Don't have to declare another one
trunk/core/src/main/java/org/apache/oozie/compression/CodecFactory.java
<https://reviews.apache.org/r/14026/#comment50727>
Remove this line
trunk/core/src/main/java/org/apache/oozie/compression/CodecFactory.java
<https://reviews.apache.org/r/14026/#comment50726>
Remove this line
trunk/core/src/main/java/org/apache/oozie/compression/CodecFactory.java
<https://reviews.apache.org/r/14026/#comment50725>
Move this before // codec for compressing.
Do this so that output.compression.codec is just the name of the codec and oozie.compression.codecs specifies the codec and its implementing class names
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java
<https://reviews.apache.org/r/14026/#comment50718>
not required.
trunk/core/src/main/java/org/apache/oozie/store/CoordinatorStore.java
<https://reviews.apache.org/r/14026/#comment50720>
Not to be changed. Getting rid of copies in JPAExecutors are ok. But in WorkflowStore, CoordinatorStore, etc the EntityManager is not closed after executing the query. So need to copy to a new object.
trunk/core/src/main/java/org/apache/oozie/store/WorkflowStore.java
<https://reviews.apache.org/r/14026/#comment50721>
Not to be changed. Getting rid of copies in JPAExecutors are ok. But in WorkflowStore, CoordinatorStore, etc the EntityManager is not closed after executing the query. So need to copy to a new object.
trunk/core/src/main/resources/oozie-default.xml
<https://reviews.apache.org/r/14026/#comment50722>
space
trunk/core/src/main/resources/oozie-default.xml
<https://reviews.apache.org/r/14026/#comment50723>
The name of the compression codec to use.
The implementation class for the codec needs to be specified through another property oozie.compression.codecs. You can specify a comma separated list of
'Codec_name'='Codec_class' for oozie.compression.codecs
where codec class implements the interface org.apache.oozie.compression.CompressionCodec. If oozie.compression.codecs is not specified, gz codec implementation is used by default.
- Rohini Palaniswamy
On Sept. 8, 2013, 7:47 a.m., Virag Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14026/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2013, 7:47 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1462
> https://issues.apache.org/jira/browse/OOZIE-1462
>
>
> Repository: oozie
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1462
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/BinaryBlob.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1520843
> trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1520843
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1520843
> trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1520843
> trunk/core/src/main/java/org/apache/oozie/StringBlob.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1520843
> trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1520843
> trunk/core/src/main/java/org/apache/oozie/compression/CodecFactory.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/compression/CompressionCodec.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/compression/GzipCompressionCodec.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BinaryBlobValueHandler.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java 1520843
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobInfoGetJPAExecutor.java 1520843
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java 1520843
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetNeedStartJPAExecutor.java 1520843
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetPausedJPAExecutor.java 1520843
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetRunningOrPendingJPAExecutor.java 1520843
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetUnpausedJPAExecutor.java 1520843
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForCheckJPAExecutor.java 1520843
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForExternalIdJPAExecutor.java 1520843
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForInfoJPAExecutor.java 1520843
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForInputCheckJPAExecutor.java 1520843
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForStartJPAExecutor.java 1520843
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForTimeoutJPAExecutor.java 1520843
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetJPAExecutor.java 1520843
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 1520843
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsGetForRecoveryJPAExecutor.java 1520843
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionForNominalTimeJPAExecutor.java 1520843
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsForDatesJPAExecutor.java 1520843
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsNotCompletedJPAExecutor.java 1520843
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 1520843
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1520843
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetPausedJPAExecutor.java 1520843
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetPendingJPAExecutor.java 1520843
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetUnpausedJPAExecutor.java 1520843
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsToBeMaterializedJPAExecutor.java 1520843
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/StringBlobValueHandler.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionGetJPAExecutor.java 1520843
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1520843
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionSubsetGetJPAExecutor.java 1520843
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionsGetForJobJPAExecutor.java 1520843
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionsRunningGetJPAExecutor.java 1520843
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetActionsJPAExecutor.java 1520843
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java 1520843
> trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1520843
> trunk/core/src/main/java/org/apache/oozie/store/CoordinatorStore.java 1520843
> trunk/core/src/main/java/org/apache/oozie/store/WorkflowStore.java 1520843
> trunk/core/src/main/resources/oozie-default.xml 1520843
> trunk/core/src/test/java/org/apache/oozie/compression/TestCodecFactory.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 1520843
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobQueryExecutor.java 1520843
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1520843
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobQueryExecutor.java 1520843
>
> Diff: https://reviews.apache.org/r/14026/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Virag Kothari
>
>
Re: Review Request 14026: OOZIE-1462: Compress lob columns before storing in
database
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14026/#review26001
-----------------------------------------------------------
Ship it!
Ship It!
- Rohini Palaniswamy
On Sept. 9, 2013, 7:56 p.m., Virag Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14026/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2013, 7:56 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1462
> https://issues.apache.org/jira/browse/OOZIE-1462
>
>
> Repository: oozie
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1462
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/BinaryBlob.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1521261
> trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1521261
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1521261
> trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1521261
> trunk/core/src/main/java/org/apache/oozie/StringBlob.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1521261
> trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1521261
> trunk/core/src/main/java/org/apache/oozie/compression/CodecFactory.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/compression/CompressionCodec.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/compression/GzipCompressionCodec.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BinaryBlobValueHandler.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java 1521261
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobInfoGetJPAExecutor.java 1521261
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java 1521261
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetNeedStartJPAExecutor.java 1521261
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetPausedJPAExecutor.java 1521261
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetRunningOrPendingJPAExecutor.java 1521261
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetUnpausedJPAExecutor.java 1521261
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForCheckJPAExecutor.java 1521261
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForExternalIdJPAExecutor.java 1521261
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForInfoJPAExecutor.java 1521261
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForInputCheckJPAExecutor.java 1521261
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForStartJPAExecutor.java 1521261
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForTimeoutJPAExecutor.java 1521261
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetJPAExecutor.java 1521261
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 1521261
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsGetForRecoveryJPAExecutor.java 1521261
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionForNominalTimeJPAExecutor.java 1521261
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsForDatesJPAExecutor.java 1521261
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsNotCompletedJPAExecutor.java 1521261
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 1521261
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1521261
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetPausedJPAExecutor.java 1521261
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetPendingJPAExecutor.java 1521261
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetUnpausedJPAExecutor.java 1521261
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsToBeMaterializedJPAExecutor.java 1521261
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/StringBlobValueHandler.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionGetJPAExecutor.java 1521261
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1521261
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionSubsetGetJPAExecutor.java 1521261
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionsGetForJobJPAExecutor.java 1521261
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionsRunningGetJPAExecutor.java 1521261
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetActionsJPAExecutor.java 1521261
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java 1521261
> trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1521261
> trunk/core/src/main/java/org/apache/oozie/store/CoordinatorStore.java 1521261
> trunk/core/src/main/java/org/apache/oozie/store/WorkflowStore.java 1521261
> trunk/core/src/main/resources/oozie-default.xml 1521261
> trunk/core/src/test/java/org/apache/oozie/compression/TestCodecFactory.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 1521261
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobQueryExecutor.java 1521261
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1521261
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobQueryExecutor.java 1521261
>
> Diff: https://reviews.apache.org/r/14026/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Virag Kothari
>
>
Re: Review Request 14026: OOZIE-1462: Compress lob columns before storing in
database
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14026/
-----------------------------------------------------------
(Updated Sept. 9, 2013, 7:56 p.m.)
Review request for oozie.
Changes
-------
Addressed rohini's comments
Bugs: OOZIE-1462
https://issues.apache.org/jira/browse/OOZIE-1462
Repository: oozie
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1462
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/BinaryBlob.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1521261
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1521261
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1521261
trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1521261
trunk/core/src/main/java/org/apache/oozie/StringBlob.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1521261
trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1521261
trunk/core/src/main/java/org/apache/oozie/compression/CodecFactory.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/compression/CompressionCodec.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/compression/GzipCompressionCodec.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BinaryBlobValueHandler.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java 1521261
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobInfoGetJPAExecutor.java 1521261
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java 1521261
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetNeedStartJPAExecutor.java 1521261
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetPausedJPAExecutor.java 1521261
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetRunningOrPendingJPAExecutor.java 1521261
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetUnpausedJPAExecutor.java 1521261
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForCheckJPAExecutor.java 1521261
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForExternalIdJPAExecutor.java 1521261
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForInfoJPAExecutor.java 1521261
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForInputCheckJPAExecutor.java 1521261
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForStartJPAExecutor.java 1521261
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForTimeoutJPAExecutor.java 1521261
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetJPAExecutor.java 1521261
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 1521261
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsGetForRecoveryJPAExecutor.java 1521261
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionForNominalTimeJPAExecutor.java 1521261
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsForDatesJPAExecutor.java 1521261
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsNotCompletedJPAExecutor.java 1521261
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 1521261
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1521261
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetPausedJPAExecutor.java 1521261
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetPendingJPAExecutor.java 1521261
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetUnpausedJPAExecutor.java 1521261
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsToBeMaterializedJPAExecutor.java 1521261
trunk/core/src/main/java/org/apache/oozie/executor/jpa/StringBlobValueHandler.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionGetJPAExecutor.java 1521261
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1521261
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionSubsetGetJPAExecutor.java 1521261
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionsGetForJobJPAExecutor.java 1521261
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionsRunningGetJPAExecutor.java 1521261
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetActionsJPAExecutor.java 1521261
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java 1521261
trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1521261
trunk/core/src/main/java/org/apache/oozie/store/CoordinatorStore.java 1521261
trunk/core/src/main/java/org/apache/oozie/store/WorkflowStore.java 1521261
trunk/core/src/main/resources/oozie-default.xml 1521261
trunk/core/src/test/java/org/apache/oozie/compression/TestCodecFactory.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 1521261
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobQueryExecutor.java 1521261
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1521261
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobQueryExecutor.java 1521261
Diff: https://reviews.apache.org/r/14026/diff/
Testing
-------
Thanks,
Virag Kothari
Re: Review Request 14026: OOZIE-1462: Compress lob columns before storing in
database
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14026/#review25996
-----------------------------------------------------------
Just one minor comment
trunk/core/src/main/java/org/apache/oozie/compression/CodecFactory.java
<https://reviews.apache.org/r/14026/#comment50749>
To be removed and moved to isEnabled section
trunk/core/src/main/java/org/apache/oozie/compression/CodecFactory.java
<https://reviews.apache.org/r/14026/#comment50750>
Here do
if(REGISTERED.get(GzipCompressionCodec.CODEC_NAME) == null) {
REGISTERED.put(GzipCompressionCodec.CODEC_NAME, new GzipCompressionCodec());
}
- Rohini Palaniswamy
On Sept. 9, 2013, 6:43 p.m., Virag Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14026/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2013, 6:43 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1462
> https://issues.apache.org/jira/browse/OOZIE-1462
>
>
> Repository: oozie
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1462
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/BinaryBlob.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1521224
> trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1521224
> trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1521224
> trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1521224
> trunk/core/src/main/java/org/apache/oozie/StringBlob.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1521224
> trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1521224
> trunk/core/src/main/java/org/apache/oozie/compression/CodecFactory.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/compression/CompressionCodec.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/compression/GzipCompressionCodec.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BinaryBlobValueHandler.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java 1521224
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobInfoGetJPAExecutor.java 1521224
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java 1521224
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetNeedStartJPAExecutor.java 1521224
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetPausedJPAExecutor.java 1521224
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetRunningOrPendingJPAExecutor.java 1521224
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetUnpausedJPAExecutor.java 1521224
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForCheckJPAExecutor.java 1521224
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForExternalIdJPAExecutor.java 1521224
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForInfoJPAExecutor.java 1521224
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForInputCheckJPAExecutor.java 1521224
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForStartJPAExecutor.java 1521224
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForTimeoutJPAExecutor.java 1521224
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetJPAExecutor.java 1521224
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 1521224
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsGetForRecoveryJPAExecutor.java 1521224
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionForNominalTimeJPAExecutor.java 1521224
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsForDatesJPAExecutor.java 1521224
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsNotCompletedJPAExecutor.java 1521224
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 1521224
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1521224
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetPausedJPAExecutor.java 1521224
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetPendingJPAExecutor.java 1521224
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetUnpausedJPAExecutor.java 1521224
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsToBeMaterializedJPAExecutor.java 1521224
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/StringBlobValueHandler.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionGetJPAExecutor.java 1521224
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1521224
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionSubsetGetJPAExecutor.java 1521224
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionsGetForJobJPAExecutor.java 1521224
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionsRunningGetJPAExecutor.java 1521224
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetActionsJPAExecutor.java 1521224
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java 1521224
> trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1521224
> trunk/core/src/main/java/org/apache/oozie/store/CoordinatorStore.java 1521224
> trunk/core/src/main/java/org/apache/oozie/store/WorkflowStore.java 1521224
> trunk/core/src/main/resources/oozie-default.xml 1521224
> trunk/core/src/test/java/org/apache/oozie/compression/TestCodecFactory.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 1521224
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobQueryExecutor.java 1521224
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1521224
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobQueryExecutor.java 1521224
>
> Diff: https://reviews.apache.org/r/14026/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Virag Kothari
>
>
Re: Review Request 14026: OOZIE-1462: Compress lob columns before storing in
database
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14026/
-----------------------------------------------------------
(Updated Sept. 9, 2013, 6:43 p.m.)
Review request for oozie.
Changes
-------
Addressed Rohini's comments
Bugs: OOZIE-1462
https://issues.apache.org/jira/browse/OOZIE-1462
Repository: oozie
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1462
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/BinaryBlob.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/BundleJobBean.java 1521224
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1521224
trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1521224
trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1521224
trunk/core/src/main/java/org/apache/oozie/StringBlob.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java 1521224
trunk/core/src/main/java/org/apache/oozie/WorkflowJobBean.java 1521224
trunk/core/src/main/java/org/apache/oozie/compression/CodecFactory.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/compression/CompressionCodec.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/compression/GzipCompressionCodec.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BinaryBlobValueHandler.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java 1521224
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobInfoGetJPAExecutor.java 1521224
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobQueryExecutor.java 1521224
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetNeedStartJPAExecutor.java 1521224
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetPausedJPAExecutor.java 1521224
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetRunningOrPendingJPAExecutor.java 1521224
trunk/core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetUnpausedJPAExecutor.java 1521224
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForCheckJPAExecutor.java 1521224
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForExternalIdJPAExecutor.java 1521224
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForInfoJPAExecutor.java 1521224
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForInputCheckJPAExecutor.java 1521224
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForStartJPAExecutor.java 1521224
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForTimeoutJPAExecutor.java 1521224
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetJPAExecutor.java 1521224
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java 1521224
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsGetForRecoveryJPAExecutor.java 1521224
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionForNominalTimeJPAExecutor.java 1521224
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsForDatesJPAExecutor.java 1521224
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsNotCompletedJPAExecutor.java 1521224
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 1521224
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java 1521224
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetPausedJPAExecutor.java 1521224
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetPendingJPAExecutor.java 1521224
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetUnpausedJPAExecutor.java 1521224
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsToBeMaterializedJPAExecutor.java 1521224
trunk/core/src/main/java/org/apache/oozie/executor/jpa/StringBlobValueHandler.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionGetJPAExecutor.java 1521224
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 1521224
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionSubsetGetJPAExecutor.java 1521224
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionsGetForJobJPAExecutor.java 1521224
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionsRunningGetJPAExecutor.java 1521224
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobGetActionsJPAExecutor.java 1521224
trunk/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobQueryExecutor.java 1521224
trunk/core/src/main/java/org/apache/oozie/service/JPAService.java 1521224
trunk/core/src/main/java/org/apache/oozie/store/CoordinatorStore.java 1521224
trunk/core/src/main/java/org/apache/oozie/store/WorkflowStore.java 1521224
trunk/core/src/main/resources/oozie-default.xml 1521224
trunk/core/src/test/java/org/apache/oozie/compression/TestCodecFactory.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java 1521224
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobQueryExecutor.java 1521224
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionQueryExecutor.java 1521224
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobQueryExecutor.java 1521224
Diff: https://reviews.apache.org/r/14026/diff/
Testing
-------
Thanks,
Virag Kothari