[jira] [Commented] (MYFACES-3587) Not existing viewId will not be handled

["Martin Kočí (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/MYFACES-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782034#comment-13782034 ] 

Martin Kočí commented on MYFACES-3587:
--------------------------------------

I have this issue too, but the configuration of myfaces has Facelts-VDL only (org.apache.myfaces.SUPPORT_JSP_AND_FACES_EL=false) 

In the method : ViewHandlerImpl.createView(FacesContext, String)

getViewHandlerSupport(context).calculateViewId(context, viewId) returns null. Then getViewDeclarationLanguage(context,calculatedViewId).createView(context,calculatedViewId) throws unreadable NPE instead of java.lang.NoClassDefFoundError: javax/servlet/jsp/jstl/core/Config:

java.lang.NullPointerException
	at org.apache.myfaces.application.ViewHandlerImpl.createView(ViewHandlerImpl.java:259)
	at javax.faces.application.ViewHandlerWrapper.createView(ViewHandlerWrapper.java:101)
        ...
	at org.apache.myfaces.lifecycle.RestoreViewExecutor.execute(RestoreViewExecutor.java:235)
	at org.apache.myfaces.lifecycle.LifecycleImpl.executePhase(LifecycleImpl.java:196)
	at org.apache.myfaces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:143)
	at org.apache.myfaces.extensions.cdi.jsf2.impl.listener.phase.CodiLifecycleWrapper.execute(CodiLifecycleWrapper.java:95)
	at javax.faces.webapp.FacesServlet.service(FacesServlet.java:199)

> Not existing viewId will not be handled
> ---------------------------------------
>
>                 Key: MYFACES-3587
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3587
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: General
>    Affects Versions: 2.1.8
>         Environment: Jetty/Tomcat, JUEL, CODI, ExtVal
>            Reporter: Thomas Andraschko
>            Assignee: Leonardo Uribe
>
> If i call a page, which does not exist, following exceptions occurs: Cannot reset buffer after response has been committed.
> After digging deeper into this problem, i found out that getViewHandlerSupport()#calculateViewId returns null and the JspViewDeclarationLanguageStrategy will be used -> 
> Cannot reset buffer after response has been committed. 
> occurs.
> I added a null check for the logicalViewId in RestoreViewExecutor#execute to call HttpServletResponse#sendError.
> It does not work as expected because it just renders the errorPage and no redirect will be done.
> Why there is not such null check?
> Is it possible to add this check and redirect to the web.xml defined 404 or common error page? Or should it use the ErrorHandler?



--
This message was sent by Atlassian JIRA
(v6.1#6144)