You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by cwannerstedt <gi...@git.apache.org> on 2015/07/01 14:07:23 UTC
[GitHub] cordova-plugin-statusbar pull request: CB-9214 - [iOS] Landscape w...
GitHub user cwannerstedt opened a pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/27
CB-9214 - [iOS] Landscape webview height is calculated wrong
Fix for the incorrectly calculated statusbar height, when hiding the statusbar in landscape orientation in iOS 8.
At first I thought I use the IsAtLeastiOSVersion macro, but then I noticed it had already been tested in https://issues.apache.org/jira/browse/CB-7549, so I replaced it with a more fool proof solution..
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cwannerstedt/cordova-plugin-statusbar master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-statusbar/pull/27.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #27
----
commit 07b55b752960e66ca4d0ba33b9c49d41b7241b43
Author: Christian Wannerstedt <cw...@contractor.ea.com>
Date: 2015-07-01T11:25:26Z
Use correct statusbar height for landscape orientation in iOS >= 8
commit 3e821abfc2888b77a3e86657698a2d6774152793
Author: Christian Wannerstedt <cw...@contractor.ea.com>
Date: 2015-07-01T11:49:50Z
Don't use IsAtLeastiOSVersion macro to determine height
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: CB-9214 - [iOS] Landscape w...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-statusbar/pull/27
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: CB-9214 - [iOS] Landscape w...
Posted by TheBikingViking <gi...@git.apache.org>.
Github user TheBikingViking commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/27#issuecomment-125466147
When will this pull request be merged back?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org