You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Liyin Tang (Created) (JIRA)" <ji...@apache.org> on 2011/10/29 00:20:32 UTC
[jira] [Created] (HBASE-4698) Let the HFile Pretty Printer print
all the key values for a specific row.
Let the HFile Pretty Printer print all the key values for a specific row.
-------------------------------------------------------------------------
Key: HBASE-4698
URL: https://issues.apache.org/jira/browse/HBASE-4698
Project: HBase
Issue Type: New Feature
Reporter: Liyin Tang
Assignee: Liyin Tang
When using HFile Pretty Printer to debug HBase issues,
it would very nice to allow the Pretty Printer to seek to a specific row, and only print all the key values for this row.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4698) Let the HFile Pretty Printer print
all the key values for a specific row.
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173425#comment-13173425 ]
Hadoop QA commented on HBASE-4698:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12508009/HBASE-4689-trunk.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/555//console
This message is automatically generated.
> Let the HFile Pretty Printer print all the key values for a specific row.
> -------------------------------------------------------------------------
>
> Key: HBASE-4698
> URL: https://issues.apache.org/jira/browse/HBASE-4698
> Project: HBase
> Issue Type: New Feature
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: D111.1.patch, D111.1.patch, D111.1.patch, D111.2.patch, D111.3.patch, D111.4.patch, HBASE-4689-trunk.patch
>
>
> When using HFile Pretty Printer to debug HBase issues,
> it would very nice to allow the Pretty Printer to seek to a specific row, and only print all the key values for this row.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4698) Let the HFile Pretty Printer print
all the key values for a specific row.
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139037#comment-13139037 ]
Phabricator commented on HBASE-4698:
------------------------------------
Liyin has commented on the revision "[jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.".
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:71 After discussed it offline with Mikhail, we agreed on just renaming it as row instead of startRow, since we don't have the endRow here :)
REVISION DETAIL
https://reviews.facebook.net/D111
> Let the HFile Pretty Printer print all the key values for a specific row.
> -------------------------------------------------------------------------
>
> Key: HBASE-4698
> URL: https://issues.apache.org/jira/browse/HBASE-4698
> Project: HBase
> Issue Type: New Feature
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: D111.1.patch, D111.1.patch, D111.1.patch
>
>
> When using HFile Pretty Printer to debug HBase issues,
> it would very nice to allow the Pretty Printer to seek to a specific row, and only print all the key values for this row.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4698) Let the HFile Pretty Printer print
all the key values for a specific row.
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139031#comment-13139031 ]
Phabricator commented on HBASE-4698:
------------------------------------
mbautin has commented on the revision "[jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.".
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:71 A follow-up comment after discussing this offline: rename startKey to startRow, otherwise it's not clear that it only contains the row portion of the key.
REVISION DETAIL
https://reviews.facebook.net/D111
> Let the HFile Pretty Printer print all the key values for a specific row.
> -------------------------------------------------------------------------
>
> Key: HBASE-4698
> URL: https://issues.apache.org/jira/browse/HBASE-4698
> Project: HBase
> Issue Type: New Feature
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: D111.1.patch, D111.1.patch, D111.1.patch
>
>
> When using HFile Pretty Printer to debug HBase issues,
> it would very nice to allow the Pretty Printer to seek to a specific row, and only print all the key values for this row.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4698) Let the HFile Pretty Printer print
all the key values for a specific row.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174036#comment-13174036 ]
Hudson commented on HBASE-4698:
-------------------------------
Integrated in HBase-TRUNK-security #39 (See [https://builds.apache.org/job/HBase-TRUNK-security/39/])
HBASE-4698 Let the HFile Pretty Printer print all the key values for a specific row; REMOVE OVER-COMMIT, STUFF NOT IN 4698 PATCH
HBASE-4698 Let the HFile Pretty Printer print all the key values for a specific row
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java
> Let the HFile Pretty Printer print all the key values for a specific row.
> -------------------------------------------------------------------------
>
> Key: HBASE-4698
> URL: https://issues.apache.org/jira/browse/HBASE-4698
> Project: HBase
> Issue Type: New Feature
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Fix For: 0.94.0
>
> Attachments: D111.1.patch, D111.1.patch, D111.1.patch, D111.2.patch, D111.3.patch, D111.4.patch, HBASE-4689-trunk.patch
>
>
> When using HFile Pretty Printer to debug HBase issues,
> it would very nice to allow the Pretty Printer to seek to a specific row, and only print all the key values for this row.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4698) Let the HFile Pretty Printer print
all the key values for a specific row.
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-4698:
-------------------------------
Attachment: D111.1.patch
Liyin requested code review of "[jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.".
Reviewers: DUMMY_REVIEWER
HBase-4698 Let the HFile Pretty Printer print all the key values for a specific row.
When using HFile Pretty Printer to debug HBase issues,
it would very nice to allow the Pretty Printer to seek to a specific row, and only print all the key values for this row.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D111
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/231/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Let the HFile Pretty Printer print all the key values for a specific row.
> -------------------------------------------------------------------------
>
> Key: HBASE-4698
> URL: https://issues.apache.org/jira/browse/HBASE-4698
> Project: HBase
> Issue Type: New Feature
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: D111.1.patch, D111.1.patch
>
>
> When using HFile Pretty Printer to debug HBase issues,
> it would very nice to allow the Pretty Printer to seek to a specific row, and only print all the key values for this row.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4698) Let the HFile Pretty Printer print
all the key values for a specific row.
Posted by "Liyin Tang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Liyin Tang updated HBASE-4698:
------------------------------
Attachment: HBASE-4689-trunk.patch
The diff based on 89-fb has been accepted and committed.
So generate this patch rebasing on the latest apache trunk.
> Let the HFile Pretty Printer print all the key values for a specific row.
> -------------------------------------------------------------------------
>
> Key: HBASE-4698
> URL: https://issues.apache.org/jira/browse/HBASE-4698
> Project: HBase
> Issue Type: New Feature
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: D111.1.patch, D111.1.patch, D111.1.patch, D111.2.patch, D111.3.patch, D111.4.patch, HBASE-4689-trunk.patch
>
>
> When using HFile Pretty Printer to debug HBase issues,
> it would very nice to allow the Pretty Printer to seek to a specific row, and only print all the key values for this row.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4698) Let the HFile Pretty Printer print
all the key values for a specific row.
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139022#comment-13139022 ]
Phabricator commented on HBASE-4698:
------------------------------------
mbautin has commented on the revision "[jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.".
A few comments inline:
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:137 What happens otherwise? I think we need to display an error message and terminate if the parameter is not specified.
src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:239 Is row just the row or the key portion of the KV, as the call suggests? If the latter, it is not clear to me how we get an exact match on the row.
src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:256-257 If we did not do a seekTo, this would produce a message for every row scanned before the row of interest. Does it make sense to move the message out of the loop?
REVISION DETAIL
https://reviews.facebook.net/D111
> Let the HFile Pretty Printer print all the key values for a specific row.
> -------------------------------------------------------------------------
>
> Key: HBASE-4698
> URL: https://issues.apache.org/jira/browse/HBASE-4698
> Project: HBase
> Issue Type: New Feature
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: D111.1.patch, D111.1.patch, D111.1.patch
>
>
> When using HFile Pretty Printer to debug HBase issues,
> it would very nice to allow the Pretty Printer to seek to a specific row, and only print all the key values for this row.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4698) Let the HFile Pretty Printer print
all the key values for a specific row.
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-4698:
-------------------------
Resolution: Fixed
Fix Version/s: 0.94.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to TRUNK. Thanks for the patch Liyin.
> Let the HFile Pretty Printer print all the key values for a specific row.
> -------------------------------------------------------------------------
>
> Key: HBASE-4698
> URL: https://issues.apache.org/jira/browse/HBASE-4698
> Project: HBase
> Issue Type: New Feature
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Fix For: 0.94.0
>
> Attachments: D111.1.patch, D111.1.patch, D111.1.patch, D111.2.patch, D111.3.patch, D111.4.patch, HBASE-4689-trunk.patch
>
>
> When using HFile Pretty Printer to debug HBase issues,
> it would very nice to allow the Pretty Printer to seek to a specific row, and only print all the key values for this row.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4698) Let the HFile Pretty Printer print
all the key values for a specific row.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174116#comment-13174116 ]
Hudson commented on HBASE-4698:
-------------------------------
Integrated in HBase-TRUNK #2566 (See [https://builds.apache.org/job/HBase-TRUNK/2566/])
HBASE-4698 Let the HFile Pretty Printer print all the key values for a specific row; REMOVE OVER-COMMIT, STUFF NOT IN 4698 PATCH
HBASE-4698 Let the HFile Pretty Printer print all the key values for a specific row
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java
> Let the HFile Pretty Printer print all the key values for a specific row.
> -------------------------------------------------------------------------
>
> Key: HBASE-4698
> URL: https://issues.apache.org/jira/browse/HBASE-4698
> Project: HBase
> Issue Type: New Feature
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Fix For: 0.94.0
>
> Attachments: D111.1.patch, D111.1.patch, D111.1.patch, D111.2.patch, D111.3.patch, D111.4.patch, HBASE-4689-trunk.patch
>
>
> When using HFile Pretty Printer to debug HBase issues,
> it would very nice to allow the Pretty Printer to seek to a specific row, and only print all the key values for this row.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4698) Let the HFile Pretty Printer print
all the key values for a specific row.
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140699#comment-13140699 ]
Phabricator commented on HBASE-4698:
------------------------------------
Liyin has commented on the revision "[jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.".
Thanks Mikhail's and Nicolas's review and response the comments inline.
I will update the diff to address the comments.
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:70 I used the Eclipse code formatter to format the code here, which is based on the hbase code style mentioned in HBase book.
http://hbase.apache.org/book.html#eclipse
However, there is no rule saying I have to add an empty line here.
src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:251 Good point:) thanks a lot. I will update this.
src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:253 I don't understand why this line is NOT necessary.
This function DOES throw out IOException, doesn't it?
src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:247 Why I need to remove this line?
According to the code format from the HBase book, there is no need to remove empty line in the java doc:
HBase book:
http://hbase.apache.org/book.html#eclipse
The setting:
<setting id="org.eclipse.jdt.core.formatter.comment.clear_blank_lines_in_javadoc_comment" value="false"/>
REVISION DETAIL
https://reviews.facebook.net/D111
> Let the HFile Pretty Printer print all the key values for a specific row.
> -------------------------------------------------------------------------
>
> Key: HBASE-4698
> URL: https://issues.apache.org/jira/browse/HBASE-4698
> Project: HBase
> Issue Type: New Feature
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: D111.1.patch, D111.1.patch, D111.1.patch, D111.2.patch, D111.3.patch
>
>
> When using HFile Pretty Printer to debug HBase issues,
> it would very nice to allow the Pretty Printer to seek to a specific row, and only print all the key values for this row.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4698) Let the HFile Pretty Printer print
all the key values for a specific row.
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-4698:
-------------------------------
Attachment: D111.3.patch
Liyin updated the revision "[jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.".
Reviewers: mbautin, Kannan, jgray, gqchen, nspiegelberg, JIRA
Address Mikhail's Comments
REVISION DETAIL
https://reviews.facebook.net/D111
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java
> Let the HFile Pretty Printer print all the key values for a specific row.
> -------------------------------------------------------------------------
>
> Key: HBASE-4698
> URL: https://issues.apache.org/jira/browse/HBASE-4698
> Project: HBase
> Issue Type: New Feature
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: D111.1.patch, D111.1.patch, D111.1.patch, D111.2.patch, D111.3.patch
>
>
> When using HFile Pretty Printer to debug HBase issues,
> it would very nice to allow the Pretty Printer to seek to a specific row, and only print all the key values for this row.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4698) Let the HFile Pretty Printer print
all the key values for a specific row.
Posted by "Liyin Tang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Liyin Tang updated HBASE-4698:
------------------------------
Status: Patch Available (was: Open)
> Let the HFile Pretty Printer print all the key values for a specific row.
> -------------------------------------------------------------------------
>
> Key: HBASE-4698
> URL: https://issues.apache.org/jira/browse/HBASE-4698
> Project: HBase
> Issue Type: New Feature
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: D111.1.patch, D111.1.patch, D111.1.patch, D111.2.patch, D111.3.patch, D111.4.patch, HBASE-4689-trunk.patch
>
>
> When using HFile Pretty Printer to debug HBase issues,
> it would very nice to allow the Pretty Printer to seek to a specific row, and only print all the key values for this row.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4698) Let the HFile Pretty Printer print
all the key values for a specific row.
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140716#comment-13140716 ]
Phabricator commented on HBASE-4698:
------------------------------------
nspiegelberg has commented on the revision "[jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.".
Were you going to remove the unnecessary println()s?
REVISION DETAIL
https://reviews.facebook.net/D111
> Let the HFile Pretty Printer print all the key values for a specific row.
> -------------------------------------------------------------------------
>
> Key: HBASE-4698
> URL: https://issues.apache.org/jira/browse/HBASE-4698
> Project: HBase
> Issue Type: New Feature
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: D111.1.patch, D111.1.patch, D111.1.patch, D111.2.patch, D111.3.patch
>
>
> When using HFile Pretty Printer to debug HBase issues,
> it would very nice to allow the Pretty Printer to seek to a specific row, and only print all the key values for this row.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4698) Let the HFile Pretty Printer print
all the key values for a specific row.
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140377#comment-13140377 ]
Phabricator commented on HBASE-4698:
------------------------------------
nspiegelberg has commented on the revision "[jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.".
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:136-137 I would remove this line. We should only print out information we inferred from user input versus this is direct input.
src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:266-267 remove these 2 println() as well
REVISION DETAIL
https://reviews.facebook.net/D111
> Let the HFile Pretty Printer print all the key values for a specific row.
> -------------------------------------------------------------------------
>
> Key: HBASE-4698
> URL: https://issues.apache.org/jira/browse/HBASE-4698
> Project: HBase
> Issue Type: New Feature
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: D111.1.patch, D111.1.patch, D111.1.patch, D111.2.patch, D111.3.patch
>
>
> When using HFile Pretty Printer to debug HBase issues,
> it would very nice to allow the Pretty Printer to seek to a specific row, and only print all the key values for this row.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4698) Let the HFile Pretty Printer print
all the key values for a specific row.
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139034#comment-13139034 ]
Phabricator commented on HBASE-4698:
------------------------------------
Liyin has commented on the revision "[jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.".
Thanks Mikhail for reviewing. Response the comments inline.
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:137 I agree we can print an error message here and terminate the printing if the user sets an incomplete option.
src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:256-257 Actually, no:)
If we don't want to seek to a specific row, then the param row here will be set null
src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:239 The row is the specific row user wants to print. It is not the key portion of the key value:)
The scanner always seeks to first key value for that row and here it only compares the row portion of the key.
I shall add a java doc here to clarify it better:)
REVISION DETAIL
https://reviews.facebook.net/D111
> Let the HFile Pretty Printer print all the key values for a specific row.
> -------------------------------------------------------------------------
>
> Key: HBASE-4698
> URL: https://issues.apache.org/jira/browse/HBASE-4698
> Project: HBase
> Issue Type: New Feature
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: D111.1.patch, D111.1.patch, D111.1.patch
>
>
> When using HFile Pretty Printer to debug HBase issues,
> it would very nice to allow the Pretty Printer to seek to a specific row, and only print all the key values for this row.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4698) Let the HFile Pretty Printer print
all the key values for a specific row.
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-4698:
-------------------------------
Attachment: D111.2.patch
Liyin updated the revision "[jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.".
Reviewers: mbautin, Kannan, jgray, gqchen, nspiegelberg, JIRA
Address Mikhail's comments.
REVISION DETAIL
https://reviews.facebook.net/D111
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java
> Let the HFile Pretty Printer print all the key values for a specific row.
> -------------------------------------------------------------------------
>
> Key: HBASE-4698
> URL: https://issues.apache.org/jira/browse/HBASE-4698
> Project: HBase
> Issue Type: New Feature
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: D111.1.patch, D111.1.patch, D111.1.patch, D111.2.patch
>
>
> When using HFile Pretty Printer to debug HBase issues,
> it would very nice to allow the Pretty Printer to seek to a specific row, and only print all the key values for this row.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4698) Let the HFile Pretty Printer print
all the key values for a specific row.
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-4698:
-------------------------------
Attachment: D111.4.patch
Liyin updated the revision "[jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.".
Reviewers: mbautin, Kannan, jgray, gqchen, nspiegelberg, JIRA
Address Nicolas's and Mikhail's comments.
REVISION DETAIL
https://reviews.facebook.net/D111
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java
> Let the HFile Pretty Printer print all the key values for a specific row.
> -------------------------------------------------------------------------
>
> Key: HBASE-4698
> URL: https://issues.apache.org/jira/browse/HBASE-4698
> Project: HBase
> Issue Type: New Feature
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: D111.1.patch, D111.1.patch, D111.1.patch, D111.2.patch, D111.3.patch, D111.4.patch
>
>
> When using HFile Pretty Printer to debug HBase issues,
> it would very nice to allow the Pretty Printer to seek to a specific row, and only print all the key values for this row.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4698) Let the HFile Pretty Printer print
all the key values for a specific row.
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140369#comment-13140369 ]
Phabricator commented on HBASE-4698:
------------------------------------
mbautin has accepted the revision "[jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.".
Looks good (a few very minor comments inline).
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:71 Nit: it would be nice to use Javadoc-style comments when referring to a specific field.
src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:133 Coding style: space between key and !=
src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:136-137 Nit: "the kv" seems to imply there is only one kv for the row, which is most often not the case
REVISION DETAIL
https://reviews.facebook.net/D111
> Let the HFile Pretty Printer print all the key values for a specific row.
> -------------------------------------------------------------------------
>
> Key: HBASE-4698
> URL: https://issues.apache.org/jira/browse/HBASE-4698
> Project: HBase
> Issue Type: New Feature
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: D111.1.patch, D111.1.patch, D111.1.patch, D111.2.patch
>
>
> When using HFile Pretty Printer to debug HBase issues,
> it would very nice to allow the Pretty Printer to seek to a specific row, and only print all the key values for this row.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4698) Let the HFile Pretty Printer print
all the key values for a specific row.
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-4698:
-------------------------------
Attachment: D111.1.patch
Liyin requested code review of "[jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.".
Reviewers: mbautin, Kannan, jgray, gqchen, nspiegelberg, JIRA
HBase-4698 Let the HFile Pretty Printer print all the key values for a specific row.
When using HFile Pretty Printer to debug HBase issues,
it would very nice to allow the Pretty Printer to seek to a specific row, and only print all the key values for this row.
TEST PLAN
tested this feature on dev cluster and running all the unit tests.
REVISION DETAIL
https://reviews.facebook.net/D111
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java
> Let the HFile Pretty Printer print all the key values for a specific row.
> -------------------------------------------------------------------------
>
> Key: HBASE-4698
> URL: https://issues.apache.org/jira/browse/HBASE-4698
> Project: HBase
> Issue Type: New Feature
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: D111.1.patch, D111.1.patch, D111.1.patch
>
>
> When using HFile Pretty Printer to debug HBase issues,
> it would very nice to allow the Pretty Printer to seek to a specific row, and only print all the key values for this row.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4698) Let the HFile Pretty Printer print
all the key values for a specific row.
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140628#comment-13140628 ]
Phabricator commented on HBASE-4698:
------------------------------------
mbautin has commented on the revision "[jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.".
A few more comments -- coding style only.
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:70 Code style: add an empty line in here.
src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:71-73 Code style: make this one line if it fits in 80 chars, e.g.
/** Your javadoc */
src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:247 Code style: this line is unnecessary
src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:253 This line is unnecessary because it does not say in what case the exception is thrown.
src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:251 if Row -> If row (capitalization)
REVISION DETAIL
https://reviews.facebook.net/D111
> Let the HFile Pretty Printer print all the key values for a specific row.
> -------------------------------------------------------------------------
>
> Key: HBASE-4698
> URL: https://issues.apache.org/jira/browse/HBASE-4698
> Project: HBase
> Issue Type: New Feature
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: D111.1.patch, D111.1.patch, D111.1.patch, D111.2.patch, D111.3.patch
>
>
> When using HFile Pretty Printer to debug HBase issues,
> it would very nice to allow the Pretty Printer to seek to a specific row, and only print all the key values for this row.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira