You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "nytai (via GitHub)" <gi...@apache.org> on 2023/09/18 21:38:10 UTC
[GitHub] [superset] nytai opened a new pull request, #25332: Update docker-compose docs
nytai opened a new pull request, #25332:
URL: https://github.com/apache/superset/pull/25332
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Update docker-compose docs to emphasize the issues with the `docker-compose up` and the node assets not building for 95% of users. Also updating the suggested tag to the latest release.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sfirke commented on a diff in pull request #25332: docs: update docker-compose
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on code in PR #25332:
URL: https://github.com/apache/superset/pull/25332#discussion_r1334766328
##########
docs/docs/installation/installing-superset-using-docker-compose.mdx:
##########
@@ -62,6 +62,9 @@ When working on master branch, run the following commands to run `development` m
```bash
docker compose up
```
+:::tip
+When running in development mode the `superset-node` container needs to finish building assets in order for the UI to render properly. If you would just like to try out Superset without making any code changes follow the steps documented for `production` or a specific version bellow.
Review Comment:
```suggestion
When running in development mode the `superset-node` container needs to finish building assets in order for the UI to render properly. If you would just like to try out Superset without making any code changes follow the steps documented for `production` or a specific version below.
```
##########
docs/docs/installation/installing-superset-using-docker-compose.mdx:
##########
@@ -72,12 +75,12 @@ docker-compose -f docker-compose-non-dev.yml up
Alternatively, you can also run a specific version of Superset by first checking out
the branch/tag, and then starting `docker-compose` with the `TAG` variable.
-For example, to run the 2.1.0 version, run the following commands:
+For example, to run the 3.0.0 version, run the following commands:
```bash
-git checkout 2.1.0
-TAG=2.1.0 docker-compose -f docker-compose-non-dev.yml pull
-TAG=2.1.0 docker-compose -f docker-compose-non-dev.yml up
+git checkout 3.0.0
+TAG=3.0.0 docker-compose -f docker-compose-non-dev.yml pull
+TAG=0.0.0 docker-compose -f docker-compose-non-dev.yml up
Review Comment:
```suggestion
TAG=3.0.0 docker-compose -f docker-compose-non-dev.yml up
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sfirke merged pull request #25332: docs: update docker-compose
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke merged PR #25332:
URL: https://github.com/apache/superset/pull/25332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark commented on a diff in pull request #25332: docs: update docker-compose
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark commented on code in PR #25332:
URL: https://github.com/apache/superset/pull/25332#discussion_r1330431068
##########
docs/docs/installation/installing-superset-using-docker-compose.mdx:
##########
@@ -75,9 +78,9 @@ the branch/tag, and then starting `docker-compose` with the `TAG` variable.
For example, to run the 2.1.0 version, run the following commands:
Review Comment:
+ 1
```suggestion
For example, to run the 3.0.0 version, run the following commands:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #25332: docs: update docker-compose
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #25332:
URL: https://github.com/apache/superset/pull/25332#issuecomment-1724498400
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/25332?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#25332](https://app.codecov.io/gh/apache/superset/pull/25332?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e55cb73) into [master](https://app.codecov.io/gh/apache/superset/commit/090ae64dfa3dab8c71a0ffbbdfc69e4ef4a73210?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (090ae64) will **decrease** coverage by `0.13%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #25332 +/- ##
==========================================
- Coverage 58.75% 58.63% -0.13%
==========================================
Files 1905 1905
Lines 74760 74760
Branches 8270 8270
==========================================
- Hits 43923 43833 -90
- Misses 28698 28788 +90
Partials 2139 2139
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/25332/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/25332/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/25332/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.70% <ø> (ø)` | |
| [python](https://app.codecov.io/gh/apache/superset/pull/25332/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `61.30% <ø> (-0.25%)` | :arrow_down: |
| [unit](https://app.codecov.io/gh/apache/superset/pull/25332/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.35% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 7 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/25332/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org