You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/05/29 17:26:57 UTC

[GitHub] [trafficcontrol] mitchell852 opened a new pull request #4736: removes deepcachingtype and routingname from emailed dsr struct

mitchell852 opened a new pull request #4736:
URL: https://github.com/apache/trafficcontrol/pull/4736


   ## What does this PR (Pull Request) do?
   Removes deepcachingtype and routingname which are not part of email version of deliveryservice request
   
   - [x] This PR fixes #4735 
   
   ## Which Traffic Control components are affected by this PR?
   
   - Traffic Ops
   
   ## What is the best way to verify this PR?
   Run the API tests
   Perform a POST to 1.4/deliveryservices/request minus deepcachingtype and routingname as required per https://traffic-control-cdn.readthedocs.io/en/latest/api/v1/deliveryservices_request.html#post and ensure the post succeeds.
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   - master
   - 4.0.0
   - 4.1.0 (RC1)
   
   ## The following criteria are ALL met by this PR
   
   - [x] This PR includes tests OR I have explained why tests are unnecessary
   - [x] This PR includes documentation OR I have explained why documentation is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] mitchell852 commented on pull request #4736: removes deepcachingtype and routingname from emailed dsr struct

Posted by GitBox <gi...@apache.org>.
mitchell852 commented on pull request #4736:
URL: https://github.com/apache/trafficcontrol/pull/4736#issuecomment-638298941


   closing in favor of #4756 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] ocket8888 commented on pull request #4736: removes deepcachingtype and routingname from emailed dsr struct

Posted by GitBox <gi...@apache.org>.
ocket8888 commented on pull request #4736:
URL: https://github.com/apache/trafficcontrol/pull/4736#issuecomment-636934244


   [Deep Caching Type and Routing Name did exist in the original, they just weren't required](https://github.com/apache/trafficcontrol/blob/master/traffic_ops/app/lib/API/Deliveryservice.pm#L1386-L1415)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] mitchell852 closed pull request #4736: removes deepcachingtype and routingname from emailed dsr struct

Posted by GitBox <gi...@apache.org>.
mitchell852 closed pull request #4736:
URL: https://github.com/apache/trafficcontrol/pull/4736


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] mitchell852 commented on pull request #4736: removes deepcachingtype and routingname from emailed dsr struct

Posted by GitBox <gi...@apache.org>.
mitchell852 commented on pull request #4736:
URL: https://github.com/apache/trafficcontrol/pull/4736#issuecomment-637729551


   > [Deep Caching Type and Routing Name did exist in the original, they just weren't required](https://github.com/apache/trafficcontrol/blob/master/traffic_ops/app/lib/API/Deliveryservice.pm#L1386-L1415)
   
   ah, good find


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org