You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Koji Sekiguchi (JIRA)" <ji...@apache.org> on 2011/05/22 14:12:48 UTC
[jira] [Created] (SOLR-2536) add reloadCache feature to
ExternalFileField
add reloadCache feature to ExternalFileField
--------------------------------------------
Key: SOLR-2536
URL: https://issues.apache.org/jira/browse/SOLR-2536
Project: Solr
Issue Type: Bug
Components: search
Affects Versions: 3.1, 1.4.1, 1.3
Reporter: Koji Sekiguchi
Assignee: Koji Sekiguchi
Priority: Minor
Fix For: 3.2, 4.0
spin off from SOLR-1607. To fix ExternalFileField bug described SOLR-1607, I'd propose introducing reloadCache feature over using proper key other than IndexReader.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (SOLR-2536) add reloadCache feature to
ExternalFileField
Posted by "Koji Sekiguchi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Koji Sekiguchi resolved SOLR-2536.
----------------------------------
Resolution: Fixed
trunk: Committed revision 1126487.
3x: Committed revision 1126492.
> add reloadCache feature to ExternalFileField
> --------------------------------------------
>
> Key: SOLR-2536
> URL: https://issues.apache.org/jira/browse/SOLR-2536
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3, 1.4.1, 3.1
> Reporter: Koji Sekiguchi
> Assignee: Koji Sekiguchi
> Priority: Minor
> Fix For: 3.2, 4.0
>
> Attachments: SOLR-2536.patch, SOLR-2536.patch
>
>
> spin off from SOLR-1607. To fix ExternalFileField bug described SOLR-1607, I'd propose introducing reloadCache feature over using proper key other than IndexReader.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-2536) add reloadCache feature to
ExternalFileField
Posted by "Koji Sekiguchi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Koji Sekiguchi updated SOLR-2536:
---------------------------------
Attachment: SOLR-2536.patch
2nd Patch. I changed test case to use the reloadCache feature.
Before patch, the test must add dummy doc before commit to visible the external file change, I patched like this:
{code}
- assertU(adoc("id", "10000")); // will get same reader if no index change
- assertU(commit());
+ assertU(h.query("/reloadCache",lrf.makeRequest("","")));
{code}
I think this is ready to commit.
> add reloadCache feature to ExternalFileField
> --------------------------------------------
>
> Key: SOLR-2536
> URL: https://issues.apache.org/jira/browse/SOLR-2536
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3, 1.4.1, 3.1
> Reporter: Koji Sekiguchi
> Assignee: Koji Sekiguchi
> Priority: Minor
> Fix For: 3.2, 4.0
>
> Attachments: SOLR-2536.patch, SOLR-2536.patch
>
>
> spin off from SOLR-1607. To fix ExternalFileField bug described SOLR-1607, I'd propose introducing reloadCache feature over using proper key other than IndexReader.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2536) add reloadCache feature to
ExternalFileField
Posted by "Koji Sekiguchi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039415#comment-13039415 ]
Koji Sekiguchi commented on SOLR-2536:
--------------------------------------
bq. If the filterCache or queryCache contains an entry that uses FileFloatSource, we'll still return stale results, right?
I may be missing something, but is it true?
(I named the handler "ReloadCache-", but I thought it was not appropriate after commit. The handler just reset readerCache then issue commit. So it doesn't reload in reality...)
> add reloadCache feature to ExternalFileField
> --------------------------------------------
>
> Key: SOLR-2536
> URL: https://issues.apache.org/jira/browse/SOLR-2536
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3, 1.4.1, 3.1
> Reporter: Koji Sekiguchi
> Assignee: Koji Sekiguchi
> Priority: Minor
> Fix For: 3.2, 4.0
>
> Attachments: SOLR-2536.patch, SOLR-2536.patch
>
>
> spin off from SOLR-1607. To fix ExternalFileField bug described SOLR-1607, I'd propose introducing reloadCache feature over using proper key other than IndexReader.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-2536) add reloadCache feature to
ExternalFileField
Posted by "Koji Sekiguchi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Koji Sekiguchi updated SOLR-2536:
---------------------------------
Attachment: SOLR-2536.patch
Patch attached. I introduced ReloadCacheRequestHandler in this patch. It does reset readerCache, then commit. It works nicely.
> add reloadCache feature to ExternalFileField
> --------------------------------------------
>
> Key: SOLR-2536
> URL: https://issues.apache.org/jira/browse/SOLR-2536
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3, 1.4.1, 3.1
> Reporter: Koji Sekiguchi
> Assignee: Koji Sekiguchi
> Priority: Minor
> Fix For: 3.2, 4.0
>
> Attachments: SOLR-2536.patch
>
>
> spin off from SOLR-1607. To fix ExternalFileField bug described SOLR-1607, I'd propose introducing reloadCache feature over using proper key other than IndexReader.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2536) add reloadCache feature to
ExternalFileField
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039401#comment-13039401 ]
Yonik Seeley commented on SOLR-2536:
------------------------------------
If the filterCache or queryCache contains an entry that uses FileFloatSource, we'll still return stale results, right?
Perhaps changing FileFloatSource to include a version (perhaps obtained from SolrIndexSearcher or SolrCore and incremented by this new handler?
> add reloadCache feature to ExternalFileField
> --------------------------------------------
>
> Key: SOLR-2536
> URL: https://issues.apache.org/jira/browse/SOLR-2536
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3, 1.4.1, 3.1
> Reporter: Koji Sekiguchi
> Assignee: Koji Sekiguchi
> Priority: Minor
> Fix For: 3.2, 4.0
>
> Attachments: SOLR-2536.patch, SOLR-2536.patch
>
>
> spin off from SOLR-1607. To fix ExternalFileField bug described SOLR-1607, I'd propose introducing reloadCache feature over using proper key other than IndexReader.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2536) add reloadCache feature to
ExternalFileField
Posted by "Koji Sekiguchi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039457#comment-13039457 ]
Koji Sekiguchi commented on SOLR-2536:
--------------------------------------
Hmm, the existing searcher can be used between resetCache and commit in this handler.
> add reloadCache feature to ExternalFileField
> --------------------------------------------
>
> Key: SOLR-2536
> URL: https://issues.apache.org/jira/browse/SOLR-2536
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3, 1.4.1, 3.1
> Reporter: Koji Sekiguchi
> Assignee: Koji Sekiguchi
> Priority: Minor
> Fix For: 3.2, 4.0
>
> Attachments: SOLR-2536.patch, SOLR-2536.patch
>
>
> spin off from SOLR-1607. To fix ExternalFileField bug described SOLR-1607, I'd propose introducing reloadCache feature over using proper key other than IndexReader.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org