You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2013/02/01 09:35:11 UTC
Review Request: FLUME-1891. Fast replay runs even when checkpoint exists.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9240/
-----------------------------------------------------------
Review request for Flume.
Description
-------
Fast replay is now run only if checkpoint file does not exist.
This addresses bug FLUME-1891.
https://issues.apache.org/jira/browse/FLUME-1891
Diffs
-----
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java d921387
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java 8a4201c
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java ea57cdb
Diff: https://reviews.apache.org/r/9240/diff/
Testing
-------
Added 2 unit tests to test for the case where checkpoint does not exist (or is corrupt) and where checkpoint exists.
Thanks,
Hari Shreedharan
Re: Review Request: FLUME-1891. Fast replay runs even when checkpoint exists.
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9240/#review16032
-----------------------------------------------------------
Ship it!
Ship It!
- Brock Noland
On Feb. 1, 2013, 5:59 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9240/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2013, 5:59 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Fast replay is now run only if checkpoint file does not exist.
>
>
> This addresses bug FLUME-1891.
> https://issues.apache.org/jira/browse/FLUME-1891
>
>
> Diffs
> -----
>
> flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java d921387
> flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java 8a4201c
> flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java ea57cdb
>
> Diff: https://reviews.apache.org/r/9240/diff/
>
>
> Testing
> -------
>
> Added 2 unit tests to test for the case where checkpoint does not exist (or is corrupt) and where checkpoint exists.
>
>
> Thanks,
>
> Hari Shreedharan
>
>
Re: Review Request: FLUME-1891. Fast replay runs even when checkpoint exists.
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9240/
-----------------------------------------------------------
(Updated Feb. 1, 2013, 5:59 p.m.)
Review request for Flume.
Changes
-------
Add more unit tests.
Description
-------
Fast replay is now run only if checkpoint file does not exist.
This addresses bug FLUME-1891.
https://issues.apache.org/jira/browse/FLUME-1891
Diffs (updated)
-----
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java d921387
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java 8a4201c
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java ea57cdb
Diff: https://reviews.apache.org/r/9240/diff/
Testing
-------
Added 2 unit tests to test for the case where checkpoint does not exist (or is corrupt) and where checkpoint exists.
Thanks,
Hari Shreedharan
Re: Review Request: FLUME-1891. Fast replay runs even when checkpoint exists.
Posted by Brock Noland <br...@cloudera.com>.
> On Feb. 1, 2013, 3:20 p.m., Brock Noland wrote:
> > Looks, good, I will run tests in a hour and commit if they pass.
>
> Hari Shreedharan wrote:
> Thanks Brock. I will submit a new patch with 2 more test cases (no code changes). Could you please hold of the commit till then? Thanks!
sure will do
- Brock
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9240/#review16011
-----------------------------------------------------------
On Feb. 1, 2013, 8:47 a.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9240/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2013, 8:47 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Fast replay is now run only if checkpoint file does not exist.
>
>
> This addresses bug FLUME-1891.
> https://issues.apache.org/jira/browse/FLUME-1891
>
>
> Diffs
> -----
>
> flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java d921387
> flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java 8a4201c
> flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java ea57cdb
>
> Diff: https://reviews.apache.org/r/9240/diff/
>
>
> Testing
> -------
>
> Added 2 unit tests to test for the case where checkpoint does not exist (or is corrupt) and where checkpoint exists.
>
>
> Thanks,
>
> Hari Shreedharan
>
>
Re: Review Request: FLUME-1891. Fast replay runs even when checkpoint exists.
Posted by Hari Shreedharan <hs...@cloudera.com>.
> On Feb. 1, 2013, 3:20 p.m., Brock Noland wrote:
> > Looks, good, I will run tests in a hour and commit if they pass.
Thanks Brock. I will submit a new patch with 2 more test cases (no code changes). Could you please hold of the commit till then? Thanks!
- Hari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9240/#review16011
-----------------------------------------------------------
On Feb. 1, 2013, 8:47 a.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9240/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2013, 8:47 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Fast replay is now run only if checkpoint file does not exist.
>
>
> This addresses bug FLUME-1891.
> https://issues.apache.org/jira/browse/FLUME-1891
>
>
> Diffs
> -----
>
> flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java d921387
> flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java 8a4201c
> flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java ea57cdb
>
> Diff: https://reviews.apache.org/r/9240/diff/
>
>
> Testing
> -------
>
> Added 2 unit tests to test for the case where checkpoint does not exist (or is corrupt) and where checkpoint exists.
>
>
> Thanks,
>
> Hari Shreedharan
>
>
Re: Review Request: FLUME-1891. Fast replay runs even when checkpoint exists.
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9240/#review16011
-----------------------------------------------------------
Looks, good, I will run tests in a hour and commit if they pass.
- Brock Noland
On Feb. 1, 2013, 8:47 a.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9240/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2013, 8:47 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Fast replay is now run only if checkpoint file does not exist.
>
>
> This addresses bug FLUME-1891.
> https://issues.apache.org/jira/browse/FLUME-1891
>
>
> Diffs
> -----
>
> flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java d921387
> flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java 8a4201c
> flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java ea57cdb
>
> Diff: https://reviews.apache.org/r/9240/diff/
>
>
> Testing
> -------
>
> Added 2 unit tests to test for the case where checkpoint does not exist (or is corrupt) and where checkpoint exists.
>
>
> Thanks,
>
> Hari Shreedharan
>
>
Re: Review Request: FLUME-1891. Fast replay runs even when checkpoint exists.
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9240/
-----------------------------------------------------------
(Updated Feb. 1, 2013, 8:47 a.m.)
Review request for Flume.
Changes
-------
Fixing test failure
Description
-------
Fast replay is now run only if checkpoint file does not exist.
This addresses bug FLUME-1891.
https://issues.apache.org/jira/browse/FLUME-1891
Diffs (updated)
-----
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java d921387
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java 8a4201c
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java ea57cdb
Diff: https://reviews.apache.org/r/9240/diff/
Testing
-------
Added 2 unit tests to test for the case where checkpoint does not exist (or is corrupt) and where checkpoint exists.
Thanks,
Hari Shreedharan