You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "lordrip (via GitHub)" <gi...@apache.org> on 2024/01/26 14:42:27 UTC
[PR] Update jasypt.adoc [camel-quarkus]
lordrip opened a new pull request, #5683:
URL: https://github.com/apache/camel-quarkus/pull/5683
Fix Title order affecting Camel website
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update jasypt.adoc [camel-quarkus]
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier commented on code in PR #5683:
URL: https://github.com/apache/camel-quarkus/pull/5683#discussion_r1467741672
##########
docs/modules/ROOT/pages/reference/extensions/jasypt.adoc:
##########
@@ -89,7 +89,7 @@ TIP: You can use the ability to mask security sensitive configuration in Camel b
You can also disable the startup configuration summary with the configuration `camel.main.autoConfigurationLogSummary = false`.
[id="extensions-jasypt-usage-injecting-encrypted-configuration"]
-==== Injecting encrypted configuration
+=== Injecting encrypted configuration
Review Comment:
I feel like it should be even one level lower, `Injecting encrupted configuration` sounds unrelated to `Maven coordinates`
##########
docs/modules/ROOT/pages/reference/extensions/jasypt.adoc:
##########
@@ -89,7 +89,7 @@ TIP: You can use the ability to mask security sensitive configuration in Camel b
You can also disable the startup configuration summary with the configuration `camel.main.autoConfigurationLogSummary = false`.
[id="extensions-jasypt-usage-injecting-encrypted-configuration"]
-==== Injecting encrypted configuration
+=== Injecting encrypted configuration
Review Comment:
I feel like it should be even one level lower, `Injecting encrypted configuration` sounds unrelated to `Maven coordinates`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update jasypt.adoc [camel-quarkus]
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier commented on code in PR #5683:
URL: https://github.com/apache/camel-quarkus/pull/5683#discussion_r1467743368
##########
.camel-jbang/camel-jbang-run.properties:
##########
@@ -0,0 +1,17 @@
+camel.main.sourceLocationEnabled=true
Review Comment:
shoudl nto be commited, unrelated the PR
##########
.camel-jbang/compile/UsedToWarmupDependenciesDownload.class:
##########
Review Comment:
shoudl nto be commited, unrelated the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update jasypt.adoc [camel-quarkus]
Posted by "lordrip (via GitHub)" <gi...@apache.org>.
lordrip closed pull request #5683: Update jasypt.adoc
URL: https://github.com/apache/camel-quarkus/pull/5683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update jasypt.adoc [camel-quarkus]
Posted by "apupier (via GitHub)" <gi...@apache.org>.
apupier commented on code in PR #5683:
URL: https://github.com/apache/camel-quarkus/pull/5683#discussion_r1467742486
##########
docs/modules/ROOT/pages/reference/extensions/jasypt.adoc:
##########
@@ -89,7 +89,7 @@ TIP: You can use the ability to mask security sensitive configuration in Camel b
You can also disable the startup configuration summary with the configuration `camel.main.autoConfigurationLogSummary = false`.
[id="extensions-jasypt-usage-injecting-encrypted-configuration"]
-==== Injecting encrypted configuration
+=== Injecting encrypted configuration
Review Comment:
forget about it, I missed the `usage` level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update jasypt.adoc [camel-quarkus]
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on PR #5683:
URL: https://github.com/apache/camel-quarkus/pull/5683#issuecomment-1912197922
Everything under `docs` is generated. You need to edit the source in the `jasypt`extension module here:
```
extensions/jasypt/runtime/src/main/doc/usage.adoc
```
Then run the build in that module (E.g `mvn clean install`) and it'll sync and assemble the final content over to `docs`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org