[GitHub] [iceberg] singhpk234 commented on a diff in pull request #6496: Core: Minor renaming to avoid engine specific naming in core

[GitBox <gi...@apache.org>]

singhpk234 commented on code in PR #6496:
URL: https://github.com/apache/iceberg/pull/6496#discussion_r1058592327


##########
core/src/test/java/org/apache/iceberg/TestCatalogUtil.java:
##########
@@ -218,14 +218,14 @@ public void loadCustomMetricsReporter_badClass() {
   public static class TestCatalog extends BaseMetastoreCatalog {
 
     private String catalogName;
-    private Map<String, String> flinkOptions;
+    private Map<String, String> options;

Review Comment:
   [minor] should we call it `catalogProperties` like we do in glue in hive catalog imp ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org