[jira] [Updated] (DERBY-6169) Reduce visibility of classes and methods under impl/sql

["Knut Anders Hatlen (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DERBY-6169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Knut Anders Hatlen updated DERBY-6169:
--------------------------------------

    Attachment: derby-6169-01-a.diff

Attaching a patch that reduces the visibility in some classes in the impl.sql.execute package.

- some classes that are not used outside of the package are made package protected

- in some classes that need to be public because they are Formatable, the constructor could be made package protected

- added a new method to the TriggerExecutionContext interface so that caller could access it without casting the context instance to the internal implementation class, and made InternalTriggerExecutionContext package protected

- removed some unused fields in DeleteCascadeResultSet

All the regression tests ran cleanly with the patch.
                
> Reduce visibility of classes and methods under impl/sql
> -------------------------------------------------------
>
>                 Key: DERBY-6169
>                 URL: https://issues.apache.org/jira/browse/DERBY-6169
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 10.11.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>         Attachments: derby-6169-01-a.diff
>
>
> My IDE shows many warnings in the classes under impl/sql because they are public and may make parts of the internal state more visible than necessary. I'd like to reduce the visibility of classes and methods, if possible, to make it clearer to IDEs and tools that perform static analysis that the code is only accessed from the same package, and reduce some of the noise from the tools.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira