[jira] [Commented] (COUCHDB-3273) Negative parameter count sent to /_uuids lead to crash

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/COUCHDB-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828117#comment-15828117 ] 

ASF GitHub Bot commented on COUCHDB-3273:
-----------------------------------------

GitHub user eiri opened a pull request:

    https://github.com/apache/couchdb-couch/pull/221

    Improve errors on invalid "count" parameter in /_uuids

    Added validation on "count" parameter to be positive and changed return code for "count" exceeding maximum from "Forbidden" to "Bad Request"
    
    COUCHDB-3273

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloudant/couchdb-couch validate-count-in-uuids

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-couch/pull/221.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #221
    
----
commit 01552406e8674d282ca3c9d58199477abb16ea78
Author: Eric Avdey <ei...@eiri.ca>
Date:   2017-01-18T13:44:15Z

    Validate that count in /_uuids is positive

commit 168caf5b79dfd6f67771dfd0f9c09f9ad8aeb760
Author: Eric Avdey <ei...@eiri.ca>
Date:   2017-01-18T13:55:19Z

    Return "Bad Request" when count in /_uuids exceeds max

----


> Negative parameter count sent to /_uuids lead to crash
> ------------------------------------------------------
>
>                 Key: COUCHDB-3273
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-3273
>             Project: CouchDB
>          Issue Type: Bug
>            Reporter: Eric Avdey
>            Assignee: Eric Avdey
>
> We are checking if "count" is an integer, but not validating that it is positive
> {code}
> $ http :15984/_uuids count==-1
> {
>     "error": "unknown_error",
>     "reason": "function_clause",
>     "ref": 2013513219
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)