You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "kapil-panchal (via GitHub)" <gi...@apache.org> on 2025/09/23 09:14:32 UTC
[PR] FINERACT-2253: New command processing - Account (org.apache.fineract.portfolio.account) [fineract]
kapil-panchal opened a new pull request, #5050:
URL: https://github.com/apache/fineract/pull/5050
## Description
Describe the changes made and why they were made.
This card the plan is to decouple the new command processing infrastructure and push the existing logic to the handlers.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [x] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2253: New command processing - Account (org.apache.fineract.portfolio.account) [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5050:
URL: https://github.com/apache/fineract/pull/5050#issuecomment-3323097971
@kapil-panchal I appreciate your enthusiasm regarding the work on the "New Command Processing", however I was wondering whether you could connect with @vidakovic and discuss quickly whether these PRs are aligning with the vision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2253: New command processing - Account (org.apache.fineract.portfolio.account) [fineract]
Posted by "kapil-panchal (via GitHub)" <gi...@apache.org>.
kapil-panchal commented on PR #5050:
URL: https://github.com/apache/fineract/pull/5050#issuecomment-3323252899
> @kapil-panchal I appreciate your enthusiasm regarding the work on the "New Command Processing", however before you are opening a new PR, I was wondering whether you could connect with @vidakovic and discuss quickly whether these PRs are aligning with the vision.
Sure Adam, I think Aleks is also on the dev@fineract.apache.org email?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2253: New command processing - Account (org.apache.fineract.portfolio.account) [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5050:
URL: https://github.com/apache/fineract/pull/5050#issuecomment-3323363374
> > @kapil-panchal I appreciate your enthusiasm regarding the work on the "New Command Processing", however before you are opening a new PR, I was wondering whether you could connect with @vidakovic and discuss quickly whether these PRs are aligning with the vision.
>
> Sure Adam, I think Aleks is also on the [dev@fineract.apache.org](mailto:dev@fineract.apache.org) email?
Yes, he is, but also you can reach out to him on Mifos Slack.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2253: New command processing - Account (org.apache.fineract.portfolio.account) [fineract]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #5050: FINERACT-2253: New command processing - Account (org.apache.fineract.portfolio.account)
URL: https://github.com/apache/fineract/pull/5050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2253: New command processing - Account (org.apache.fineract.portfolio.account) [fineract]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5050:
URL: https://github.com/apache/fineract/pull/5050#issuecomment-3440030046
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org