You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/10/01 05:48:01 UTC
[GitHub] [incubator-seatunnel] TyrantLucifer opened a new pull request, #2965: [Hotfix][core] Fix spark engine parallelism parameter does not working
TyrantLucifer opened a new pull request, #2965:
URL: https://github.com/apache/incubator-seatunnel/pull/2965
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
fix #2931
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [x] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #2965: [Hotfix][core] Fix spark engine parallelism parameter does not working
Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on code in PR #2965:
URL: https://github.com/apache/incubator-seatunnel/pull/2965#discussion_r985057720
##########
seatunnel-common/src/main/java/org/apache/seatunnel/common/Constants.java:
##########
@@ -31,7 +31,7 @@ public final class Constants {
public static final String SOURCE_SERIALIZATION = "source.serialization";
- public static final String SOURCE_PARALLELISM = "source.parallelism";
+ public static final String SOURCE_PARALLELISM = "parallelism";
Review Comment:
Resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #2965: [Hotfix][core] Fix spark engine parallelism parameter does not working
Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on code in PR #2965:
URL: https://github.com/apache/incubator-seatunnel/pull/2965#discussion_r985057742
##########
seatunnel-core/seatunnel-spark-starter/src/main/java/org/apache/seatunnel/core/starter/spark/execution/SourceExecuteProcessor.java:
##########
@@ -57,6 +57,7 @@ public List<Dataset<Row>> execute(List<Dataset<Row>> upstreamDataStreams) {
Dataset<Row> dataset = sparkEnvironment.getSparkSession()
.read()
.format(SeaTunnelSource.class.getSimpleName())
+ .option(Constants.PARALLELISM, sparkEnvironment.getSparkConf().get(Constants.PARALLELISM))
Review Comment:
Resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #2965: [Hotfix][core] Fix spark engine parallelism parameter does not working
Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on PR #2965:
URL: https://github.com/apache/incubator-seatunnel/pull/2965#issuecomment-1264253735
@ashulin Please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #2965: [Hotfix][core] Fix spark engine parallelism parameter does not working
Posted by GitBox <gi...@apache.org>.
ashulin commented on code in PR #2965:
URL: https://github.com/apache/incubator-seatunnel/pull/2965#discussion_r985055705
##########
seatunnel-core/seatunnel-spark-starter/src/main/java/org/apache/seatunnel/core/starter/spark/execution/SourceExecuteProcessor.java:
##########
@@ -57,6 +57,7 @@ public List<Dataset<Row>> execute(List<Dataset<Row>> upstreamDataStreams) {
Dataset<Row> dataset = sparkEnvironment.getSparkSession()
.read()
.format(SeaTunnelSource.class.getSimpleName())
+ .option(Constants.PARALLELISM, sparkEnvironment.getSparkConf().get(Constants.PARALLELISM))
Review Comment:
Can parallelism be set for a single plugin? If the plugin don‘t set the parallelism, get the global parallelism.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #2965: [Hotfix][core] Fix spark engine parallelism parameter does not working
Posted by GitBox <gi...@apache.org>.
ashulin commented on code in PR #2965:
URL: https://github.com/apache/incubator-seatunnel/pull/2965#discussion_r985055818
##########
seatunnel-common/src/main/java/org/apache/seatunnel/common/Constants.java:
##########
@@ -31,7 +31,7 @@ public final class Constants {
public static final String SOURCE_SERIALIZATION = "source.serialization";
- public static final String SOURCE_PARALLELISM = "source.parallelism";
+ public static final String SOURCE_PARALLELISM = "parallelism";
Review Comment:
marke as @Deprecated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org