You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "justxuewei (via GitHub)" <gi...@apache.org> on 2023/04/11 14:30:24 UTC
[GitHub] [dubbo-go] justxuewei opened a new pull request, #2301: style: Format imports by goimports tool
justxuewei opened a new pull request, #2301:
URL: https://github.com/apache/dubbo-go/pull/2301
Format imports by goimports tool.
Fixes: #2300
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] sonarcloud[bot] commented on pull request #2301: style: Format imports by goimports tool
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2301:
URL: https://github.com/apache/dubbo-go/pull/2301#issuecomment-1503489172
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2301)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2301&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2301&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2301&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2301&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2301&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2301&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2301&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2301&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2301&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2301&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2301&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2301&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2301) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2301&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] sonarcloud[bot] commented on pull request #2301: style: Format imports by goimports tool
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2301:
URL: https://github.com/apache/dubbo-go/pull/2301#issuecomment-1503489721
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2301)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2301&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2301&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2301&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2301&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2301&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2301&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2301&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2301&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2301&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2301&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2301&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2301&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2301) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2301&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] justxuewei closed pull request #2301: style: Format imports by goimports tool
Posted by "justxuewei (via GitHub)" <gi...@apache.org>.
justxuewei closed pull request #2301: style: Format imports by goimports tool
URL: https://github.com/apache/dubbo-go/pull/2301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #2301: style: Format imports by goimports tool
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2301:
URL: https://github.com/apache/dubbo-go/pull/2301#issuecomment-1503517280
## [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/2301?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2301](https://codecov.io/gh/apache/dubbo-go/pull/2301?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b624046) into [main](https://codecov.io/gh/apache/dubbo-go/commit/3fcc135f200431b186424c38ccd576cb0368f6d3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3fcc135) will **decrease** coverage by `0.29%`.
> The diff coverage is `n/a`.
> :exclamation: Current head b624046 differs from pull request most recent head e6d70b1. Consider uploading reports for the commit e6d70b1 to get more accurate results
```diff
@@ Coverage Diff @@
## main #2301 +/- ##
==========================================
- Coverage 44.27% 43.98% -0.29%
==========================================
Files 289 284 -5
Lines 18199 17418 -781
==========================================
- Hits 8058 7662 -396
+ Misses 9293 8947 -346
+ Partials 848 809 -39
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/2301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [cluster/cluster/available/cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/2301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyL2F2YWlsYWJsZS9jbHVzdGVyX2ludm9rZXIuZ28=) | `66.66% <ø> (ø)` | |
| [cluster/cluster/base/cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/2301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyL2Jhc2UvY2x1c3Rlcl9pbnZva2VyLmdv) | `24.44% <ø> (ø)` | |
| [cluster/cluster/broadcast/cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/2301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyL2Jyb2FkY2FzdC9jbHVzdGVyX2ludm9rZXIuZ28=) | `80.00% <ø> (ø)` | |
| [cluster/cluster/failback/cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/2301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyL2ZhaWxiYWNrL2NsdXN0ZXJfaW52b2tlci5nbw==) | `78.02% <ø> (+2.19%)` | :arrow_up: |
| [cluster/cluster/failfast/cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/2301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyL2ZhaWxmYXN0L2NsdXN0ZXJfaW52b2tlci5nbw==) | `71.42% <ø> (ø)` | |
| [cluster/cluster/failover/cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/2301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyL2ZhaWxvdmVyL2NsdXN0ZXJfaW52b2tlci5nbw==) | `66.66% <ø> (ø)` | |
| [cluster/cluster/failsafe/cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/2301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyL2ZhaWxzYWZlL2NsdXN0ZXJfaW52b2tlci5nbw==) | `81.81% <ø> (ø)` | |
| [cluster/cluster/forking/cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/2301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyL2ZvcmtpbmcvY2x1c3Rlcl9pbnZva2VyLmdv) | `58.33% <ø> (ø)` | |
| [cluster/cluster/zoneaware/cluster\_interceptor.go](https://codecov.io/gh/apache/dubbo-go/pull/2301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyL3pvbmVhd2FyZS9jbHVzdGVyX2ludGVyY2VwdG9yLmdv) | `40.00% <ø> (ø)` | |
| [cluster/cluster/zoneaware/cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/2301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyL3pvbmVhd2FyZS9jbHVzdGVyX2ludm9rZXIuZ28=) | `80.55% <ø> (ø)` | |
| ... and [136 more](https://codecov.io/gh/apache/dubbo-go/pull/2301?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
... and [89 files with indirect coverage changes](https://codecov.io/gh/apache/dubbo-go/pull/2301/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] chickenlj commented on pull request #2301: style: Format imports by goimports tool
Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj commented on PR #2301:
URL: https://github.com/apache/dubbo-go/pull/2301#issuecomment-1510835549
I suggest applying new format only to newly added codes. Avoid reformating the whole codebase. Is that possible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on pull request #2301: style: Format imports by goimports tool
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks commented on PR #2301:
URL: https://github.com/apache/dubbo-go/pull/2301#issuecomment-1510611095
我想了下，这个工作没啥必要。因为已经有工具了，而且你格式化后的代码看起来也并不漂亮。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org