You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by corneadoug <gi...@git.apache.org> on 2015/04/29 09:42:07 UTC

[GitHub] incubator-zeppelin pull request: Zeppelin-web Spring Cleaning

GitHub user corneadoug opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/56

    Zeppelin-web Spring Cleaning

    After so much time in the Wild Wild West of Internet, It's Time for the Spring Cleaning of Zeppelin-web.
    This PR will be taking care of cleaning the code, architecture, cutting code into smaller pieces etc...
    
    * [x] - Change Code Folder Structure to a Folder Tree Style
    * [x] - Change original code and compiled code folder names
    * [ ] - Update Contributing README.md to explain most of changes
    * [ ] - Organize well the components and app folders
    * [ ] - Replace as much code as possible by their underscore.js counterpart
    * [ ] - Cut the code into more smaller components (who said paragraph.js?)
    * [ ] - Move Jquery code out of the controllers (by directive when possible or to somewhere else)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/corneadoug/incubator-zeppelin improvement/SpringCleaning

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/56.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #56
    
----
commit 4c16ce27394ccd9f619503bad092fffa1015798f
Author: Damien Corneau <co...@gmail.com>
Date:   2015-04-27T08:13:28Z

    Add spark dependency reduced pom to gitignore

commit 3f90923bfe658e79352899f019a43a9a5c74f9bb
Author: Damien Corneau <co...@gmail.com>
Date:   2015-04-28T09:24:53Z

    Change Zeppelin Folder Structure and its GruntFile

commit 5c23ef5ea2dfe9e3712a3d9796febeeeae500d62
Author: Damien Corneau <co...@gmail.com>
Date:   2015-04-29T03:06:43Z

    Fix Grunt watch

commit 8a4a6ce5698c75be9eeecb57290d2966cd560a59
Author: Damien Corneau <co...@gmail.com>
Date:   2015-04-29T07:30:04Z

    Change Zeppelin-web code and compiled code folders

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin-web Spring Cleaning

Posted by felizbear <gi...@git.apache.org>.
Github user felizbear commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/56#issuecomment-112082285
  
    Looks good!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin-web Spring Cleaning

Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/56#issuecomment-117892001
  
    CI is green!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin-web Spring Cleaning

Posted by felizbear <gi...@git.apache.org>.
Github user felizbear commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/56#issuecomment-111355208
  
    It's okay. I just have an aversion to `this` and try to eliminate it from my code. Up to you.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] incubator-zeppelin pull request: Zeppelin-web Spring Cleaning

Posted by madhuka udantha <ma...@gmail.com>.
Thanks for sharing the information

On Thu, Apr 30, 2015 at 9:29 AM, felixcheung <gi...@git.apache.org> wrote:

> Github user felixcheung commented on the pull request:
>
>
> https://github.com/apache/incubator-zeppelin/pull/56#issuecomment-97653953
>
>     thanks for the explanation. I saw other files 'moved' but these two
> were 'deleted' as per git, so just want to check.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>



-- 
Cheers,
Madhuka Udantha
http://madhukaudantha.blogspot.com

[GitHub] incubator-zeppelin pull request: Zeppelin-web Spring Cleaning

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/56#issuecomment-97653953
  
    thanks for the explanation. I saw other files 'moved' but these two were 'deleted' as per git, so just want to check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin-web Spring Cleaning

Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/56#issuecomment-117899289
  
    Great, Seems I can start my work on here.
    
    On Thu, Jul 2, 2015 at 9:31 AM, Lee moon soo <no...@github.com>
    wrote:
    
    > LGTM let's merge
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/incubator-zeppelin/pull/56#issuecomment-117898562>
    > .
    >
    
    
    
    -- 
    Cheers,
    Madhuka Udantha
    http://madhukaudantha.blogspot.com



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin-web Spring Cleaning

Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/56#issuecomment-117402931
  
    @Madhuka Not really. There is only some ng-doc on some controllers, not all (they were generated by yeoman), so it doesn't really document much. Also we don't use ng-doc in our grunt file, so its not even generating documentation out of it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin-web Spring Cleaning

Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/56#issuecomment-117601870
  
    This is good for Test and Merge :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin-web Spring Cleaning

Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/56#issuecomment-111961630
  
    This is what the Paragraph Form changes looks like.
    Before, The label used to be squashed by the input, and on big screen they would not take 100% width and be under each other
    
    ![screen shot 2015-06-15 at 3 52 43 pm](https://cloud.githubusercontent.com/assets/710411/8154789/caafcc64-1378-11e5-95c9-c112500521c9.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin-web Spring Cleaning

Posted by felizbear <gi...@git.apache.org>.
Github user felizbear commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/56#issuecomment-117640636
  
    Is it okay that Travis is complaining?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin-web Spring Cleaning

Posted by felizbear <gi...@git.apache.org>.
Github user felizbear commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/56#issuecomment-116695972
  
    @corneadoug go for it man!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin-web Spring Cleaning

Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/56#issuecomment-117536698
  
    Just Rebased it all, Need to verify and modify some previous pull requests now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin-web Spring Cleaning

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/56#issuecomment-117898562
  
    LGTM let's merge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin-web Spring Cleaning

Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/56#issuecomment-116597292
  
    I think I'm gonna Rebase master in this PR, and then it will be good to go.
    This is a good base, and already a lot of work has been done here.
    We can continue working on cleaning more the code in Other smaller PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin-web Spring Cleaning

Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/56#issuecomment-102987354
  
    @felixcheung looks like you were right, paragraph.js and notebook.js were not there. Realized that after git clean.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin-web Spring Cleaning

Posted by felizbear <gi...@git.apache.org>.
Github user felizbear commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/56#issuecomment-111350416
  
    @corneadoug I skimmed through the last three commits. It looks like you did a nice job. Using `controller as` pattern is definitely an improvement. The other thing I have to mention that services are singletons (https://github.com/johnpapa/angular-styleguide#singletons), so you'll be better off returning an object instead of using `this`.
    E.g.
    ```javascript
    this.deleteNotebook = function(noteId) {}
    this.getNotebookList = function() {}
    ```
    would become
    ```javascript
    return {
      deleteNotebook = function() {},
      getNotebookList = function() {}
    }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin-web Spring Cleaning

Posted by felizbear <gi...@git.apache.org>.
Github user felizbear commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/56#issuecomment-117897603
  
    Looks like it's ready for merge!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin-web Spring Cleaning

Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/56#issuecomment-117868684
  
    I forgot to do the mvn verify. It could be the license check failing.
    Anyway, I will fix it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin-web Spring Cleaning

Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/56#issuecomment-111353057
  
    Yeah, but like your link show, services while being a singleton (just like everything in angular) are usually use as public functions only (transformation functions mainly) and do not hold any variables.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin-web Spring Cleaning

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/56


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin-web Spring Cleaning

Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/56#issuecomment-97629349
  
    Didn't update the doc to explain the folder strcture yet.
    
    But now, src is the source folder, and the generated code on build go to dist folder.
    
    For the source code, you will find it organised by module (home.html, home.css, home.controller.js for example) either in the src/app folder or src/components folder.
    
    Src/app is for page related content, and each page is containing its own modules. Src/components is for modules used in different places (navbar for example).
    
    Now you can place files wherever you want in app and components, folders and have as much sub folder as you want, however you will need to register the .js files in index.html


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Zeppelin-web Spring Cleaning

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/56#issuecomment-97620298
  
    where did controllers/notebook.js or controllers/paragraph.js go?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---