You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/08 15:52:07 UTC
[GitHub] [superset] codecov-io edited a comment on pull request #13000: fix(native-filters) set currentValue null when empty
codecov-io edited a comment on pull request #13000:
URL: https://github.com/apache/superset/pull/13000#issuecomment-775243733
# [Codecov](https://codecov.io/gh/apache/superset/pull/13000?src=pr&el=h1) Report
> Merging [#13000](https://codecov.io/gh/apache/superset/pull/13000?src=pr&el=desc) (3fa9fd3) into [master](https://codecov.io/gh/apache/superset/commit/c440d98fadaf5ee1859bd8c4a01036fb71f1753a?el=desc) (c440d98) will **increase** coverage by `17.23%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13000?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13000 +/- ##
===========================================
+ Coverage 53.17% 70.40% +17.23%
===========================================
Files 449 545 +96
Lines 14826 20161 +5335
Branches 3959 5268 +1309
===========================================
+ Hits 7884 14195 +6311
+ Misses 6942 5824 -1118
- Partials 0 142 +142
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.94% <100.00%> (-2.24%)` | :arrow_down: |
| javascript | `61.86% <0.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13000?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ponents/nativeFilters/FilterBar/CascadePopover.tsx](https://codecov.io/gh/apache/superset/pull/13000/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVQb3BvdmVyLnRzeA==) | `97.10% <100.00%> (+0.43%)` | :arrow_up: |
| [...src/filters/components/Select/AntdSelectFilter.tsx](https://codecov.io/gh/apache/superset/pull/13000/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvQW50ZFNlbGVjdEZpbHRlci50c3g=) | `82.50% <100.00%> (-14.28%)` | :arrow_down: |
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13000/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `18.18% <0.00%> (-81.82%)` | :arrow_down: |
| [superset-frontend/src/views/index.tsx](https://codecov.io/gh/apache/superset/pull/13000/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2luZGV4LnRzeA==) | `25.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...ntend/src/filters/components/Range/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/13000/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS9jb250cm9sUGFuZWwudHM=) | `25.00% <0.00%> (-75.00%)` | :arrow_down: |
| [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/superset/pull/13000/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `25.58% <0.00%> (-74.42%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/index.ts](https://codecov.io/gh/apache/superset/pull/13000/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvaW5kZXgudHM=) | `40.00% <0.00%> (-60.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupPlugins.ts](https://codecov.io/gh/apache/superset/pull/13000/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2lucy50cw==) | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
| [superset-frontend/src/setup/setupPluginsExtra.ts](https://codecov.io/gh/apache/superset/pull/13000/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2luc0V4dHJhLnRz) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...rset-frontend/src/setup/setupErrorMessagesExtra.ts](https://codecov.io/gh/apache/superset/pull/13000/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRXJyb3JNZXNzYWdlc0V4dHJhLnRz) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| ... and [429 more](https://codecov.io/gh/apache/superset/pull/13000/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13000?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13000?src=pr&el=footer). Last update [c440d98...3fa9fd3](https://codecov.io/gh/apache/superset/pull/13000?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org