You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2017/07/19 10:54:59 UTC
Review Request 60964: LENS-1453: Method metrics names duplicate for
segmentation inner rewrite
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60964/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-1453
https://issues.apache.org/jira/browse/LENS-1453
Repository: lens
Description
-------
{noformat}
java.lang.IllegalArgumentException: A metric named lens.MethodMetricGauge.9a18f287-a40f-4108-b499-932c3edf6eaa-hive/prod-org.apache.lens.cube.parse.ColumnResolver-ITER-0 already exists
at com.codahale.metrics.MetricRegistry.register(MetricRegistry.java:91) ~[metrics-core-3.0.2.jar:3.0.2]
at org.apache.lens.server.api.metrics.MethodMetricGauge.markSuccess(MethodMetricGauge.java:61) ~[lens-server-api-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
at org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:264) ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
at org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:232) ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
at org.apache.lens.cube.parse.SegmentationCandidate.rewriteInternal(SegmentationCandidate.java:145) ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
at org.apache.lens.cube.parse.SegmentationInnerRewriter$Exploder.shouldBeRemoved(SegmentationInnerRewriter.java:57) ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
at org.apache.lens.cube.parse.SegmentationInnerRewriter$Exploder.access$300(SegmentationInnerRewriter.java:49) ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
at org.apache.lens.cube.parse.SegmentationInnerRewriter.lambda$rewriteContext$0(SegmentationInnerRewriter.java:46) ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
at org.apache.lens.cube.parse.SegmentationInnerRewriter$$Lambda$82/1668365591.test(Unknown Source) ~[na:na]
at java.util.Collection.removeIf(Collection.java:414) ~[na:1.8.0_40]
at org.apache.lens.cube.parse.SegmentationInnerRewriter.rewriteContext(SegmentationInnerRewriter.java:46) ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
at org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:263) ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
at org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:232) ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
at org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:248) ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
at org.apache.lens.server.rewrite.RewriteUtil$DriverRewriterRunnable.run(RewriteUtil.java:392) ~[classes/:na]
at org.apache.lens.server.query.QueryExecutionServiceImpl$RewriteEstimateRunnable.run(QueryExecutionServiceImpl.java:1855) [classes/:na]
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [na:1.8.0_40]
at java.util.concurrent.FutureTask.run(FutureTask.java:266) [na:1.8.0_40]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [na:1.8.0_40]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [na:1.8.0_40]
at java.lang.Thread.run(Thread.java:745) [na:1.8.0_40]
{noformat}
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/SegmentationCandidate.java a2bd485005272f5fbb4d71879716f2afb5bc6771
Diff: https://reviews.apache.org/r/60964/diff/1/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 60964: LENS-1453: Method metrics names duplicate
for segmentation inner rewrite
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60964/#review180915
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On July 19, 2017, 10:54 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60964/
> -----------------------------------------------------------
>
> (Updated July 19, 2017, 10:54 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1453
> https://issues.apache.org/jira/browse/LENS-1453
>
>
> Repository: lens
>
>
> Description
> -------
>
> {noformat}
> java.lang.IllegalArgumentException: A metric named lens.MethodMetricGauge.9a18f287-a40f-4108-b499-932c3edf6eaa-hive/prod-org.apache.lens.cube.parse.ColumnResolver-ITER-0 already exists
> at com.codahale.metrics.MetricRegistry.register(MetricRegistry.java:91) ~[metrics-core-3.0.2.jar:3.0.2]
> at org.apache.lens.server.api.metrics.MethodMetricGauge.markSuccess(MethodMetricGauge.java:61) ~[lens-server-api-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
> at org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:264) ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
> at org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:232) ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
> at org.apache.lens.cube.parse.SegmentationCandidate.rewriteInternal(SegmentationCandidate.java:145) ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
> at org.apache.lens.cube.parse.SegmentationInnerRewriter$Exploder.shouldBeRemoved(SegmentationInnerRewriter.java:57) ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
> at org.apache.lens.cube.parse.SegmentationInnerRewriter$Exploder.access$300(SegmentationInnerRewriter.java:49) ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
> at org.apache.lens.cube.parse.SegmentationInnerRewriter.lambda$rewriteContext$0(SegmentationInnerRewriter.java:46) ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
> at org.apache.lens.cube.parse.SegmentationInnerRewriter$$Lambda$82/1668365591.test(Unknown Source) ~[na:na]
> at java.util.Collection.removeIf(Collection.java:414) ~[na:1.8.0_40]
> at org.apache.lens.cube.parse.SegmentationInnerRewriter.rewriteContext(SegmentationInnerRewriter.java:46) ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
> at org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:263) ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
> at org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:232) ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
> at org.apache.lens.cube.parse.CubeQueryRewriter.rewrite(CubeQueryRewriter.java:248) ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
> at org.apache.lens.server.rewrite.RewriteUtil$DriverRewriterRunnable.run(RewriteUtil.java:392) ~[classes/:na]
> at org.apache.lens.server.query.QueryExecutionServiceImpl$RewriteEstimateRunnable.run(QueryExecutionServiceImpl.java:1855) [classes/:na]
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [na:1.8.0_40]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) [na:1.8.0_40]
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [na:1.8.0_40]
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [na:1.8.0_40]
> at java.lang.Thread.run(Thread.java:745) [na:1.8.0_40]
>
> {noformat}
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/SegmentationCandidate.java a2bd485005272f5fbb4d71879716f2afb5bc6771
>
>
> Diff: https://reviews.apache.org/r/60964/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>