You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/09/13 02:05:07 UTC
[GitHub] [cordova-ios] breautek commented on a change in pull request #1133: Update Readme: Xcode and clean
breautek commented on a change in pull request #1133:
URL: https://github.com/apache/cordova-ios/pull/1133#discussion_r706956510
##########
File path: README.md
##########
@@ -7,9 +7,9 @@
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
-#
+#
Review comment:
I'd avoid making changes to the LICENSE blurps... we have scripts that scans files and this may trip a complaint. Not sure if these run on markdown files or not... but better safe than sorry.
##########
File path: README.md
##########
@@ -47,20 +47,24 @@ cordova platform add --link /path/to/cordova-ios
## Updating a Cordova project
-When you install a new `cordova-cli` version that comes with a new iOS platform version, from within your project:
+When you install a new version of the [`Cordova CLI`](https://www.npmjs.com/package/cordova) that pins a new version of the [`Cordova-iOS`](https://www.npmjs.com/package/cordova-ios) platform, you can follow these simple upgrade steps within your project:
Review comment:
I think it's better to reference `Cordova-iOS` as the package name literally, `cordova-ios`, which also makes this consistent with other parts of the docs, such as:
> link the appropriate cordova-ios platform folder path:
```suggestion
When you install a new version of the [`Cordova CLI`](https://www.npmjs.com/package/cordova) that pins a new version of the [`cordova-ios`](https://www.npmjs.com/package/cordova-ios) platform, you can follow these simple upgrade steps within your project:
```
##########
File path: README.md
##########
@@ -7,9 +7,9 @@
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
-#
+#
# http://www.apache.org/licenses/LICENSE-2.0
-#
+#
Review comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org