You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2019/04/30 12:42:00 UTC

[jira] [Commented] (AMQ-7191) AutoTcpTransportServer creates new OpenWire protocol verifier object for every connection

    [ https://issues.apache.org/jira/browse/AMQ-7191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16830249#comment-16830249 ] 

ASF subversion and git services commented on AMQ-7191:
------------------------------------------------------

Commit bf3a9f44f625ef26e3c687be92e73ee1e9288d6f in activemq's branch refs/heads/master from Christopher L. Shannon (cshannon)
[ https://gitbox.apache.org/repos/asf?p=activemq.git;h=bf3a9f4 ]

AMQ-7191 - Prevent extra creation of openwire verifier objects per new
connection when using the auto transport


> AutoTcpTransportServer creates new OpenWire protocol verifier object for every connection
> -----------------------------------------------------------------------------------------
>
>                 Key: AMQ-7191
>                 URL: https://issues.apache.org/jira/browse/AMQ-7191
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: Broker, Transport
>    Affects Versions: 5.15.9
>            Reporter: Christopher L. Shannon
>            Assignee: Christopher L. Shannon
>            Priority: Minor
>             Fix For: 5.15.10
>
>
> I was looking at the Auto transport and noticed that every time a new OpenWire connection is made the AutoTcpTransportServer is creating a new OpenWireProtocolVerifier object with an updated wireformat factory and updating the verifiers map.  There is no point to this as the wire format factory with updated options from the client isn't actually necessary to detect the protocol so this can be removed and prevent creating a bunch of new objects to garbage collect.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)