You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "ashoknan2 (via GitHub)" <gi...@apache.org> on 2023/04/06 17:13:37 UTC
[GitHub] [commons-validator] ashoknan2 opened a new pull request, #129: ISINValidator. Added additional exception country code
ashoknan2 opened a new pull request, #129:
URL: https://github.com/apache/commons-validator/pull/129
Currently ISIN validator missing the country validation for codes like EU. These are exceptional codes. This is detailed in
https://www.iso.org/obp/ui/#iso:pub:PUB500001:en. Added the list of exceptional codes to the validator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ISINValidator. Added additional exception country code [commons-validator]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #129:
URL: https://github.com/apache/commons-validator/pull/129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-validator] ashoknan2 commented on pull request #129: ISINValidator. Added additional exception country code
Posted by "ashoknan2 (via GitHub)" <gi...@apache.org>.
ashoknan2 commented on PR #129:
URL: https://github.com/apache/commons-validator/pull/129#issuecomment-1500356821
Added the test case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-validator] ashoknan2 commented on pull request #129: ISINValidator. Added additional exception country code
Posted by "ashoknan2 (via GitHub)" <gi...@apache.org>.
ashoknan2 commented on PR #129:
URL: https://github.com/apache/commons-validator/pull/129#issuecomment-1502048262
Please let me know if this PR has any issues?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-validator] garydgregory commented on pull request #129: ISINValidator. Added additional exception country code
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #129:
URL: https://github.com/apache/commons-validator/pull/129#issuecomment-1499494963
This PR has no tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-validator] garydgregory commented on pull request #129: ISINValidator. Added additional exception country code
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #129:
URL: https://github.com/apache/commons-validator/pull/129#issuecomment-1502283636
I will review this weekend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ISINValidator. Added additional exception country code [commons-validator]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #129:
URL: https://github.com/apache/commons-validator/pull/129#issuecomment-2016555453
## [Codecov](https://app.codecov.io/gh/apache/commons-validator/pull/129?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 72.25%. Comparing base [(`ddeaf3f`)](https://app.codecov.io/gh/apache/commons-validator/commit/ddeaf3fff4f38ce08befe566b27f508e392d8a96?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`c0acc2e`)](https://app.codecov.io/gh/apache/commons-validator/pull/129?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 64 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #129 +/- ##
============================================
+ Coverage 72.00% 72.25% +0.24%
- Complexity 1151 1153 +2
============================================
Files 63 63
Lines 3090 3092 +2
Branches 532 534 +2
============================================
+ Hits 2225 2234 +9
+ Misses 672 662 -10
- Partials 193 196 +3
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/commons-validator/pull/129?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org