You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/15 00:04:34 UTC
[GitHub] [arrow] tachyonwill opened a new pull request #12427: PARQUET-2124: Remove Parquet Dictionary DCHECK
tachyonwill opened a new pull request #12427:
URL: https://github.com/apache/arrow/pull/12427
DCHECK doesn't make sense here as we can hit this condition due to
Parquet file with a non-dictionary encoded data page followed by a
dictionary encoded data page(dictionary page before both data pages).
Nothing in Parquet spec seems to preclude this and this should work with
decoding logic. See JIRA for more evidence in support of this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #12427: PARQUET-2124: [C++] Remove Parquet Dictionary DCHECK
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #12427:
URL: https://github.com/apache/arrow/pull/12427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12427: PARQUET-2124: Remove Parquet Dictionary DCHECK
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12427:
URL: https://github.com/apache/arrow/pull/12427#issuecomment-1039701625
https://issues.apache.org/jira/browse/PARQUET-2124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12427: PARQUET-2124: [C++] Remove Parquet Dictionary DCHECK
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12427:
URL: https://github.com/apache/arrow/pull/12427#issuecomment-1040592605
Benchmark runs are scheduled for baseline = d414f030b5c9edab778b23b85bc0fa766499b81f and contender = 6a2ee11d30676f99e40dfd9af94915981180510b. 6a2ee11d30676f99e40dfd9af94915981180510b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/d3fb8ca574ca42e590dfd0a5b2ea7c39...76f91706c7c7454abc183876a93df010/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/b9e4eab944294c4aa8af549b09889770...e04b89e7418f407e9273c377eb810a07/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a6c3ceb8c2034b61a8860f51a4e57684...3ed781cf1b704a5eb320d8509aa27f51/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/05366462d45e4648afff2cfc139b1de0...ed5b648699064c1ca4949d72bed2ac83/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12427: PARQUET-2124: Remove Parquet Dictionary DCHECK
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12427:
URL: https://github.com/apache/arrow/pull/12427#issuecomment-1039701625
https://issues.apache.org/jira/browse/PARQUET-2124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #12427: PARQUET-2124: [C++] Remove Parquet Dictionary DCHECK
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #12427:
URL: https://github.com/apache/arrow/pull/12427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12427: PARQUET-2124: [C++] Remove Parquet Dictionary DCHECK
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12427:
URL: https://github.com/apache/arrow/pull/12427#issuecomment-1040592605
Benchmark runs are scheduled for baseline = d414f030b5c9edab778b23b85bc0fa766499b81f and contender = 6a2ee11d30676f99e40dfd9af94915981180510b. 6a2ee11d30676f99e40dfd9af94915981180510b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/d3fb8ca574ca42e590dfd0a5b2ea7c39...76f91706c7c7454abc183876a93df010/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/b9e4eab944294c4aa8af549b09889770...e04b89e7418f407e9273c377eb810a07/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a6c3ceb8c2034b61a8860f51a4e57684...3ed781cf1b704a5eb320d8509aa27f51/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/05366462d45e4648afff2cfc139b1de0...ed5b648699064c1ca4949d72bed2ac83/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12427: PARQUET-2124: [C++] Remove Parquet Dictionary DCHECK
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12427:
URL: https://github.com/apache/arrow/pull/12427#issuecomment-1040592605
Benchmark runs are scheduled for baseline = d414f030b5c9edab778b23b85bc0fa766499b81f and contender = 6a2ee11d30676f99e40dfd9af94915981180510b. 6a2ee11d30676f99e40dfd9af94915981180510b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/d3fb8ca574ca42e590dfd0a5b2ea7c39...76f91706c7c7454abc183876a93df010/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/b9e4eab944294c4aa8af549b09889770...e04b89e7418f407e9273c377eb810a07/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a6c3ceb8c2034b61a8860f51a4e57684...3ed781cf1b704a5eb320d8509aa27f51/)
[Finished :arrow_down:0.26% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/05366462d45e4648afff2cfc139b1de0...ed5b648699064c1ca4949d72bed2ac83/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12427: PARQUET-2124: [C++] Remove Parquet Dictionary DCHECK
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12427:
URL: https://github.com/apache/arrow/pull/12427#issuecomment-1040592605
Benchmark runs are scheduled for baseline = d414f030b5c9edab778b23b85bc0fa766499b81f and contender = 6a2ee11d30676f99e40dfd9af94915981180510b. 6a2ee11d30676f99e40dfd9af94915981180510b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/d3fb8ca574ca42e590dfd0a5b2ea7c39...76f91706c7c7454abc183876a93df010/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/b9e4eab944294c4aa8af549b09889770...e04b89e7418f407e9273c377eb810a07/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a6c3ceb8c2034b61a8860f51a4e57684...3ed781cf1b704a5eb320d8509aa27f51/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/05366462d45e4648afff2cfc139b1de0...ed5b648699064c1ca4949d72bed2ac83/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12427: PARQUET-2124: [C++] Remove Parquet Dictionary DCHECK
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12427:
URL: https://github.com/apache/arrow/pull/12427#issuecomment-1040592605
Benchmark runs are scheduled for baseline = d414f030b5c9edab778b23b85bc0fa766499b81f and contender = 6a2ee11d30676f99e40dfd9af94915981180510b. 6a2ee11d30676f99e40dfd9af94915981180510b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/d3fb8ca574ca42e590dfd0a5b2ea7c39...76f91706c7c7454abc183876a93df010/)
[Finished :arrow_down:0.0% :arrow_up:0.34%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/b9e4eab944294c4aa8af549b09889770...e04b89e7418f407e9273c377eb810a07/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a6c3ceb8c2034b61a8860f51a4e57684...3ed781cf1b704a5eb320d8509aa27f51/)
[Finished :arrow_down:0.26% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/05366462d45e4648afff2cfc139b1de0...ed5b648699064c1ca4949d72bed2ac83/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12427: PARQUET-2124: [C++] Remove Parquet Dictionary DCHECK
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12427:
URL: https://github.com/apache/arrow/pull/12427#issuecomment-1040592605
Benchmark runs are scheduled for baseline = d414f030b5c9edab778b23b85bc0fa766499b81f and contender = 6a2ee11d30676f99e40dfd9af94915981180510b. 6a2ee11d30676f99e40dfd9af94915981180510b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/d3fb8ca574ca42e590dfd0a5b2ea7c39...76f91706c7c7454abc183876a93df010/)
[Finished :arrow_down:0.0% :arrow_up:0.34%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/b9e4eab944294c4aa8af549b09889770...e04b89e7418f407e9273c377eb810a07/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a6c3ceb8c2034b61a8860f51a4e57684...3ed781cf1b704a5eb320d8509aa27f51/)
[Finished :arrow_down:0.26% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/05366462d45e4648afff2cfc139b1de0...ed5b648699064c1ca4949d72bed2ac83/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12427: PARQUET-2124: [C++] Remove Parquet Dictionary DCHECK
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12427:
URL: https://github.com/apache/arrow/pull/12427#issuecomment-1040592605
Benchmark runs are scheduled for baseline = d414f030b5c9edab778b23b85bc0fa766499b81f and contender = 6a2ee11d30676f99e40dfd9af94915981180510b. 6a2ee11d30676f99e40dfd9af94915981180510b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/d3fb8ca574ca42e590dfd0a5b2ea7c39...76f91706c7c7454abc183876a93df010/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/b9e4eab944294c4aa8af549b09889770...e04b89e7418f407e9273c377eb810a07/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a6c3ceb8c2034b61a8860f51a4e57684...3ed781cf1b704a5eb320d8509aa27f51/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/05366462d45e4648afff2cfc139b1de0...ed5b648699064c1ca4949d72bed2ac83/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org