You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2015/07/31 22:34:29 UTC
Review Request 36994: Splitting TaskGroups related tests from
TaskSchedulerTest
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36994/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Repository: aurora
Description
-------
Trying to make the upcoming diff removing TaskSchedulerTest simpler to review.
Diffs
-----
src/test/java/org/apache/aurora/scheduler/scheduling/TaskGroupsTest.java 10de372968570d149106d987e1493bad28ad5637
Diff: https://reviews.apache.org/r/36994/diff/
Testing
-------
Thanks,
Maxim Khutornenko
Re: Review Request 36994: Splitting TaskGroups related tests from
TaskSchedulerTest
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36994/#review93781
-----------------------------------------------------------
Ship it!
LGTM once the summary is updated to reflect the change.
- Bill Farner
On July 31, 2015, 8:34 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36994/
> -----------------------------------------------------------
>
> (Updated July 31, 2015, 8:34 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Trying to make the upcoming diff removing TaskSchedulerTest simpler to review.
>
>
> Diffs
> -----
>
> src/test/java/org/apache/aurora/scheduler/scheduling/TaskGroupsTest.java 10de372968570d149106d987e1493bad28ad5637
>
> Diff: https://reviews.apache.org/r/36994/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 36994: Adding missing coverage in TaskGroups
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36994/
-----------------------------------------------------------
(Updated July 31, 2015, 9:21 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
Updated the title and description.
Summary (updated)
-----------------
Adding missing coverage in TaskGroups
Repository: aurora
Description (updated)
-------
This diff adds missing coverage for TaskGroups, which is currently provided via TaskSchedulerTest. Trying to make the upcoming diff removing TaskSchedulerTest simpler to review.
Diffs
-----
src/test/java/org/apache/aurora/scheduler/scheduling/TaskGroupsTest.java 10de372968570d149106d987e1493bad28ad5637
Diff: https://reviews.apache.org/r/36994/diff/
Testing
-------
Thanks,
Maxim Khutornenko
Re: Review Request 36994: Splitting TaskGroups related tests from
TaskSchedulerTest
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36994/#review93777
-----------------------------------------------------------
Ship it!
Master (d327773) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On July 31, 2015, 8:34 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36994/
> -----------------------------------------------------------
>
> (Updated July 31, 2015, 8:34 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Trying to make the upcoming diff removing TaskSchedulerTest simpler to review.
>
>
> Diffs
> -----
>
> src/test/java/org/apache/aurora/scheduler/scheduling/TaskGroupsTest.java 10de372968570d149106d987e1493bad28ad5637
>
> Diff: https://reviews.apache.org/r/36994/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>